All of lore.kernel.org
 help / color / mirror / Atom feed
From: naamax.meir <naamax.meir@linux.intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2] e1000e: Print PHY register address when MDI read/write fails
Date: Wed, 23 Feb 2022 09:02:29 +0200	[thread overview]
Message-ID: <723d2a6c-8f5a-8e26-73d9-e96a289ff9af@linux.intel.com> (raw)
In-Reply-To: <20220210132256.53589-1-yu.c.chen@intel.com>

On 2/10/2022 15:22, Chen Yu wrote:
> There is occasional suspend error from e1000e which blocks the
> system from further suspending. And the issue was found on
> a WhiskeyLake-U platform with I219-V:
>
> [   20.078957] PM: pci_pm_suspend(): e1000e_pm_suspend+0x0/0x780 [e1000e] returns -2
> [   20.078970] PM: dpm_run_callback(): pci_pm_suspend+0x0/0x170 returns -2
> [   20.078974] e1000e 0000:00:1f.6: PM: pci_pm_suspend+0x0/0x170 returned -2 after 371012 usecs
> [   20.078978] e1000e 0000:00:1f.6: PM: failed to suspend async: error -2
>
> According to the code flow, this might be caused by broken MDI read/write
> to PHY registers. However currently the code does not tell us which
> register is broken. Thus enhance the debug information to print the
> offender PHY register. So the next the issue is reproduced, this
> information could be used for narrow down.
>
> Acked-by: Paul Menzel<pmenzel@molgen.mpg.de>
> Reported-by: Todd Brandt<todd.e.brandt@intel.com>
> Signed-off-by: Chen Yu<yu.c.chen@intel.com>
> ---
>   drivers/net/ethernet/intel/e1000e/phy.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20220223/6bef2cfd/attachment-0001.html>

      reply	other threads:[~2022-02-23  7:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 13:22 [PATCH v2] e1000e: Print PHY register address when MDI read/write fails Chen Yu
2022-02-10 13:22 ` [Intel-wired-lan] " Chen Yu
2022-02-23  7:02 ` naamax.meir [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=723d2a6c-8f5a-8e26-73d9-e96a289ff9af@linux.intel.com \
    --to=naamax.meir@linux.intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.