From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Lis, Tomasz" Subject: Re: [PATCH v8 1/7] drm/i915: initialize unused MOCS entries to PTE Date: Wed, 23 Jan 2019 19:33:35 +0100 Message-ID: <72492fb8-f8f4-5ef2-c1b9-d3d04b98230a@intel.com> References: <20190122051227.8329-1-lucas.demarchi@intel.com> <20190122051227.8329-2-lucas.demarchi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E3F36EFF8 for ; Wed, 23 Jan 2019 18:33:39 +0000 (UTC) In-Reply-To: <20190122051227.8329-2-lucas.demarchi@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAyMDE5LTAxLTIyIDA2OjEyLCBMdWNhcyBEZSBNYXJjaGkgd3JvdGU6Cj4gSW5zdGVhZCBv ZiBpbml0aWFsaXppbmcgdGhlbSB0byB1bmNhY2hlZCwgbGV0J3Mgc2V0IHRoZW0gdG8gUFRFIGZv cgo+IGtlcm5lbCB0cmFja2luZy4gV2hpbGUgYXQgaXQgZG8gc29tZSBtaW5vciBhZGp1c3RtZW50 cyB0byBjb21tZW50cyBhbmQKPiBjb2Rpbmcgc3R5bGUuCj4KPiBTaWduZWQtb2ZmLWJ5OiBMdWNh cyBEZSBNYXJjaGkgPGx1Y2FzLmRlbWFyY2hpQGludGVsLmNvbT4KUmV2aWV3ZWQtYnk6IFRvbWFz eiBMaXMgPHRvbWFzei5saXNAaW50ZWwuY29tPgpPbmUgY29tbWVudCAod2l0aCBubyBleHBlY3Rh dGlvbnMgZm9yIGNoYW5nZSkgYmVsb3cuCj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9tb2NzLmMgfCA1NiArKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCj4gICAxIGZp bGUgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgMzMgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbW9jcy5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfbW9jcy5jCj4gaW5kZXggZTk3NmM1Y2U1NDc5Li4wZDZiOTRhMjM5ZDYgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbW9jcy5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbW9jcy5jCj4gQEAgLTg1LDEwICs4NSw3IEBAIHN0cnVj dCBkcm1faTkxNV9tb2NzX3RhYmxlIHsKPiAgICAqCj4gICAgKiBFbnRyaWVzIG5vdCBwYXJ0IG9m IHRoZSBmb2xsb3dpbmcgdGFibGVzIGFyZSB1bmRlZmluZWQgYXMgZmFyIGFzCj4gICAgKiB1c2Vy c3BhY2UgaXMgY29uY2VybmVkIGFuZCBzaG91bGRuJ3QgYmUgcmVsaWVkIHVwb24uICBGb3IgdGhl IHRpbWUKPiAtICogYmVpbmcgdGhleSB3aWxsIGJlIGltcGxpY2l0bHkgaW5pdGlhbGl6ZWQgdG8g dGhlIHN0cmljdGVzdCBjYWNoaW5nCj4gLSAqIGNvbmZpZ3VyYXRpb24gKHVuY2FjaGVkKSB0byBn dWFyYW50ZWUgZm9yd2FyZHMgY29tcGF0aWJpbGl0eSB3aXRoCj4gLSAqIHVzZXJzcGFjZSBwcm9n cmFtcyB3cml0dGVuIGFnYWluc3QgbW9yZSByZWNlbnQga2VybmVscyBwcm92aWRpbmcKPiAtICog YWRkaXRpb25hbCBNT0NTIGVudHJpZXMuCj4gKyAqIGJlaW5nIHRoZXkgd2lsbCBiZSBpbml0aWFs aXplZCB0byBQVEUuCj4gICAgKgo+ICAgICogTk9URTogVGhlc2UgdGFibGVzIE1VU1Qgc3RhcnQg d2l0aCBiZWluZyB1bmNhY2hlZCBhbmQgdGhlIGxlbmd0aAo+ICAgICogICAgICAgTVVTVCBiZSBs ZXNzIHRoYW4gNjMgYXMgdGhlIGxhc3QgdHdvIHJlZ2lzdGVycyBhcmUgcmVzZXJ2ZWQKPiBAQCAt MjQ5LDE2ICsyNDYsMTMgQEAgdm9pZCBpbnRlbF9tb2NzX2luaXRfZW5naW5lKHN0cnVjdCBpbnRl bF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIAkJCSAgIHRhYmxlLnRhYmxlW2luZGV4XS5jb250cm9s X3ZhbHVlKTsKPiAgIAo+ICAgCS8qCj4gLQkgKiBPaywgbm93IHNldCB0aGUgdW51c2VkIGVudHJp ZXMgdG8gdW5jYWNoZWQuIFRoZXNlIGVudHJpZXMKPiAtCSAqIGFyZSBvZmZpY2lhbGx5IHVuZGVm aW5lZCBhbmQgbm8gY29udHJhY3QgZm9yIHRoZSBjb250ZW50cwo+IC0JICogYW5kIHNldHRpbmdz IGlzIGdpdmVuIGZvciB0aGVzZSBlbnRyaWVzLgo+IC0JICoKPiAtCSAqIEVudHJ5IDAgaW4gdGhl IHRhYmxlIGlzIHVuY2FjaGVkIC0gc28gd2UgYXJlIGp1c3Qgd3JpdGluZwo+IC0JICogdGhhdCB2 YWx1ZSB0byBhbGwgdGhlIHVzZWQgZW50cmllcy4KPiArCSAqIE5vdyBzZXQgdGhlIHVudXNlZCBl bnRyaWVzIHRvIFBURS4gVGhlc2UgZW50cmllcyBhcmUgb2ZmaWNpYWxseQo+ICsJICogdW5kZWZp bmVkIGFuZCBubyBjb250cmFjdCBmb3IgdGhlIGNvbnRlbnRzIGFuZCBzZXR0aW5ncyBpcyBnaXZl bgo+ICsJICogZm9yIHRoZXNlIGVudHJpZXMuCj4gICAJICovCj4gICAJZm9yICg7IGluZGV4IDwg R0VOOV9OVU1fTU9DU19FTlRSSUVTOyBpbmRleCsrKQo+ICAgCQlJOTE1X1dSSVRFKG1vY3NfcmVn aXN0ZXIoZW5naW5lLT5pZCwgaW5kZXgpLAo+IC0JCQkgICB0YWJsZS50YWJsZVswXS5jb250cm9s X3ZhbHVlKTsKPiArCQkJICAgdGFibGUudGFibGVbSTkxNV9NT0NTX1BURV0uY29udHJvbF92YWx1 ZSk7Cj4gICB9Cj4gICAKPiAgIC8qKgo+IEBAIC0yOTMsMTYgKzI4NywxMyBAQCBzdGF0aWMgaW50 IGVtaXRfbW9jc19jb250cm9sX3RhYmxlKHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxLAo+ICAgCX0K PiAgIAo+ICAgCS8qCj4gLQkgKiBPaywgbm93IHNldCB0aGUgdW51c2VkIGVudHJpZXMgdG8gdW5j YWNoZWQuIFRoZXNlIGVudHJpZXMKPiAtCSAqIGFyZSBvZmZpY2lhbGx5IHVuZGVmaW5lZCBhbmQg bm8gY29udHJhY3QgZm9yIHRoZSBjb250ZW50cwo+IC0JICogYW5kIHNldHRpbmdzIGlzIGdpdmVu IGZvciB0aGVzZSBlbnRyaWVzLgo+IC0JICoKPiAtCSAqIEVudHJ5IDAgaW4gdGhlIHRhYmxlIGlz IHVuY2FjaGVkIC0gc28gd2UgYXJlIGp1c3Qgd3JpdGluZwo+IC0JICogdGhhdCB2YWx1ZSB0byBh bGwgdGhlIHVzZWQgZW50cmllcy4KPiArCSAqIE5vdyBzZXQgdGhlIHVudXNlZCBlbnRyaWVzIHRv IFBURS4gVGhlc2UgZW50cmllcyBhcmUgb2ZmaWNpYWxseQo+ICsJICogdW5kZWZpbmVkIGFuZCBu byBjb250cmFjdCBmb3IgdGhlIGNvbnRlbnRzIGFuZCBzZXR0aW5ncyBpcyBnaXZlbgo+ICsJICog Zm9yIHRoZXNlIGVudHJpZXMuCj4gICAJICovCj4gICAJZm9yICg7IGluZGV4IDwgR0VOOV9OVU1f TU9DU19FTlRSSUVTOyBpbmRleCsrKSB7Cj4gICAJCSpjcysrID0gaTkxNV9tbWlvX3JlZ19vZmZz ZXQobW9jc19yZWdpc3RlcihlbmdpbmUsIGluZGV4KSk7Cj4gLQkJKmNzKysgPSB0YWJsZS0+dGFi bGVbMF0uY29udHJvbF92YWx1ZTsKPiArCQkqY3MrKyA9IHRhYmxlLT50YWJsZVtJOTE1X01PQ1Nf UFRFXS5jb250cm9sX3ZhbHVlOwpFbnRyaWVzIGZyb20gZW51bSBpOTE1X21vY3NfdGFibGVfaW5k ZXggYXJlIG5vdCBndWFyYW50ZWVkIHRvIG1lYW4gdGhlIApzYW1lIHRoaW5nIGluIGZ1dHVyZSBn ZW5zOwpidXQgZm9yIHRoZSB0aW1lLCB0aGF0IHdpbGwgd29yay4gQW5kIGxhdGVyIGl0IG1pZ2h0 IHN0aWxsIHdvcmssIHdlIApkb24ndCBrbm93LgotVG9tYXN6Cj4gICAJfQo+ICAgCj4gICAJKmNz KysgPSBNSV9OT09QOwo+IEBAIC0zNDUsNyArMzM2LDcgQEAgc3RhdGljIGludCBlbWl0X21vY3Nf bDNjY190YWJsZShzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSwKPiAgIAo+ICAgCSpjcysrID0gTUlf TE9BRF9SRUdJU1RFUl9JTU0oR0VOOV9OVU1fTU9DU19FTlRSSUVTIC8gMik7Cj4gICAKPiAtCWZv ciAoaSA9IDA7IGkgPCB0YWJsZS0+c2l6ZS8yOyBpKyspIHsKPiArCWZvciAoaSA9IDA7IGkgPCB0 YWJsZS0+c2l6ZSAvIDI7IGkrKykgewo+ICAgCQkqY3MrKyA9IGk5MTVfbW1pb19yZWdfb2Zmc2V0 KEdFTjlfTE5DRkNNT0NTKGkpKTsKPiAgIAkJKmNzKysgPSBsM2NjX2NvbWJpbmUodGFibGUsIDIg KiBpLCAyICogaSArIDEpOwo+ICAgCX0KPiBAQCAtMzUzLDE4ICszNDQsMTggQEAgc3RhdGljIGlu dCBlbWl0X21vY3NfbDNjY190YWJsZShzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSwKPiAgIAlpZiAo dGFibGUtPnNpemUgJiAweDAxKSB7Cj4gICAJCS8qIE9kZCB0YWJsZSBzaXplIC0gMSBsZWZ0IG92 ZXIgKi8KPiAgIAkJKmNzKysgPSBpOTE1X21taW9fcmVnX29mZnNldChHRU45X0xOQ0ZDTU9DUyhp KSk7Cj4gLQkJKmNzKysgPSBsM2NjX2NvbWJpbmUodGFibGUsIDIgKiBpLCAwKTsKPiArCQkqY3Mr KyA9IGwzY2NfY29tYmluZSh0YWJsZSwgMiAqIGksIEk5MTVfTU9DU19QVEUpOwo+ICAgCQlpKys7 Cj4gICAJfQo+ICAgCj4gICAJLyoKPiAtCSAqIE5vdyBzZXQgdGhlIHJlc3Qgb2YgdGhlIHRhYmxl IHRvIHVuY2FjaGVkIC0gdXNlIGVudHJ5IDAgYXMKPiAtCSAqIHRoaXMgd2lsbCBiZSB1bmNhY2hl ZC4gTGVhdmUgdGhlIGxhc3QgcGFpciB1bmluaXRpYWxpc2VkIGFzCj4gLQkgKiB0aGV5IGFyZSBy ZXNlcnZlZCBieSB0aGUgaGFyZHdhcmUuCj4gKwkgKiBOb3cgc2V0IHRoZSB1bnVzZWQgZW50cmll cyB0byBQVEUuIFRoZXNlIGVudHJpZXMgYXJlIG9mZmljaWFsbHkKPiArCSAqIHVuZGVmaW5lZCBh bmQgbm8gY29udHJhY3QgZm9yIHRoZSBjb250ZW50cyBhbmQgc2V0dGluZ3MgaXMgZ2l2ZW4KPiAr CSAqIGZvciB0aGVzZSBlbnRyaWVzLgo+ICAgCSAqLwo+ICAgCWZvciAoOyBpIDwgR0VOOV9OVU1f TU9DU19FTlRSSUVTIC8gMjsgaSsrKSB7Cj4gICAJCSpjcysrID0gaTkxNV9tbWlvX3JlZ19vZmZz ZXQoR0VOOV9MTkNGQ01PQ1MoaSkpOwo+IC0JCSpjcysrID0gbDNjY19jb21iaW5lKHRhYmxlLCAw LCAwKTsKPiArCQkqY3MrKyA9IGwzY2NfY29tYmluZSh0YWJsZSwgSTkxNV9NT0NTX1BURSwgSTkx NV9NT0NTX1BURSk7Cj4gICAJfQo+ICAgCj4gICAJKmNzKysgPSBNSV9OT09QOwo+IEBAIC0zOTUs MjIgKzM4NiwyMSBAQCB2b2lkIGludGVsX21vY3NfaW5pdF9sM2NjX3RhYmxlKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgIAlpZiAoIWdldF9tb2NzX3NldHRpbmdzKGRldl9w cml2LCAmdGFibGUpKQo+ICAgCQlyZXR1cm47Cj4gICAKPiAtCWZvciAoaSA9IDA7IGkgPCB0YWJs ZS5zaXplLzI7IGkrKykKPiAtCQlJOTE1X1dSSVRFKEdFTjlfTE5DRkNNT0NTKGkpLCBsM2NjX2Nv bWJpbmUoJnRhYmxlLCAyKmksIDIqaSsxKSk7Cj4gKwlmb3IgKGkgPSAwOyBpIDwgdGFibGUuc2l6 ZSAvIDI7IGkrKykKPiArCQlJOTE1X1dSSVRFKEdFTjlfTE5DRkNNT0NTKGkpLAo+ICsJCQkgICBs M2NjX2NvbWJpbmUoJnRhYmxlLCAyICogaSwgMiAqIGkgKyAxKSk7Cj4gICAKPiAgIAkvKiBPZGQg dGFibGUgc2l6ZSAtIDEgbGVmdCBvdmVyICovCj4gICAJaWYgKHRhYmxlLnNpemUgJiAweDAxKSB7 Cj4gLQkJSTkxNV9XUklURShHRU45X0xOQ0ZDTU9DUyhpKSwgbDNjY19jb21iaW5lKCZ0YWJsZSwg MippLCAwKSk7Cj4gKwkJSTkxNV9XUklURShHRU45X0xOQ0ZDTU9DUyhpKSwKPiArCQkJICAgbDNj Y19jb21iaW5lKCZ0YWJsZSwgMiAqIGksIEk5MTVfTU9DU19QVEUpKTsKPiAgIAkJaSsrOwo+ICAg CX0KPiAgIAo+IC0JLyoKPiAtCSAqIE5vdyBzZXQgdGhlIHJlc3Qgb2YgdGhlIHRhYmxlIHRvIHVu Y2FjaGVkIC0gdXNlIGVudHJ5IDAgYXMKPiAtCSAqIHRoaXMgd2lsbCBiZSB1bmNhY2hlZC4gTGVh dmUgdGhlIGxhc3QgcGFpciBhcyBpbml0aWFsaXNlZCBhcwo+IC0JICogdGhleSBhcmUgcmVzZXJ2 ZWQgYnkgdGhlIGhhcmR3YXJlLgo+IC0JICovCj4gKwkvKiBOb3cgc2V0IHRoZSByZXN0IG9mIHRo ZSB0YWJsZSB0byBQVEUgKi8KPiAgIAlmb3IgKDsgaSA8IChHRU45X05VTV9NT0NTX0VOVFJJRVMg LyAyKTsgaSsrKQo+IC0JCUk5MTVfV1JJVEUoR0VOOV9MTkNGQ01PQ1MoaSksIGwzY2NfY29tYmlu ZSgmdGFibGUsIDAsIDApKTsKPiArCQlJOTE1X1dSSVRFKEdFTjlfTE5DRkNNT0NTKGkpLAo+ICsJ CQkgICBsM2NjX2NvbWJpbmUoJnRhYmxlLCBJOTE1X01PQ1NfUFRFLCBJOTE1X01PQ1NfUFRFKSk7 Cj4gICB9Cj4gICAKPiAgIC8qKgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==