From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B989C2B9F8 for ; Tue, 25 May 2021 17:01:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD0B461417 for ; Tue, 25 May 2021 17:01:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD0B461417 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llaQr-0005O6-OY for qemu-devel@archiver.kernel.org; Tue, 25 May 2021 13:01:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llYkT-0001r7-9O for qemu-devel@nongnu.org; Tue, 25 May 2021 11:13:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:20569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llYkP-0002AA-5H for qemu-devel@nongnu.org; Tue, 25 May 2021 11:13:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621955611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eNn55coEb6VAPVOYyQdclqjHc9+4ap79rrptN/r19aQ=; b=NjDxmRKLw6bCK3wnbyiLDO+JikcNBPAu3NmtqvmRVHck/dtmVxyoRVSEKyrXzOcw9O37u/ QNiSY8xc3Sk+KnRvVzjCWdC547iFxe0T5PTsO2/ts4fbw8UviyBUMCobLqTZHWwSeR971I 8PnBYhynGh6P5Xgnfmqm0Ho7Gs9QiWQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-190-7VO0BPcLO0qO2JsDRc-UQA-1; Tue, 25 May 2021 11:13:28 -0400 X-MC-Unique: 7VO0BPcLO0qO2JsDRc-UQA-1 Received: by mail-wm1-f71.google.com with SMTP id v2-20020a7bcb420000b0290146b609814dso4768030wmj.0 for ; Tue, 25 May 2021 08:13:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eNn55coEb6VAPVOYyQdclqjHc9+4ap79rrptN/r19aQ=; b=aOllvlkZPFBp10svy2nrpt01ojvx68szHyGuoOvG3L5vT1Q0C3ugZZpyMeQbLlZKBu /iJ3Ht3PpoaDX+dBBs5BCA11V+XEC+8rVBlBoOda07IdsJEbV8+BJb4c1xxth0UpREj2 xhoWoyia5A1qlTQP7AJLGWs+Rnh9wN/E02ABuqYWP6HhS+dNkNaNV2PdgFIWPsSLFbmn kSWI8uY5BYh6SrDTfIBLzJWYn0cSELRndeZ5Ys0ZAtD5JEqaO+/rC33AwJkl1GlDLxEl aoDcJDhVIDC90VLsgX0B5PLLgm5liSN9cP0ZuFKrzDhrjir44BoGW57GdFtxX56CcXQZ c2eQ== X-Gm-Message-State: AOAM531Bvhoy6fv37fU7sNbz/7SayrVqHAXFYv9joytEBFuGthgHbAyj lF45Cqnh5IWwaNUtiQNgHcWyU/V7MdCSMbxZsZdMClRxBe2l5UogAUTBrTC5fMApi5JYXeHjEwh eG4ZkiP+MUQnNP970AevV0i7eBKtXJbc/F7jejq9nAu4Pz9MLjLqST3CF4JwG8IuQ X-Received: by 2002:a05:600c:2909:: with SMTP id i9mr24763913wmd.116.1621955606926; Tue, 25 May 2021 08:13:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6rZRjwhsqYXCBrRDULAWOETpUh/JFgKQsSzgC2ToNEU1TZXTnRkaN/bQRSXuW2yu/wiGJpg== X-Received: by 2002:a05:600c:2909:: with SMTP id i9mr24763887wmd.116.1621955606629; Tue, 25 May 2021 08:13:26 -0700 (PDT) Received: from [192.168.1.36] (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id c6sm16803073wru.50.2021.05.25.08.13.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 May 2021 08:13:26 -0700 (PDT) Subject: Re: [PATCH] configure: Check whether we can compile the s390-ccw bios with -msoft-float To: Thomas Huth , Cornelia Huck References: <20210525142032.156989-1-thuth@redhat.com> <20210525163121.6901dca2.cohuck@redhat.com> <3a4f413f-7ce5-0d78-180c-e08b351b30df@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <724c58f8-d879-6bee-dc87-356d054be8d6@redhat.com> Date: Tue, 25 May 2021 17:13:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <3a4f413f-7ce5-0d78-180c-e08b351b30df@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.371, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Borntraeger , qemu-s390x@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/25/21 4:40 PM, Thomas Huth wrote: > On 25/05/2021 16.31, Cornelia Huck wrote: >> On Tue, 25 May 2021 16:20:32 +0200 >> Thomas Huth wrote: >> >>> The -msoft-float switch is not available in older versions of Clang. >>> Since we rely on the compiler to not generate floating point >>> instructions >>> unexpectedly, we block those old compilers now via a test in the >>> configure >>> script. Note that for some weird reasons, the Clang compiler only >>> complains >>> about the missing soft-float support if no other flags are passed via >>> "-Wl,..." to the linker. So we have to use "compile_object" instead of >>> "compile_prog" for this check. >> >> Ugh. > > It's maybe better to use compile_object for testing -msoft-float anyway > since it could influence the way of linking against libraries (if I get > https://reviews.llvm.org/D72189 right). > >>> >>> Signed-off-by: Thomas Huth >>> --- >>>   configure | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/configure b/configure >>> index 676239c697..673419ff31 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -5462,7 +5462,7 @@ if test "$cpu" = "s390x" ; then >>>     write_c_skeleton >>>     compile_prog "-march=z900" "" >>>     has_z900=$? >>> -  if [ $has_z900 = 0 ] || compile_prog "-march=z10" ""; then >>> +  if [ $has_z900 = 0 ] || compile_object "-march=z10 -msoft-float >>> -Werror"; then >> >> Do you believe that we should have caught the various clang >> specialties now? > > Apart from one compiler warning that just popped up today, yes. I'm > seeing this compiler warning with Clang 12.0 now: > > roms/SLOF/lib/libnet/ipv6.c:447:18: warning: variable length array > folded to constant array as an extension [-Wgnu-folding-constant] >                 unsigned short raw[ip6size]; >                                ^ > > ... not sure what to do with that one yet. Fix it? =) Same class as: https://gitlab.freedesktop.org/slirp/libslirp/-/commit/6690d55626cc -- >8 -- diff --git a/lib/libnet/ipv6.c b/lib/libnet/ipv6.c index 6420004..b7daeda 100644 --- a/lib/libnet/ipv6.c +++ b/lib/libnet/ipv6.c @@ -441,10 +441,9 @@ static unsigned short ip6_checksum(struct ip6hdr *ip6h, unsigned char *packet, { int i; unsigned long checksum; - const int ip6size = sizeof(struct ip6hdr)/sizeof(unsigned short); union { struct ip6hdr ip6h; - unsigned short raw[ip6size]; + unsigned short raw[sizeof(struct ip6hdr) / sizeof(unsigned short)]; } pseudo; memcpy (&pseudo.ip6h, ip6h, sizeof(struct ip6hdr)); @@ -455,7 +454,7 @@ static unsigned short ip6_checksum(struct ip6hdr *ip6h, unsigned char *packet, for (checksum = 0, i = 0; i < bytes; i += 2) checksum += (packet[i] << 8) | packet[i + 1]; - for (i = 0; i < ip6size; i++) + for (i = 0; i < sizeof(pseudo.raw); i++) checksum += pseudo.raw[i]; checksum = (checksum >> 16) + (checksum & 0xffff); --- Do you want me to send the fix since I have it ready?