All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé via" <qemu-devel@nongnu.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
	Stafford Horne <shorne@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/openrisc: pass random seed to fdt
Date: Mon, 13 Jun 2022 15:52:51 +0200	[thread overview]
Message-ID: <725cd66b-13f9-aa3a-021e-2d8f3baeb081@amsat.org> (raw)
In-Reply-To: <CAHmME9o_Oq7TKFXx-rxRxpVR-akE+gVCutK879Tp_ubVwEu=TA@mail.gmail.com>

On 13/6/22 12:58, Jason A. Donenfeld wrote:
> On 6/13/22, Stafford Horne <shorne@gmail.com> wrote:
>> On Sun, Jun 12, 2022 at 11:59:49PM +0200, Jason A. Donenfeld wrote:
>>> If the FDT contains /chosen/rng-seed, then the Linux RNG will use it to
>>> initialize early. Set this using the usual guest random number
>>> generation function. This is confirmed to successfully initialize the
>>> RNG on Linux 5.19-rc2.
>>>
>>> Cc: Stafford Horne <shorne@gmail.com>
>>> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
>>> ---
>>>   hw/openrisc/openrisc_sim.c | 6 ++++++
>>>   1 file changed, 6 insertions(+)

>> This all looks fine to me.  I will queue it with my current changes.  Since
>> this
>> is only applying to openrisc_sim I would like to also apply it to virt.  To
>> do
>> that I need to have a common core openrisc system creation api.  That way I
>> don't end up copying and pasting this to every platform.

Looking at commit cb57df6f7f ("hw/arm/raspi: Make machines children of
abstract RaspiMachineClass") and around could help.

> 
> Sure. Or just do it on the virt board only if that's easier.
> 
> Jason
> 



  reply	other threads:[~2022-06-13 14:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-12 21:59 [PATCH] hw/openrisc: pass random seed to fdt Jason A. Donenfeld
2022-06-13  1:23 ` Stafford Horne
2022-06-13 10:58   ` Jason A. Donenfeld
2022-06-13 13:52     ` Philippe Mathieu-Daudé via [this message]
2022-06-22 11:45     ` [PATCH v2] hw/openrisc: virt: " Jason A. Donenfeld
2022-06-23 20:53       ` Stafford Horne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=725cd66b-13f9-aa3a-021e-2d8f3baeb081@amsat.org \
    --to=qemu-devel@nongnu.org \
    --cc=Jason@zx2c4.com \
    --cc=f4bug@amsat.org \
    --cc=shorne@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.