All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [PATCH v3 0/4] iotests/297: Cover tests/
Date: Wed, 1 Sep 2021 16:34:11 +0300	[thread overview]
Message-ID: <7260b639-c50b-c758-0e60-2e36acae35b0@virtuozzo.com> (raw)
In-Reply-To: <20210514154351.629027-1-mreitz@redhat.com>

A kind of ping:)

Seems that never landed into master?

14.05.2021 18:43, Max Reitz wrote:
> v1: https://lists.nongnu.org/archive/html/qemu-block/2021-03/msg01471.html
> v2: https://lists.nongnu.org/archive/html/qemu-block/2021-05/msg00492.html
> 
> 
> Hi,
> 
> When reviewing Vladimir’s new addition to tests/, I noticed that 297 so
> far does not cover named tests.  That isn’t so good.
> 
> This series makes it cover them, and because tests/ is rather sparse at
> this point, I decided to also fix up the two tests in there that don’t
> pass pylint’s scrutiny yet.  I think it would be nice if we could keep
> all of tests/ clean.
> 
> 
> v3:
> - Fixed patch 3: Turns out replacing `lambda self: mc(self)` by just
>    `mc` (as pylint suggests) breaks the test.  So leave it as it is and
>    instead disable the warning locally.
> 
> 
> git-backport-diff against v3:
> 
> Key:
> [----] : patches are identical
> [####] : number of functional differences between upstream/downstream patch
> [down] : patch is downstream-only
> The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
> 
> 001/4:[----] [--] 'iotests/297: Drop 169 and 199 from the skip list'
> 002/4:[----] [--] 'migrate-bitmaps-postcopy-test: Fix pylint warnings'
> 003/4:[0005] [FC] 'migrate-bitmaps-test: Fix pylint warnings'
> 004/4:[----] [--] 'iotests/297: Cover tests/'
> 
> 
> Max Reitz (4):
>    iotests/297: Drop 169 and 199 from the skip list
>    migrate-bitmaps-postcopy-test: Fix pylint warnings
>    migrate-bitmaps-test: Fix pylint warnings
>    iotests/297: Cover tests/
> 
>   tests/qemu-iotests/297                        |  7 ++--
>   .../tests/migrate-bitmaps-postcopy-test       | 13 +++---
>   tests/qemu-iotests/tests/migrate-bitmaps-test | 41 +++++++++++--------
>   3 files changed, 34 insertions(+), 27 deletions(-)
> 


-- 
Best regards,
Vladimir


  parent reply	other threads:[~2021-09-01 13:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 15:43 [PATCH v3 0/4] iotests/297: Cover tests/ Max Reitz
2021-05-14 15:43 ` [PATCH v3 1/4] iotests/297: Drop 169 and 199 from the skip list Max Reitz
2021-05-14 15:43 ` [PATCH v3 2/4] migrate-bitmaps-postcopy-test: Fix pylint warnings Max Reitz
2021-05-14 15:43 ` [PATCH v3 3/4] migrate-bitmaps-test: " Max Reitz
2021-05-14 16:40   ` Vladimir Sementsov-Ogievskiy
2021-05-14 15:43 ` [PATCH v3 4/4] iotests/297: Cover tests/ Max Reitz
2021-09-01 13:34 ` Vladimir Sementsov-Ogievskiy [this message]
2021-09-01 14:33   ` [PATCH v3 0/4] " Hanna Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7260b639-c50b-c758-0e60-2e36acae35b0@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.