From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E9E1C433F5 for ; Fri, 29 Oct 2021 18:29:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7567B61040 for ; Fri, 29 Oct 2021 18:29:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229755AbhJ2Sbi (ORCPT ); Fri, 29 Oct 2021 14:31:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbhJ2Sbi (ORCPT ); Fri, 29 Oct 2021 14:31:38 -0400 Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76144C061570 for ; Fri, 29 Oct 2021 11:29:09 -0700 (PDT) Received: by mail-il1-x135.google.com with SMTP id w10so11522518ilc.13 for ; Fri, 29 Oct 2021 11:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=M4ckGJprhLexXQYX/J15yBHT1XAwH31Id/xvub/SSnU=; b=RI87y7K5cbw1htGMZwRAEKZ7kGxrV7AUwwTsD5V+DaXLgeD1orsazd5fFYruCb6tHm KrjE0yvX1q3/HWsKGCM2r7XPrkZwOn3OC+SmAkvncEdc7hRXnWfoaLYgWNrO8Ty5Tv2q x2lyWf0bmqwz7GVmAr17M2LneAOP+Oolny9ZqlrVZepdRun826IU/uXEJve1mTUa25+k b0qvsy/uS+aVeyIcSM2BzAIHCv9vOlwg57FYlRZNFkbBM4Zb8rZKsvPLKwSnLmh7y0N0 2fw2hHPmcO0KAGCHkVPYM58KdIl3Bl0Nfx653MYo1jb/0NghprQ0aQsF41gdGA/B1VXx 7Q9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=M4ckGJprhLexXQYX/J15yBHT1XAwH31Id/xvub/SSnU=; b=FGOnmdPtutNZvUSngXgukqdNYxJ3KPvAlaVv5ZJEut6ev1DWPFuecRSi2dXtpv8VKq d4o41GwHJ1jjNsHI1suWDgDxFB2uuV1AsYuecfHsePCc6NGBJ8dFggpG8rx3nIN2A56K p+GW7igfWqnd3gr2Fi/gfJs31W6bUnPdqpFwMxFzt/wLbDTc7gOQuscJfb882Gc2c/5Y fPMkpEEDzJrsNdrmQ5NOMdlCCeklQdNOALcYmkGG5mpRElvqCwP0V5osORLu4TbNfp44 rToRCqq7E0sptY53kkiReMalZSJplfX0qaEX/x9vNZ7MCsKUdBagaIMMbpzTNoLK+FAb SK2w== X-Gm-Message-State: AOAM532LmP03JxBJghgVj+zfqMLdeVhzAedZfkKJzy2vS8BwUVjl9rlO ObmAXP4rxXDYXz3kSbvbyGWiTEcEjUTjMA== X-Google-Smtp-Source: ABdhPJy70ev5832wGK0/8Z+2oNbAjKTLq3dMheL+RSpgRdKt0SkrxjHPYw5fZILf8tFcnIIP27j7Tw== X-Received: by 2002:a92:c56b:: with SMTP id b11mr8834737ilj.130.1635532148773; Fri, 29 Oct 2021 11:29:08 -0700 (PDT) Received: from [192.168.1.30] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id z16sm3340924iow.42.2021.10.29.11.29.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Oct 2021 11:29:08 -0700 (PDT) Subject: Re: [PATCH v3 0/3] improvements for multi-shot poll requests From: Jens Axboe To: Xiaoguang Wang , io-uring@vger.kernel.org Cc: asml.silence@gmail.com References: <20211025053849.3139-1-xiaoguang.wang@linux.alibaba.com> <924b097b-144a-d4ff-0b46-0dded1daa824@kernel.dk> Message-ID: <726ea5cc-1b0c-8c0f-64e7-addc82a50a46@kernel.dk> Date: Fri, 29 Oct 2021 12:29:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <924b097b-144a-d4ff-0b46-0dded1daa824@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 10/28/21 12:19 PM, Jens Axboe wrote: > On 10/24/21 11:38 PM, Xiaoguang Wang wrote: >> Echo_server codes can be clone from: >> https://codeup.openanolis.cn/codeup/storage/io_uring-echo-server.git >> branch is xiaoguangwang/io_uring_multishot. There is a simple HOWTO >> in this repository. >> >> Usage: >> In server: port 10016, 1000 connections, packet size 16 bytes, and >> enable fixed files. >> taskset -c 10 io_uring_echo_server_multi_shot -f -p 10016 -n 1000 -l 16 >> >> In client: >> taskset -c 13,14,15,16 ./echo -addr 11.238.147.21:10016 -n 1000 -size 16 >> >> Before this patchset, the tps is like below: >> 1:15:53 req: 1430425, req/s: 286084.693 >> 11:15:58 req: 1426021, req/s: 285204.079 >> 11:16:03 req: 1416761, req/s: 283352.146 >> 11:16:08 req: 1417969, req/s: 283165.637 >> 11:16:13 req: 1424591, req/s: 285349.915 >> 11:16:18 req: 1418706, req/s: 283738.725 >> 11:16:23 req: 1411988, req/s: 282399.052 >> 11:16:28 req: 1419097, req/s: 283820.477 >> 11:16:33 req: 1417816, req/s: 283563.262 >> 11:16:38 req: 1422461, req/s: 284491.702 >> 11:16:43 req: 1418176, req/s: 283635.327 >> 11:16:48 req: 1414525, req/s: 282905.276 >> 11:16:53 req: 1415624, req/s: 283124.140 >> 11:16:58 req: 1426435, req/s: 284970.486 >> >> with this patchset: >> 2021/09/24 11:10:01 start to do client >> 11:10:06 req: 1444979, req/s: 288995.300 >> 11:10:11 req: 1442559, req/s: 288511.689 >> 11:10:16 req: 1427253, req/s: 285450.390 >> 11:10:21 req: 1445236, req/s: 288349.853 >> 11:10:26 req: 1423949, req/s: 285480.941 >> 11:10:31 req: 1445304, req/s: 289060.815 >> 11:10:36 req: 1441036, req/s: 288207.119 >> 11:10:41 req: 1441117, req/s: 288220.695 >> 11:10:46 req: 1441451, req/s: 288292.731 >> 11:10:51 req: 1438801, req/s: 287759.157 >> 11:10:56 req: 1433227, req/s: 286646.338 >> 11:11:01 req: 1438307, req/s: 287661.577> >> about 1.3% tps improvements. > > In the spirit of moving this one along, I've applied this series. Still a few > things we can do on top, but I don't think that should hold it back. If you > planned on sending an update to inline that check again just do it on top > of the current tree. Due to the discussion about it, and the potential syzbot issue reported, I've dropped this one from the 5.16 merge window. -- Jens Axboe