From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0D34C433ED for ; Wed, 7 Apr 2021 16:43:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACE8B6108B for ; Wed, 7 Apr 2021 16:43:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354345AbhDGQoF (ORCPT ); Wed, 7 Apr 2021 12:44:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354344AbhDGQoF (ORCPT ); Wed, 7 Apr 2021 12:44:05 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D52BCC06175F for ; Wed, 7 Apr 2021 09:43:55 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id il9-20020a17090b1649b0290114bcb0d6c2so1629585pjb.0 for ; Wed, 07 Apr 2021 09:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZXSquVdNTnJV6sENmFIy57LLxGa3DHW5OaRJtKQMEqE=; b=Q/eVLwdZeqMpOn6mWC3xedWa5aaBshfCet80piSYa7fI6XhvFrxJ0ZUNpLjWQfgIR+ w22cV/konELrLQngdB+LF3HzOzvME7sLzyvGe5kMLixaUxLpl1Mln+nLuZRvVAOGARR1 KSoROc1baZ6kEnBycVa89hg7LnhH0xttJco81BAw8FNe+iCqwkCG/6d7qITsmfIlUo1d cdOgpM0FNjIqixa5QdRDmJUo/yBh6wcZBQL6UfnLqZHERHgZqZXVmLHm7gJ13G+CgPse eJRvvLzDsG4/wZWBnpQmWbzg9CGw3CNCFhQb2wbdrgwJnDf2nOZLy4rfYWWe4VMKfh5v T42A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZXSquVdNTnJV6sENmFIy57LLxGa3DHW5OaRJtKQMEqE=; b=Vqb33FbmV72z7GlNDpIx5Xr92G/qGb34IcC2PhycL6UyLG75VZa3M88cmwifil2Uc/ KHA8X+Z7fI9ey0s6yOagxbIzIzsg+5p11mihi1c8laKuUF4sBJ3+KoGVLIewjxbh2AFe ijKabhRir/N7mi9doAYjV68aDn/F6ui9c9rNZFWKOV3DIHDoYD/Jj0+dAAEtC3qhwMx+ E88/1R8ajYy59mS7Onf4iiSP7DishtOGPVpjABjf6EKbZloRLaeNe4wEA7vym3rpnXxH yrknT/xv8VarpkwbNsL4IMQ7EX7YY3Mg16Hi6+B7iz6ZqltnZXhAMGwWu6VgfnfcvKfb tEbg== X-Gm-Message-State: AOAM533q6drBXFdBrnj07t1BidOigB1fNTTCkKVPW+BzABYshb4FY8uB EGXr2+g7e660/cLJw75A5Sdm2Q== X-Google-Smtp-Source: ABdhPJw8Y8AnmgaJ1lgzk3/bpLg0ktvFBPC4tvE7MOQ13QiF3fO59oX5L95aNliexL6KjcvynBuNnw== X-Received: by 2002:a17:902:8d85:b029:e7:1029:9114 with SMTP id v5-20020a1709028d85b02900e710299114mr3853158plo.42.1617813835289; Wed, 07 Apr 2021 09:43:55 -0700 (PDT) Received: from [192.168.4.41] (cpe-72-132-29-68.dc.res.rr.com. [72.132.29.68]) by smtp.gmail.com with ESMTPSA id m1sm6045239pjf.8.2021.04.07.09.43.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Apr 2021 09:43:54 -0700 (PDT) Subject: Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header To: Andy Shevchenko Cc: kernel test robot , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, kbuild-all@lists.01.org References: <20210407134706.81383-1-andriy.shevchenko@linux.intel.com> <202104072325.Zv0JLqbH-lkp@intel.com> <5111151e-35a5-0422-8414-7b900f01d316@kernel.dk> From: Jens Axboe Message-ID: <728ec7f8-310e-e478-bd53-8784392aee25@kernel.dk> Date: Wed, 7 Apr 2021 10:43:53 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 4/7/21 10:27 AM, Andy Shevchenko wrote: > On Wed, Apr 07, 2021 at 10:04:49AM -0600, Jens Axboe wrote: >> On 4/7/21 10:03 AM, Andy Shevchenko wrote: >>> On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: > > ... > >>>> All errors (new ones prefixed by >>): >>> >>> Thanks, we need to include bits.h. >>> (It passed my simple build, but appears I have no such driver included) >>> >>> Jens, I saw your message, should I send a follow up fix, or a v2? >> >> Let's just drop it, not worth it for the risk imho. > > Does it mean I may try again in next cycle? > > Because kernel.h inclusion seems to me too wrong there. I don't mind taking it, but not on a hunch. If you send something that has been thought about and went through full compilation, then you can resend it. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5679887131986799010==" MIME-Version: 1.0 From: Jens Axboe To: kbuild-all@lists.01.org Subject: Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header Date: Wed, 07 Apr 2021 10:43:53 -0600 Message-ID: <728ec7f8-310e-e478-bd53-8784392aee25@kernel.dk> In-Reply-To: List-Id: --===============5679887131986799010== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 4/7/21 10:27 AM, Andy Shevchenko wrote: > On Wed, Apr 07, 2021 at 10:04:49AM -0600, Jens Axboe wrote: >> On 4/7/21 10:03 AM, Andy Shevchenko wrote: >>> On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: > = > ... > = >>>> All errors (new ones prefixed by >>): >>> >>> Thanks, we need to include bits.h. >>> (It passed my simple build, but appears I have no such driver included) >>> >>> Jens, I saw your message, should I send a follow up fix, or a v2? >> >> Let's just drop it, not worth it for the risk imho. > = > Does it mean I may try again in next cycle? > = > Because kernel.h inclusion seems to me too wrong there. I don't mind taking it, but not on a hunch. If you send something that has been thought about and went through full compilation, then you can resend it. -- = Jens Axboe --===============5679887131986799010==--