From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90082C433EF for ; Thu, 4 Nov 2021 19:12:56 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1595C61216 for ; Thu, 4 Nov 2021 19:12:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1595C61216 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DF93D83661; Thu, 4 Nov 2021 20:12:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1636053173; bh=/ebQJxlJlMCliYIpEnGSl4XkoGUIvTz7ZDhNdXLHfBU=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cauwEwKJHH0h5Q86qCU1PsnTpCxQqLw7DDgjjtN08zAGkUjMucmB+RaxiROYpQAaK w4kI5D9M5P8BNRRXhBGOPpegyQlkGgs0GFBmYCvx58hWmZrVGdOqg9p59u7E4bzjV3 X6KmNKpuW3FONK5T6jzHGk0XaGw8e9IKwxBHo7rsWymLsYifwamKv4Qj4MFcT+0BK/ y7rGiy0gmJrYSa2kyX5pS3pKb1yAiGEh4y938fec3Hri358mxdTVBFP1m9ScYIyXIi DEbterUFtoJUQsgxMa0KLTbbh2EhfCBGoRgehLw2NfSqXwmEsoXojFpp1yIzgYV6mP 5bBCN3Ag/EqVA== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id C2E278365C for ; Thu, 4 Nov 2021 20:12:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1636053170; bh=/ebQJxlJlMCliYIpEnGSl4XkoGUIvTz7ZDhNdXLHfBU=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=ykUNn2NDbEk976ue047VWB/ctB2/bwUx0b8zwb3oVF+c/3riiOu8BSA96hxpocFXY gCpkxMV7ASU5K1Byy9m0grlb44yeF1xYoX2Amlhh1vKTmBY6Gm9P18446SeAv1Gufd aEmiXIpdwbYmWgEsugcjB4b61kQ7UGakiswQdBBcGkZmkx2QrmL48bvZzIXyBkyPOQ 7J9KrqosnPOmI805qQxVl5obg7dRJ8sukEsvhuTZGdIG/rzdj6h1lFnvg77LKaLMLU 0x10Wo+27KsdOYDywZiOjAcAzVc3EOzqOgn3mFL+EZTaeGWRHXWcJNOlQE2Jd8dURs uNMA3qNaNOdkw== Received: by janitor.denx.de (Postfix, from userid 108) id 7B106A01D1; Thu, 4 Nov 2021 20:12:50 +0100 (CET) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 902F9A00AA; Thu, 4 Nov 2021 20:12:41 +0100 (CET) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 417311E0CB7; Thu, 4 Nov 2021 20:12:41 +0100 (CET) To: Heiko Thiery cc: u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , Michael Walle , Simon Glass From: Wolfgang Denk Subject: Re: [RFC 0/2] Do not stop with an error when mkimage fails MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20211104185231.2927-1-heiko.thiery@gmail.com> References: <20211104185231.2927-1-heiko.thiery@gmail.com> Comments: In-reply-to Heiko Thiery message dated "Thu, 04 Nov 2021 19:52:30 +0100." Date: Thu, 04 Nov 2021 20:12:41 +0100 Message-ID: <729199.1636053161@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Heiko, In message <20211104185231.2927-1-heiko.thiery@gmail.com> you wrote: > While converting to binman for an imx8mq board, it has been found that > building in the u-boot CI fails. This is because an imx8mq requires an > external binary (signed_hdmi_imx8m.bin). If this file cannot be found > mkimage fails. To work around the problem the exception is caught, an > error message is printed and binman continues. But how can you continue, when mkimage fails and cannot generate the needed image? In your patch 2/2 we have this: + tools.Run('mkimage', '-d', input_fname, *self._args, output_fname) + except Exception as e: + tout.Error("mkimage failed: %s" % e) + self.SetContents(tools.ReadFile(output_fname)) mkimage is supposed to create an output file which name is in output_fname; if mkimage fails and you continue, the next step is tools.ReadFile(output_fname) trying to read that file. How is this possible? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de "One day," said a dull voice from down below, "I'm going to be back in form again and you're going to be very sorry you said that. For a very long time. I might even go so far as to make even more Time just for you to be sorry in." - Terry Pratchett, _Small Gods_