From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Wright Feng <Wright.Feng@cypress.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "franky.lin@broadcom.com" <franky.lin@broadcom.com>,
"hante.meuleman@broadcom.com" <hante.meuleman@broadcom.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
Chi-Hsien Lin <Chi-Hsien.Lin@cypress.com>,
"brcm80211-dev-list.pdl@broadcom.com"
<brcm80211-dev-list.pdl@broadcom.com>
Subject: Re: [PATCH 3/3] brcmfmac: make firmware frameburst mode a module parameter
Date: Tue, 30 Oct 2018 12:33:21 +0100 [thread overview]
Message-ID: <7292b499-96a6-96be-f9b7-e59df353427f@broadcom.com> (raw)
In-Reply-To: <1540808552-28738-4-git-send-email-wright.feng@cypress.com>
On 10/29/2018 11:27 AM, Wright Feng wrote:
> This patch is for adding a new module parameter "frameburst".
> With setting "frameburst=1" in module parameters, firmware frameburst mode
> will be enabled. The feature can enable per-packet framebursting in
> firmware side and get higher TX throughput in High Throughput(HT) mode.
I am not sure about every firmware image, but in recent branches here I
see firmware enables frameburst by default. So not sure about the
motivation to add this. You could also consider adding this to the
nl80211 api. I am sure other vendors have similar features.
Regards,
Arend
> Signed-off-by: Wright Feng <wright.feng@cypress.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 7 +++++++
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 5 +++++
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.h | 2 ++
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h | 1 +
> 4 files changed, 15 insertions(+)
next prev parent reply other threads:[~2018-10-30 11:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 10:27 [PATCH 0/3] brcmfmac: throughput enhancement for SDIO and flow control mode Wright Feng
2018-10-29 10:27 ` [PATCH 1/3] brcmfmac: calling skb_orphan before sending skb to SDIO bus Wright Feng
2018-10-29 18:50 ` Franky Lin
2018-11-02 3:08 ` Wright Feng
2018-11-02 19:51 ` Franky Lin
2018-11-03 1:36 ` Wright Feng
2018-10-29 10:27 ` [PATCH 2/3] brcmfmac: add credit numbers updating support Wright Feng
2018-10-30 11:04 ` Arend van Spriel
2018-11-02 7:54 ` Wright Feng
2018-10-29 10:27 ` [PATCH 3/3] brcmfmac: make firmware frameburst mode a module parameter Wright Feng
2018-10-30 11:33 ` Arend van Spriel [this message]
2018-11-02 3:22 ` Wright Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7292b499-96a6-96be-f9b7-e59df353427f@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=Chi-Hsien.Lin@cypress.com \
--cc=Wright.Feng@cypress.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.