From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] update_gio_module_cache: Do not chown a non-existing file
Date: Thu, 30 Mar 2017 12:38:44 +0300 [thread overview]
Message-ID: <72959861-69b9-7ed0-7a89-891a4aa9ed26@linux.intel.com> (raw)
In-Reply-To: <20170329231606.22118-1-pkj@axis.com>
On 03/30/2017 02:16 AM, Peter Kjellerstedt wrote:
> Only change the ownership of ${libdir}/gio/modules/giomodule.cache if
> it exists.
>
> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> ---
> scripts/postinst-intercepts/update_gio_module_cache | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/postinst-intercepts/update_gio_module_cache b/scripts/postinst-intercepts/update_gio_module_cache
> index 92092f2144..fc3f9d0d6c 100644
> --- a/scripts/postinst-intercepts/update_gio_module_cache
> +++ b/scripts/postinst-intercepts/update_gio_module_cache
> @@ -3,7 +3,7 @@
> set -e
>
> PSEUDO_UNLOAD=1 qemuwrapper -L $D -E LD_LIBRARY_PATH=$D${libdir}:$D${base_libdir} \
> - $D${libexecdir}/${binprefix}gio-querymodules $D${libdir}/gio/modules/
> -
> -chown root:root $D${libdir}/gio/modules/giomodule.cache
> + $D${libexecdir}/${binprefix}gio-querymodules $D${libdir}/gio/modules/
>
> +[ ! -e $D${libdir}/gio/modules/giomodule.cache ] ||
> + chown root:root $D${libdir}/gio/modules/giomodule.cache
>
Nope. The postinst-intercept scirpts are allowed to fail, and if they
are, they are deferred to first boot. If giomodule.cache file does not
exist, that means that qemu does not work for the target machine, which
is not a bug, and is handled by detecting script failure and taking the
same action at first boot time - which your change breaks.
Alex
next prev parent reply other threads:[~2017-03-30 9:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 23:16 [PATCH] update_gio_module_cache: Do not chown a non-existing file Peter Kjellerstedt
2017-03-30 9:29 ` Alexander Kanavin
2017-03-30 9:31 ` Richard Purdie
2017-03-30 9:34 ` Alexander Kanavin
2017-03-30 9:38 ` Alexander Kanavin [this message]
2017-03-30 10:53 ` Peter Kjellerstedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72959861-69b9-7ed0-7a89-891a4aa9ed26@linux.intel.com \
--to=alexander.kanavin@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.