From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46514C433EF for ; Mon, 27 Sep 2021 17:35:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F86A60E08 for ; Mon, 27 Sep 2021 17:35:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238333AbhI0RhL (ORCPT ); Mon, 27 Sep 2021 13:37:11 -0400 Received: from mga07.intel.com ([134.134.136.100]:46134 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239261AbhI0RfL (ORCPT ); Mon, 27 Sep 2021 13:35:11 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10120"; a="288185019" X-IronPort-AV: E=Sophos;i="5.85,327,1624345200"; d="scan'208";a="288185019" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2021 10:27:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,327,1624345200"; d="scan'208";a="615905152" Received: from linux.intel.com ([10.54.29.200]) by fmsmga001.fm.intel.com with ESMTP; 27 Sep 2021 10:27:28 -0700 Received: from debox1-desk1.jf.intel.com (debox1-desk1.jf.intel.com [10.54.75.53]) by linux.intel.com (Postfix) with ESMTP id 939735802BD; Mon, 27 Sep 2021 10:27:28 -0700 (PDT) Message-ID: <7295cafaf6da34e31390fe621198205d18eac525.camel@linux.intel.com> Subject: Re: [PATCH 2/2] platform/x86: Add Intel Software Defined Silicon driver From: "David E. Box" Reply-To: david.e.box@linux.intel.com To: Greg KH Cc: lee.jones@linaro.org, hdegoede@redhat.com, mgross@linux.intel.com, andriy.shevchenko@linux.intel.com, srinivas.pandruvada@intel.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Date: Mon, 27 Sep 2021 10:27:28 -0700 In-Reply-To: References: <20210924213157.3584061-1-david.e.box@linux.intel.com> <20210924213157.3584061-2-david.e.box@linux.intel.com> <3392aea6b112926b063bbe46b1decaad4c9f9e6e.camel@linux.intel.com> Organization: David E. Box Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2021-09-27 at 06:04 +0200, Greg KH wrote: > On Sun, Sep 26, 2021 at 06:15:16PM -0700, David E. Box wrote: > > > > +static struct platform_driver sdsi_driver = { > > > > +       .driver = { > > > > +               .name           = SDSI_DEV_NAME, > > > > +               .dev_groups     = sdsi_groups, > > > > +       }, > > > > +       .probe  = sdsi_probe, > > > > +       .remove = sdsi_remove, > > > > +}; > > > > +module_platform_driver(sdsi_driver); > > > > > > What causes the platform to know to register, and enable, this platform > > > driver?  Shouldn't there be some hardware involved that is discoverable > > > to enable it to load dynamically? > > > > Ah. The patch that adds the SDSi platform device string was added to a series for the intel_pmt > > MFD > > driver and it's still waiting review. I see that complicates things. I can combine the two series > > together. > > Do you have a pointer to the lore.kernel.org location of that series? https://lore.kernel.org/all/20210922213007.2738388-1-david.e.box@linux.intel.com/ > > Your code right here will bind to any system that it is loaded on, a > very dangerous thing... It won't. It uses module alias to load against the SDSi specific MFD cell. > > thanks, > > greg k-h