All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Guillaume Tucker <guillaume.tucker@collabora.com>,
	kernel test robot <lkp@intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: kbuild-all@lists.01.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH] media: vivid: drop CONFIG_FB dependency
Date: Wed, 4 Aug 2021 16:18:45 +0200	[thread overview]
Message-ID: <72a52c6b-c06b-f1fe-dda2-f9dd458ca342@xs4all.nl> (raw)
In-Reply-To: <da7e0fe9-c476-7b79-d99d-24a6d3308188@collabora.com>

Hi Guillaume,

On 30/07/2021 16:26, Guillaume Tucker wrote:
> On 30/07/2021 14:32, kernel test robot wrote:
>> Hi Guillaume,
>>
>> Thank you for the patch! Yet something to improve:
>>
>> [auto build test ERROR on linuxtv-media/master]
>> [also build test ERROR on v5.14-rc3 next-20210729]
>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>> And when submitting patch, we suggest to use '--base' as documented in
>> https://git-scm.com/docs/git-format-patch]
>>
>> url:    https://github.com/0day-ci/linux/commits/Guillaume-Tucker/media-vivid-drop-CONFIG_FB-dependency/20210729-191815
>> base:   git://linuxtv.org/media_tree.git master
>> config: m68k-allmodconfig (attached as .config)
>> compiler: m68k-linux-gcc (GCC) 10.3.0
>> reproduce (this is a W=1 build):
>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         # https://github.com/0day-ci/linux/commit/51defc67cada10450046e4d4e7eda1a2573371cc
>>         git remote add linux-review https://github.com/0day-ci/linux
>>         git fetch --no-tags linux-review Guillaume-Tucker/media-vivid-drop-CONFIG_FB-dependency/20210729-191815
>>         git checkout 51defc67cada10450046e4d4e7eda1a2573371cc
>>         # save the attached .config to linux build tree
>>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=m68k 
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>, old ones prefixed by <<):
>>
>>>> ERROR: modpost: "vivid_clear_fb" [drivers/media/test-drivers/vivid/vivid.ko] undefined!
>>>> ERROR: modpost: "vivid_fb_release_buffers" [drivers/media/test-drivers/vivid/vivid.ko] undefined!
>>>> ERROR: modpost: "vivid_fb_init" [drivers/media/test-drivers/vivid/vivid.ko] undefined!
> 
> Pretty sure this is due to the conditional in the Makefile I
> mentioned in an email yesterday, where it should have been
> ifneq ($(CONFIG_FB),) for when CONFIG_FB=m.
> 
> Let me know if I should send a v2 now with this fix, I was
> waiting for Hans' feedback first.

Go ahead and send a v2.

I have just one comment: in vivid-core.c, please change this in the node_types
MODULE_PARM_DESC:

                             "\t\t    bit 12: Radio Transmitter node\n"
                             "\t\t    bit 16: Framebuffer for testing overlays\n"
                             "\t\t    bit 17: Metadata Capture node\n"

to:

                             "\t\t    bit 12: Radio Transmitter node\n"
#ifdef CONFIG_FB
                             "\t\t    bit 16: Framebuffer for testing overlays\n"
#endif
                             "\t\t    bit 17: Metadata Capture node\n"

That way it is visible with modinfo whether or not framebuffer support is
compiled in or not.

Regards,

	Hans

> 
> Thanks,
> Guillaume
> 


WARNING: multiple messages have this Message-ID
From: Hans Verkuil <hverkuil@xs4all.nl>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] media: vivid: drop CONFIG_FB dependency
Date: Wed, 04 Aug 2021 16:18:45 +0200	[thread overview]
Message-ID: <72a52c6b-c06b-f1fe-dda2-f9dd458ca342@xs4all.nl> (raw)
In-Reply-To: <da7e0fe9-c476-7b79-d99d-24a6d3308188@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 2995 bytes --]

Hi Guillaume,

On 30/07/2021 16:26, Guillaume Tucker wrote:
> On 30/07/2021 14:32, kernel test robot wrote:
>> Hi Guillaume,
>>
>> Thank you for the patch! Yet something to improve:
>>
>> [auto build test ERROR on linuxtv-media/master]
>> [also build test ERROR on v5.14-rc3 next-20210729]
>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>> And when submitting patch, we suggest to use '--base' as documented in
>> https://git-scm.com/docs/git-format-patch]
>>
>> url:    https://github.com/0day-ci/linux/commits/Guillaume-Tucker/media-vivid-drop-CONFIG_FB-dependency/20210729-191815
>> base:   git://linuxtv.org/media_tree.git master
>> config: m68k-allmodconfig (attached as .config)
>> compiler: m68k-linux-gcc (GCC) 10.3.0
>> reproduce (this is a W=1 build):
>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         # https://github.com/0day-ci/linux/commit/51defc67cada10450046e4d4e7eda1a2573371cc
>>         git remote add linux-review https://github.com/0day-ci/linux
>>         git fetch --no-tags linux-review Guillaume-Tucker/media-vivid-drop-CONFIG_FB-dependency/20210729-191815
>>         git checkout 51defc67cada10450046e4d4e7eda1a2573371cc
>>         # save the attached .config to linux build tree
>>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=m68k 
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>, old ones prefixed by <<):
>>
>>>> ERROR: modpost: "vivid_clear_fb" [drivers/media/test-drivers/vivid/vivid.ko] undefined!
>>>> ERROR: modpost: "vivid_fb_release_buffers" [drivers/media/test-drivers/vivid/vivid.ko] undefined!
>>>> ERROR: modpost: "vivid_fb_init" [drivers/media/test-drivers/vivid/vivid.ko] undefined!
> 
> Pretty sure this is due to the conditional in the Makefile I
> mentioned in an email yesterday, where it should have been
> ifneq ($(CONFIG_FB),) for when CONFIG_FB=m.
> 
> Let me know if I should send a v2 now with this fix, I was
> waiting for Hans' feedback first.

Go ahead and send a v2.

I have just one comment: in vivid-core.c, please change this in the node_types
MODULE_PARM_DESC:

                             "\t\t    bit 12: Radio Transmitter node\n"
                             "\t\t    bit 16: Framebuffer for testing overlays\n"
                             "\t\t    bit 17: Metadata Capture node\n"

to:

                             "\t\t    bit 12: Radio Transmitter node\n"
#ifdef CONFIG_FB
                             "\t\t    bit 16: Framebuffer for testing overlays\n"
#endif
                             "\t\t    bit 17: Metadata Capture node\n"

That way it is visible with modinfo whether or not framebuffer support is
compiled in or not.

Regards,

	Hans

> 
> Thanks,
> Guillaume
> 

  reply	other threads:[~2021-08-04 14:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29 11:16 [PATCH] media: vivid: drop CONFIG_FB dependency Guillaume Tucker
2021-07-29 11:32 ` Guillaume Tucker
2021-07-29 18:53   ` Guillaume Tucker
2021-07-30 13:32 ` kernel test robot
2021-07-30 13:32   ` kernel test robot
2021-07-30 14:26   ` Guillaume Tucker
2021-07-30 14:26     ` Guillaume Tucker
2021-08-04 14:18     ` Hans Verkuil [this message]
2021-08-04 14:18       ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72a52c6b-c06b-f1fe-dda2-f9dd458ca342@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=guillaume.tucker@collabora.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.