From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08822C433FE for ; Mon, 7 Dec 2020 10:55:22 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9225F23341 for ; Mon, 7 Dec 2020 10:55:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9225F23341 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.46222.82007 (Exim 4.92) (envelope-from ) id 1kmEAd-00028v-6W; Mon, 07 Dec 2020 10:55:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 46222.82007; Mon, 07 Dec 2020 10:55:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmEAd-00028o-3Q; Mon, 07 Dec 2020 10:55:07 +0000 Received: by outflank-mailman (input) for mailman id 46222; Mon, 07 Dec 2020 10:55:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmEAb-00028e-4y for xen-devel@lists.xenproject.org; Mon, 07 Dec 2020 10:55:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmEAZ-0005xY-NY; Mon, 07 Dec 2020 10:55:03 +0000 Received: from [54.239.6.186] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kmEAZ-0005dh-Ek; Mon, 07 Dec 2020 10:55:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=NnEbqKOdR082NW0t9XwGlGICAQ9n8pOelvEy3ARGAM4=; b=EnlJN2dOBtNox/O5f0saZ6evoi qlzgjMIoZ4GNzKJAFBOfqNWlg9siTPnNIJwaub1ezgryKihFJcAISY/TrPcHYgQtVb9PuaRpP37J0 xrC04R3N9JuvjUF7qpYPJfWy++g7UoSZcKZ/4Df7aXs3bRPKSNrEEoEOSB6zxMWiFrkE=; Subject: Re: [PATCH v2 7/8] xen/arm: Remove Linux specific code that is not usable in XEN To: Rahul Singh Cc: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk References: <1d9da8ed4845aeb9e86a5ce6750b811bd7e2020e.1606406359.git.rahul.singh@arm.com> <51C0C24A-3CE6-48A3-85F5-14F010409DC3@arm.com> <0B43914F-93E1-4860-BA45-7E08F817818C@arm.com> From: Julien Grall Message-ID: <72c29861-4e50-dd7d-9986-a84000ece1dd@xen.org> Date: Mon, 7 Dec 2020 10:55:01 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <0B43914F-93E1-4860-BA45-7E08F817818C@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 07/12/2020 10:36, Rahul Singh wrote: >> I would implement it in include/xen/compiler.h. > > Ok. I will implement and will share the patch for “__attribute__((__fallthrough__)) ” but for SMMUv3 is that ok if we can proceed with “ /* fallthrough */ ". The first approach should always be to work with the community to introduce such functionality tree-wide. Note that I am not suggesting to replace existing "/* fallthrough */" with "fallthrough". If it is taking too long or the task is significant, then we can discuss about way to temporally work around it. I don't believe we are at that stage yet here. > As “fallthorugh” implementation is common for all architecture it required review for all stakeholder as per my understanding. I don’t want to block SMMUv3 because of this. It only requires review from "THE REST" maintainers. Cheers, -- Julien Grall