All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
	"Chenyang Li" <lichenyang@loongson.cn>,
	"Chen Guchun" <Guchun.Chen@amd.com>,
	amd-gfx@lists.freedesktop.org,
	"Christina König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition
Date: Sun, 27 Dec 2020 11:53:12 +0100	[thread overview]
Message-ID: <72cdedf8-8850-2ad8-b8bc-d26eb1e2996f@molgen.mpg.de> (raw)
In-Reply-To: <9dd7dbb4-cea0-da1d-042c-a2b5e69ef1bd@gmail.com>

Dear Christian,


Am 27.12.20 um 10:38 schrieb Christian König:
> Am 26.12.20 um 14:16 schrieb Paul Menzel:

>> Am 26.12.20 um 09:56 schrieb Chenyang Li:
>>> Add an underscore in amdgpu_trace.h line 24 "_AMDGPU_TRACE_H".
>>>
>>> Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
> 
> Well this Fixes tag is superfluous/misleading and should probably be 
> removed.

Why is it misleading?

> Why was that added?

I asked for that, because that is the commit introducing the issue, and 
with that tag it’s  more likely to picked for the stable series.

[…]


Kind regards,

Paul
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply	other threads:[~2020-12-27 10:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-26  8:56 [PATCH] drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition Chenyang Li
2020-12-26 13:16 ` Paul Menzel
2020-12-27  9:38   ` Christian König
2020-12-27 10:53     ` Paul Menzel [this message]
2020-12-29 10:12       ` Christian König
2021-01-04 17:08 ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72cdedf8-8850-2ad8-b8bc-d26eb1e2996f@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=Guchun.Chen@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=ckoenig.leichtzumerken@gmail.com \
    --cc=lichenyang@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.