From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3C3CC2BA17 for ; Mon, 6 Apr 2020 15:39:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA5EC20748 for ; Mon, 6 Apr 2020 15:39:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="W5NEcwDI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA5EC20748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLTqh-0002Ro-QX for qemu-devel@archiver.kernel.org; Mon, 06 Apr 2020 11:39:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44022) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLTq2-0001f6-G1 for qemu-devel@nongnu.org; Mon, 06 Apr 2020 11:39:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLTq1-0002Sd-BG for qemu-devel@nongnu.org; Mon, 06 Apr 2020 11:39:02 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:38754 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jLTq1-0002RU-7p for qemu-devel@nongnu.org; Mon, 06 Apr 2020 11:39:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586187540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wolWVV2f1OTROE//01t7hqZ5YBg6Br7pP0R/5A1ZXhs=; b=W5NEcwDIhPGkbGZqBvaeiGv6EOOy2GHcneIjYEnmP07zXVhqYJ6Ylhl9CbvEcZXkARfMw+ XCr3mniQg049cXs6/H7gtAsQj+K4YZDBlcXY7GlaYNbKDQSqNnjnEZIJhqpfR/ymCRc6XJ 1LZVcWaA5uOjfIjK2DzbVUCvjxxGQu8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-68-RNGgcjG1PYOMMvymXl97Xg-1; Mon, 06 Apr 2020 11:38:52 -0400 X-MC-Unique: RNGgcjG1PYOMMvymXl97Xg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A0BDD801E5E; Mon, 6 Apr 2020 15:38:50 +0000 (UTC) Received: from [10.3.114.49] (ovpn-114-49.phx2.redhat.com [10.3.114.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C6F8560BE1; Mon, 6 Apr 2020 15:38:46 +0000 (UTC) Subject: Re: [PATCH v5 for-5.0] configure: warn if not using a separate build directory To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-devel@nongnu.org References: <20200406153326.806024-1-berrange@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <72daed8e-020f-c5b0-4ef8-6f9d3f105434@redhat.com> Date: Mon, 6 Apr 2020 10:38:45 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200406153326.806024-1-berrange@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , Liviu Ionescu , Markus Armbruster , Aleksandar Markovic , Stefan Hajnoczi , Paolo Bonzini , =?UTF-8?Q?Michal_Such=c3=a1nek?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Aleksandar Markovic Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/6/20 10:33 AM, Daniel P. Berrang=C3=A9 wrote: > Running configure directly from the source directory is a build > configuration that will go away in future. It is also not currently > covered by any automated testing. Display a deprecation warning if Calling it a deprecation warning may be overkill now that we've toned=20 down the language. > the user attempts to use an in-srcdir build setup, so that they are > aware that they're building QEMU in an undesirable manner. >=20 > Reviewed-by: Aleksandar Markovic > Tested-by: Philippe Mathieu-Daud=C3=A9 > Signed-off-by: Daniel P. Berrang=C3=A9 > --- >=20 > +if test "$in_srcdir" =3D "yes"; then > + echo > + echo "NOTE: we recommend against building in the source directory" > + echo > + echo "You've run the 'configure' script directly from the source" > + echo "directory. This will work, but we recommend using a separate" > + echo "build directory, especially if you plan to work with the QEMU" > + echo "sources rather than just building it once. You can switch to" > + echo "a separate build directory like this:" > + echo > + echo " $ mkdir build" As I pointed out on v4, this is missing a step. Since this is just a=20 warning and not fatal, './configure' completed and polluted the in-tree=20 directories to the point that following these instructions will fail=20 unless they start with 'make distclean' prior to the other steps. > + echo " $ cd build" > + echo " $ ../configure" > + echo " $ make" > + echo > +fi > + > config_host_mak=3D"config-host.mak" > =20 > echo "# Automatically generated by configure - do not modify" >config-a= ll-disas.mak >=20 --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org