From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>,
"Habkost, Eduardo" <ehabkost@redhat.com>
Subject: Re: [PATCH for-5.1?] target/i386: Save cc_op before loop insns
Date: Fri, 24 Jul 2020 14:47:53 -0700 [thread overview]
Message-ID: <72edd3a8-55df-221c-5b4a-8e8f4a80b07d@linaro.org> (raw)
In-Reply-To: <CABgObfZVXtspgcoG_b33j5NcCSJFiBCXntT+388GWFuJ0aTh2A@mail.gmail.com>
On 7/24/20 11:53 AM, Paolo Bonzini wrote:
> Looks good, will queue when I am back---or just send a pull request yourself if
> you prefer.
Ok, will do. Thanks.
r~
>
> Paolo
>
> Il ven 24 lug 2020, 20:35 Richard Henderson <richard.henderson@linaro.org
> <mailto:richard.henderson@linaro.org>> ha scritto:
>
> Ping?
>
> On 7/20/20 8:40 AM, Richard Henderson wrote:
> > We forgot to update cc_op before these branch insns,
> > which lead to losing track of the current eflags.
> >
> > Buglink: https://bugs.launchpad.net/qemu/+bug/1888165
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org
> <mailto:richard.henderson@linaro.org>>
> > ---
> > target/i386/translate.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/target/i386/translate.c b/target/i386/translate.c
> > index a1d31f09c1..caea6f5fb1 100644
> > --- a/target/i386/translate.c
> > +++ b/target/i386/translate.c
> > @@ -7148,6 +7148,7 @@ static target_ulong disas_insn(DisasContext *s,
> CPUState *cpu)
> > l1 = gen_new_label();
> > l2 = gen_new_label();
> > l3 = gen_new_label();
> > + gen_update_cc_op(s);
> > b &= 3;
> > switch(b) {
> > case 0: /* loopnz */
> >
>
next prev parent reply other threads:[~2020-07-24 21:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 15:40 [PATCH for-5.1?] target/i386: Save cc_op before loop insns Richard Henderson
2020-07-24 18:34 ` Richard Henderson
2020-07-24 18:53 ` Paolo Bonzini
2020-07-24 21:47 ` Richard Henderson [this message]
2020-07-24 19:23 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72edd3a8-55df-221c-5b4a-8e8f4a80b07d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.