From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: John Snow <jsnow@redhat.com>, Denis Lunev <den@virtuozzo.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"quintela@redhat.com" <quintela@redhat.com>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"famz@redhat.com" <famz@redhat.com>,
"mreitz@redhat.com" <mreitz@redhat.com>,
"kwolf@redhat.com" <kwolf@redhat.com>,
Eric Blake <eblake@redhat.com>
Subject: [Qemu-devel] ping2 Re: [PATCH 4/6] dirty-bitmaps: clean-up bitmaps loading and migration logic
Date: Mon, 29 Oct 2018 17:52:09 +0000 [thread overview]
Message-ID: <72f7a1bd-940d-475f-ceb6-cd105fe02e2b@virtuozzo.com> (raw)
In-Reply-To: <26c0e008-898d-924a-214e-68ab9fedf1ea@virtuozzo.com>
ping2
Hi, what about this finally? Looks like everyone see a lot of comments
and thing, that there should be a new version, but actually, there is
almost unrelated discussion and/or answered questions. Only rephrasing
by Eric in patch 2 may be applied, to change something.
The series fix the bug in bitmaps migration, look at patch 5.
18.09.2018 13:37, Vladimir Sementsov-Ogievskiy wrote:
> 17.09.2018 21:33, John Snow wrote:
>>
>> On 09/17/2018 11:51 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> Hmm, ping, anybody here ?)
>>>
>> Was preparing to stage on Friday, working on it now.
>>
>> I never understood why you forbid the transfer of read only bitmaps
>> though, can you point that out for me?
>>
>> --js
>
> readonly bitmap - means it is not marked in_use in qcow2 file.
>
> Hm, I don't remember exact reason, but at least for shared migration
> it is unsafe to migrate readonly bitmap without special handling: we
> migrate it, it becomes not-readonly, it changes in RAM, then (assume)
> storing failed and we have old version ofthe bitmap in qcow2, which is
> not marked in_use.. So it should be somehow carefully handled, the
> simplest option is just to forbid it.
>
--
Best regards,
Vladimir
next prev parent reply other threads:[~2018-10-29 17:52 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 13:50 [Qemu-devel] [PATCH 0/6] fix persistent bitmaps migration logic Vladimir Sementsov-Ogievskiy
2018-06-26 13:50 ` [Qemu-devel] [PATCH 1/6] iotests: 169: drop deprecated 'autoload' parameter Vladimir Sementsov-Ogievskiy
2018-07-09 22:36 ` John Snow
2018-06-26 13:50 ` [Qemu-devel] [PATCH 2/6] block/qcow2: improve error message in qcow2_inactivate Vladimir Sementsov-Ogievskiy
2018-06-28 12:16 ` Eric Blake
2018-07-09 22:38 ` John Snow
2018-06-26 13:50 ` [Qemu-devel] [PATCH 3/6] bloc/qcow2: drop dirty_bitmaps_loaded state variable Vladimir Sementsov-Ogievskiy
2018-07-09 23:25 ` John Snow
2018-07-10 7:43 ` Vladimir Sementsov-Ogievskiy
2018-07-17 19:10 ` John Snow
2018-06-26 13:50 ` [Qemu-devel] [PATCH 4/6] dirty-bitmaps: clean-up bitmaps loading and migration logic Vladimir Sementsov-Ogievskiy
2018-07-21 2:41 ` John Snow
2018-08-01 10:20 ` Dr. David Alan Gilbert
2018-08-01 17:34 ` John Snow
2018-08-01 17:40 ` Dr. David Alan Gilbert
2018-08-01 18:42 ` Denis V. Lunev
2018-08-01 18:55 ` Dr. David Alan Gilbert
2018-08-01 20:25 ` Denis V. Lunev
2018-08-02 9:29 ` Dr. David Alan Gilbert
2018-08-02 9:38 ` Denis V. Lunev
2018-08-02 9:50 ` Dr. David Alan Gilbert
2018-08-02 19:05 ` Denis V. Lunev
2018-08-02 19:10 ` John Snow
[not found] ` <6d8ed319-9b63-5a7b-fcfe-20cd37cf8c7c@virtuozzo.com>
[not found] ` <d2538432-be74-99bc-72d1-94f8abaa2f9b@redhat.com>
[not found] ` <26c0e008-898d-924a-214e-68ab9fedf1ea@virtuozzo.com>
2018-10-15 9:42 ` [Qemu-devel] ping " Vladimir Sementsov-Ogievskiy
2018-10-29 17:52 ` Vladimir Sementsov-Ogievskiy [this message]
2018-10-29 18:06 ` [Qemu-devel] ping2 " John Snow
2018-08-03 8:33 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-08-03 8:44 ` Vladimir Sementsov-Ogievskiy
2018-08-03 8:49 ` Dr. David Alan Gilbert
2018-08-03 8:59 ` Denis V. Lunev
2018-08-03 9:10 ` Dr. David Alan Gilbert
2018-08-01 18:56 ` John Snow
2018-08-01 20:31 ` Denis V. Lunev
2018-08-01 20:47 ` Denis V. Lunev
2018-08-01 22:28 ` John Snow
2018-08-02 10:23 ` Vladimir Sementsov-Ogievskiy
2018-08-01 12:24 ` Vladimir Sementsov-Ogievskiy
2018-06-26 13:50 ` [Qemu-devel] [PATCH 5/6] iotests: improve 169 Vladimir Sementsov-Ogievskiy
2018-06-26 13:50 ` [Qemu-devel] [PATCH 6/6] iotests: 169: add cases for source vm resuming Vladimir Sementsov-Ogievskiy
2018-06-26 18:22 ` [Qemu-devel] [PATCH 0/6] fix persistent bitmaps migration logic John Snow
2018-06-28 12:04 ` Vladimir Sementsov-Ogievskiy
2018-06-26 18:36 ` John Snow
2018-07-12 19:00 ` Vladimir Sementsov-Ogievskiy
2018-07-12 20:25 ` John Snow
2018-07-13 6:46 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72f7a1bd-940d-475f-ceb6-cd105fe02e2b@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.