From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 040B6C433EF for ; Thu, 5 May 2022 08:37:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234643AbiEEIl3 (ORCPT ); Thu, 5 May 2022 04:41:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232576AbiEEIl2 (ORCPT ); Thu, 5 May 2022 04:41:28 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3726349913 for ; Thu, 5 May 2022 01:37:48 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id c190-20020a1c35c7000000b0038e37907b5bso4666701wma.0 for ; Thu, 05 May 2022 01:37:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=9EomTWkj5HWC9HSFz6GdVw86QRTFm3rQMXGeFndUEdo=; b=DUptQS/O9Q9UJj2AG3SWh55ruJHnywPhx/EXPb+RdE3NWXQmZIx59cIEnjfZs/nr9a 0YfhyYJnC8KD40HohtTDj8tAVeC1HxqJsBLxwcD1TNVDivMXJ6Tz0EJaCgroMQoqLO6I +TNKnxiLtOJmgPFcI0dPUhHbtnABXshfU7Cj3mSgGhtnKVYSMdVm0sxd1WuzPXmcxYLx pD+10fA+N6xPCBVCtsr3etbuoWEUUSrM4lwc+aXPZTtLMhwUriSxnnsguENZpdMOmBO1 CcDiIpBKdd5SWaITnfa5Cj07T3/a5oCoHh9dxSFz13iquxp4nY3lOD/uoJki5IfLMhwK 56Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=9EomTWkj5HWC9HSFz6GdVw86QRTFm3rQMXGeFndUEdo=; b=TiNIi2d4L7ykekfeO0Tia0jNGKerC9HXfiVBbc2J74D+hmeWH1PcYbRuprVjnaAHYd mPxQhYWAzfcq/4Dc/OwqFaD5p8See52hvHxIL4RR/crRq61NHM63CNJOWmyKLfdKarET hh6owWqiJ8+UrmJTjbbkrFvjr7waQG0pME2QWNF9t59hb2bRTPII3fQ8QgKgujtKHzU+ Y+vIbw7/GMl0JKyxLn/VScLQCroSMjBx3hWHX1Ab9HJaAS99dkxLJFL8F0FYdONpB1jG nknjYMdwtXBgERXhXQ4F1oYRrxdSCWLPfQ+W6NBxf+d/Zawx7FRkaHqWKCoFxlFBdTd5 Gc4Q== X-Gm-Message-State: AOAM5310TrzDXtVjVu5kfdt9kU0mMK8WJAHEWOgNUgyDMaiPzQpk4TH5 dtKJBU3WtT8usQsSC7Q16naLkA== X-Google-Smtp-Source: ABdhPJzpvOP08C0LQGFGRn3if9YYgSMu9dpR5z5GqutXqQm2XV6HiPCKizP8Z9CqOapQ59H/GpJYZw== X-Received: by 2002:a05:600c:4f55:b0:393:f140:d386 with SMTP id m21-20020a05600c4f5500b00393f140d386mr3456815wmq.80.1651739866814; Thu, 05 May 2022 01:37:46 -0700 (PDT) Received: from [192.168.0.217] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id ba28-20020a0560001c1c00b0020c5253d8c8sm688756wrb.20.2022.05.05.01.37.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 May 2022 01:37:46 -0700 (PDT) Message-ID: <7316927c-3068-90b6-3500-bf759bb46493@linaro.org> Date: Thu, 5 May 2022 10:37:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 5/6] dt-bindings: mailbox: qcom: set correct #clock-cells Content-Language: en-US To: Robert Marko , agross@kernel.org, bjorn.andersson@linaro.org, jassisinghbrar@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, dmitry.baryshkov@linaro.org References: <20220503195605.4015616-1-robimarko@gmail.com> <20220503195605.4015616-5-robimarko@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220503195605.4015616-5-robimarko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 03/05/2022 21:56, Robert Marko wrote: > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > index 3b5ba7ecc19d..1f803925867e 100644 > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > @@ -50,7 +50,7 @@ properties: > const: 1 > > '#clock-cells': > - const: 0 > + enum: [0, 1] > > clock-names: > minItems: 2 > @@ -96,6 +96,22 @@ allOf: > properties: > clocks: > maxItems: 3 > + - if: > + properties: > + compatible: > + enum: > + - qcom,ipq6018-apcs-apps-global > + - qcom,ipq8074-apcs-apps-global > + then: > + properties: > + '#clock-cells': > + const: 1 > + If there is a respin, please drop this blank line. > + else: > + properties: > + '#clock-cells': > + const: 0 > + > examples: > > # Example apcs with msm8996 Best regards, Krzysztof