From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F280C433EF for ; Sun, 24 Apr 2022 23:01:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239869AbiDXXEm (ORCPT ); Sun, 24 Apr 2022 19:04:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233081AbiDXXEj (ORCPT ); Sun, 24 Apr 2022 19:04:39 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0163434B98; Sun, 24 Apr 2022 16:01:37 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id q19so11940161pgm.6; Sun, 24 Apr 2022 16:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=s1BNXjd8cb+tHinFYr/exe+lPULhk8THSbaXt5aXW98=; b=ZEMy8WIbmX6koudQDZSOTIz/ULGDtpdyBocskD+NrIYVa7dxqthaXnl8dsS/WYR/5t 89YD7+ZPOy0ocXbyU2Xko7OM+d3YSyvjHZRaZhoYHrTEvKX9FB1W5gToeSt4kY2asOR9 QOs++We4m4SPkr6rBYWA2eTys//pGzydIeJUGXYny1hdrVuO1KIFlJih6HPAId9taQQd 4cLVQq+y5Uujrpi8XoomSyx6GXaggCvTTZZiFQdiHyoJjbNs572zRsUHqPpTfSkA4TU6 GCkkXY7LQ29y709+vmATdC+ojuYugXfz+WSd0ZMLeNds2ier1gG7BX0YHwOVQUv6C4rX ZiyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=s1BNXjd8cb+tHinFYr/exe+lPULhk8THSbaXt5aXW98=; b=6Xk0y2E05VN7CQEWJeP417Bbj94hLTrtbOzbE+iSNj6nIeJLkbklzU+xZhplL8nfGM iWdy342Sv8hB2DVhu33dSkJIg5wpqT4x/gB0LlN31+rN3mgjm1F64WOwrH6Xw5kAvicp k1ybeDZg+rF+BR4acbRLPtLPEPtqThA9V8lmq4ref/8W4+L+9NC71XaSdxL/eeH76ay4 iG9yB0sKM9T1NzG6jFgX2p1lGZrZurH7hhcsuEwKT4QJeQOh3CM4UxcgR9nq7Ofox/0V xCiOU870d+EVsgFmYZdAzreGxxoYO/DjiB9VKkDoM60GztYCehupjKj8BzNYUJy4bEhV IGnA== X-Gm-Message-State: AOAM5328n/pi4kAFjOSmMy/ijYSMA3QXHmZeItfVRltUqJeNRe64zI6K MZm7t6hrNHHTFTTKTXTz+LA= X-Google-Smtp-Source: ABdhPJx+inVB7C8Y1knalNuPog1W48QrwaNzqTXZLC71TUI/pGy7qIgItp22YUYsXYl/gQfGesmReQ== X-Received: by 2002:aa7:8385:0:b0:4f6:ef47:e943 with SMTP id u5-20020aa78385000000b004f6ef47e943mr16239456pfm.38.1650841297462; Sun, 24 Apr 2022 16:01:37 -0700 (PDT) Received: from ?IPV6:2600:8802:b00:4a48:e8c2:61e6:29d3:3011? ([2600:8802:b00:4a48:e8c2:61e6:29d3:3011]) by smtp.gmail.com with ESMTPSA id g12-20020a056a001a0c00b004e1307b249csm9555884pfv.69.2022.04.24.16.01.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Apr 2022 16:01:35 -0700 (PDT) Message-ID: <7316bb36-a5b6-b34a-1299-98605ce9d2c2@gmail.com> Date: Sun, 24 Apr 2022 16:01:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [Patch net-next] net: dsa: ksz: added the generic port_stp_state_set function Content-Language: en-US To: Arun Ramadoss , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: paolo Abeni , Jakub Kicinski , "David S. Miller" , Vladimir Oltean , Vivien Didelot , Andrew Lunn , UNGLinuxDriver@microchip.com, Woojung Huh References: <20220424112831.11504-1-arun.ramadoss@microchip.com> From: Florian Fainelli In-Reply-To: <20220424112831.11504-1-arun.ramadoss@microchip.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/24/2022 4:28 AM, Arun Ramadoss wrote: > The ksz8795 and ksz9477 uses the same algorithm for the > port_stp_state_set function except the register address is different. So > moved the algorithm to the ksz_common.c and used the dev_ops for > register read and write. This function can also used for the lan937x > part. Hence making it generic for all the parts. > > Signed-off-by: Arun Ramadoss Reviewed-by: Florian Fainelli -- Florian