From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E383EC432C3 for ; Thu, 14 Nov 2019 09:00:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BAFD1206F0 for ; Thu, 14 Nov 2019 09:00:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="DqCtJziY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726378AbfKNJAL (ORCPT ); Thu, 14 Nov 2019 04:00:11 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:37120 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725920AbfKNJAL (ORCPT ); Thu, 14 Nov 2019 04:00:11 -0500 Received: by mail-lf1-f67.google.com with SMTP id b20so4402001lfp.4 for ; Thu, 14 Nov 2019 01:00:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PlNrN2GhAvRY7IW8hzvOGZWhxEVtG6SWuwKkUSlWRyI=; b=DqCtJziYkryUZAUqd2xAAGwJFBCGTywmDlEpqjTs1//7QvPdR0AwIUntDfUsmL7VXt inp5/f3kzSiCI/REeaZwhuroE7fO4RLz1hNiMXce1uHOOoWd/krMOrPvIsHk8VUu/Idx CVhp6Qxtadp2q8Bf0VYuQFMBrMOjcRmWU1E3U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PlNrN2GhAvRY7IW8hzvOGZWhxEVtG6SWuwKkUSlWRyI=; b=ZzBhPUEaX2PJV/hXk02jmAgHr2jpMOs+eAaVrE7WUaTu5RzASgH2Uwfc1y4L9T/fW7 ffJfAdfhBW7dn45c/VzVGUN0BhL/QPHyUBClylrkkMrpndZJRh0PucUN2EibpKEXcCOm 6IfO7hRrTzsi7Fx1ZSyovHELCzMBcb+k8LQdiE8VlMzQyDFvqR4alwoFY+quyqZ42XNd SpipXeiBH1bjLQNPzytlmD17KU7hXk/UdY1mDeB+6UdisqABVL9fJ84GLQtvEEX/cPOF laJpCJZJzhEZ+4/n7WwNT/Z7wxFQyi44aIjgAIjohZ2dYBxCb7GbxmUpbkQjYv278it+ gceA== X-Gm-Message-State: APjAAAUlCIygieq7YCB4SFhHVgPTrwApS44ImqOz350tIgfUI6uigfnK H5K9KOTAluEdh0KrsOD/jNEC+A== X-Google-Smtp-Source: APXvYqziuBwUwTFwvFITVp9Y42/Pf1aEQFfzH3vqpE2R1SKDE+E1rudpEqbbReFJja9okUlvGnJRkA== X-Received: by 2002:a19:c386:: with SMTP id t128mr2627137lff.7.1573722009265; Thu, 14 Nov 2019 01:00:09 -0800 (PST) Received: from [172.16.11.28] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id o26sm2073916lfi.57.2019.11.14.01.00.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Nov 2019 01:00:08 -0800 (PST) Subject: Re: [PATCH v4 30/47] serial: ucc_uart: factor out soft_uart initialization To: Timur Tabi Cc: Qiang Zhao , Li Yang , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel , lkml , Scott Wood , linux-serial@vger.kernel.org References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-31-linux@rasmusvillemoes.dk> From: Rasmus Villemoes Message-ID: <73337067-953c-55e2-986a-24116fb10544@rasmusvillemoes.dk> Date: Thu, 14 Nov 2019 10:00:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/11/2019 06.14, Timur Tabi wrote: > On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes > wrote: >> >> - /* >> - * Determine if we need Soft-UART mode >> - */ >> if (of_find_property(np, "soft-uart", NULL)) { >> dev_dbg(&ofdev->dev, "using Soft-UART mode\n"); >> soft_uart = 1; >> + } else { >> + return 0; >> } > > How about: > > if (!of_find_property(np, "soft-uart", NULL)) > return 0; of_property_read_bool() if anything. But I didn't want to do that kind of transformation - just a pure "move this code out and fix the indentation" with the minor edits needed to hook it back up where it came from. > And I think you should be able to get rid of the "soft_uart" variable. Eh, no, it's used in several other places in the driver. I kind of hope gcc is smart enough to see that in the !PPC32 case it is a static, never-assigned-to, never-escapes variable so all the "if (soft_uart)" branches go away, but that's not really very important. Rasmus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 680A4C432C3 for ; Thu, 14 Nov 2019 09:02:37 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AAE320709 for ; Thu, 14 Nov 2019 09:02:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="DqCtJziY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AAE320709 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47DFqZ2rYnzF4rX for ; Thu, 14 Nov 2019 20:02:33 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=rasmusvillemoes.dk (client-ip=2a00:1450:4864:20::144; helo=mail-lf1-x144.google.com; envelope-from=linux@rasmusvillemoes.dk; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="DqCtJziY"; dkim-atps=neutral Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47DFmt6k0JzF4ny for ; Thu, 14 Nov 2019 20:00:14 +1100 (AEDT) Received: by mail-lf1-x144.google.com with SMTP id q5so4378226lfo.10 for ; Thu, 14 Nov 2019 01:00:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PlNrN2GhAvRY7IW8hzvOGZWhxEVtG6SWuwKkUSlWRyI=; b=DqCtJziYkryUZAUqd2xAAGwJFBCGTywmDlEpqjTs1//7QvPdR0AwIUntDfUsmL7VXt inp5/f3kzSiCI/REeaZwhuroE7fO4RLz1hNiMXce1uHOOoWd/krMOrPvIsHk8VUu/Idx CVhp6Qxtadp2q8Bf0VYuQFMBrMOjcRmWU1E3U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PlNrN2GhAvRY7IW8hzvOGZWhxEVtG6SWuwKkUSlWRyI=; b=OpHnfzyqLM5OxGVLU/rY0QlLnFW32Y018C4IUoMa0A2aV+V4dBAfzw15Kt+zzwPrrn cLJdHcnC+WulNKcu/IbYTCi6iTGJuxnhKm0RACSxuWupQcWed8/QTzCDGRq6Lc8kBznP ckCigwO9RMZnG3uAJOINfHthCKFdQTKsZIxZS2xr4fFS1ZG3M/aWf6P+Fr9raDV+gc9m kQnTrAtsc+cuBdu52Wa4Cm+5IWi6vSDIVPZq5zvOyarEfo23P5x+f8IP9M6Ct7T4YnfE vmx+iyFDyWhqUtl1NWOEMceHv1F0H8w87ua8+OyQ10xjQ/XqJujFbW8YbneDVXsIdR0W qY3Q== X-Gm-Message-State: APjAAAUMILjfmniOqEScReIlqYs3jQoR3PinoR8Wm5hrveM4TeNov42o UnbtAOtyGdedklKzWnSAJ5YLpg== X-Google-Smtp-Source: APXvYqziuBwUwTFwvFITVp9Y42/Pf1aEQFfzH3vqpE2R1SKDE+E1rudpEqbbReFJja9okUlvGnJRkA== X-Received: by 2002:a19:c386:: with SMTP id t128mr2627137lff.7.1573722009265; Thu, 14 Nov 2019 01:00:09 -0800 (PST) Received: from [172.16.11.28] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id o26sm2073916lfi.57.2019.11.14.01.00.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Nov 2019 01:00:08 -0800 (PST) Subject: Re: [PATCH v4 30/47] serial: ucc_uart: factor out soft_uart initialization To: Timur Tabi References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-31-linux@rasmusvillemoes.dk> From: Rasmus Villemoes Message-ID: <73337067-953c-55e2-986a-24116fb10544@rasmusvillemoes.dk> Date: Thu, 14 Nov 2019 10:00:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lkml , Li Yang , Scott Wood , linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel , Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 14/11/2019 06.14, Timur Tabi wrote: > On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes > wrote: >> >> - /* >> - * Determine if we need Soft-UART mode >> - */ >> if (of_find_property(np, "soft-uart", NULL)) { >> dev_dbg(&ofdev->dev, "using Soft-UART mode\n"); >> soft_uart = 1; >> + } else { >> + return 0; >> } > > How about: > > if (!of_find_property(np, "soft-uart", NULL)) > return 0; of_property_read_bool() if anything. But I didn't want to do that kind of transformation - just a pure "move this code out and fix the indentation" with the minor edits needed to hook it back up where it came from. > And I think you should be able to get rid of the "soft_uart" variable. Eh, no, it's used in several other places in the driver. I kind of hope gcc is smart enough to see that in the !PPC32 case it is a static, never-assigned-to, never-escapes variable so all the "if (soft_uart)" branches go away, but that's not really very important. Rasmus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A13EC43141 for ; Thu, 14 Nov 2019 09:00:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 154E320715 for ; Thu, 14 Nov 2019 09:00:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EEzThqJC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="DqCtJziY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 154E320715 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DaUEnwmI4TAAybI4PAu12CSfMO60ph/omW2sGq9YDjY=; b=EEzThqJCJaomAq UUKi5Hu6Mr8218iO+JMl9L1kG6gl8OOZwShtJiyjcuHjJ5FdNBv6NQ1iVUJpv/LvKzXYqMDQrjzQz GT0cwzCBcxlVUT8vBL8v9O3eTypNivcylBTV6SJGuRVi/NpdSZi2TNtjm83xN7xlxNTmHiGqXSvw6 LlGkINPmvj466ufjx0Bg3/w6FkiQEahoBHbZGEuYrcBMh1NFHlhGWdZcWuWWwgQBIt5RBCX5bEqte HQeVOf5YrKYc/+UYP4NO5tHeC75IGHfSy1ZU0KMrzDFagUTbHZMzynfirVseItNyD0YtZuyea1fs0 lKoxBSaRmTkcZXZwxAEw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVAz8-0001g8-CR; Thu, 14 Nov 2019 09:00:14 +0000 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVAz5-0001fH-UO for linux-arm-kernel@lists.infradead.org; Thu, 14 Nov 2019 09:00:13 +0000 Received: by mail-lf1-x141.google.com with SMTP id y186so4404565lfa.1 for ; Thu, 14 Nov 2019 01:00:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PlNrN2GhAvRY7IW8hzvOGZWhxEVtG6SWuwKkUSlWRyI=; b=DqCtJziYkryUZAUqd2xAAGwJFBCGTywmDlEpqjTs1//7QvPdR0AwIUntDfUsmL7VXt inp5/f3kzSiCI/REeaZwhuroE7fO4RLz1hNiMXce1uHOOoWd/krMOrPvIsHk8VUu/Idx CVhp6Qxtadp2q8Bf0VYuQFMBrMOjcRmWU1E3U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PlNrN2GhAvRY7IW8hzvOGZWhxEVtG6SWuwKkUSlWRyI=; b=JXIke2+VZgpa0akBqzZuV+XxiR7RoFReU8TiHl77jiErD2nJRKjQoZXNMuldZxnlTc 1/MFNv1EAvnv/MVRt8ZdBYiK99IzauO9G0bm11a20C+yplODvsH+9T/jgEFEcdZswqxm 4+XmWz/hcWIJ4iyzWBxncfutRxZeLObAc/XtsnepsS61qqkMb7ZJMWSJTByUeVBPSgPL VQh5Ho5uLp5kZZhk7101nyRCX/QqCMZy7Orfj7XuFDMqYVHdnoQsSLfYIMU6tm6Fz2D6 VQAJiiK/2YARy3K2RzSh2pVq9mUFUmD9hq5qmUQ+fm8E0zOGgZ1rYuSWi+2kXNz4NHMC M6yA== X-Gm-Message-State: APjAAAU3xqFdekfv1/VxDidhKOf2k1NPmC5ScUolLzyGIOtzRN6j55lp hXlsHB+xeE/gPrjugLirEMckmg== X-Google-Smtp-Source: APXvYqziuBwUwTFwvFITVp9Y42/Pf1aEQFfzH3vqpE2R1SKDE+E1rudpEqbbReFJja9okUlvGnJRkA== X-Received: by 2002:a19:c386:: with SMTP id t128mr2627137lff.7.1573722009265; Thu, 14 Nov 2019 01:00:09 -0800 (PST) Received: from [172.16.11.28] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id o26sm2073916lfi.57.2019.11.14.01.00.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Nov 2019 01:00:08 -0800 (PST) Subject: Re: [PATCH v4 30/47] serial: ucc_uart: factor out soft_uart initialization To: Timur Tabi References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-31-linux@rasmusvillemoes.dk> From: Rasmus Villemoes Message-ID: <73337067-953c-55e2-986a-24116fb10544@rasmusvillemoes.dk> Date: Thu, 14 Nov 2019 10:00:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191114_010011_981127_217C7C4E X-CRM114-Status: GOOD ( 14.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe Leroy , lkml , Li Yang , Scott Wood , linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel , Qiang Zhao Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/11/2019 06.14, Timur Tabi wrote: > On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes > wrote: >> >> - /* >> - * Determine if we need Soft-UART mode >> - */ >> if (of_find_property(np, "soft-uart", NULL)) { >> dev_dbg(&ofdev->dev, "using Soft-UART mode\n"); >> soft_uart = 1; >> + } else { >> + return 0; >> } > > How about: > > if (!of_find_property(np, "soft-uart", NULL)) > return 0; of_property_read_bool() if anything. But I didn't want to do that kind of transformation - just a pure "move this code out and fix the indentation" with the minor edits needed to hook it back up where it came from. > And I think you should be able to get rid of the "soft_uart" variable. Eh, no, it's used in several other places in the driver. I kind of hope gcc is smart enough to see that in the !PPC32 case it is a static, never-assigned-to, never-escapes variable so all the "if (soft_uart)" branches go away, but that's not really very important. Rasmus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel