From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 014BAC433EF for ; Wed, 23 Feb 2022 17:32:35 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 356F140E5A; Wed, 23 Feb 2022 18:32:35 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 2811F40DF6 for ; Wed, 23 Feb 2022 18:32:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645637553; x=1677173553; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=XOZr1rQYAJSh0gf/at9QUvoTnNBe33qcgIuVo+9m79s=; b=Y8RnDAwAvg++J0nc9SphhzdMhnzEW/6Bz9wLpriF54JiQuZZkGujP7Xi eRL5skGjVxA1lp9YYw/ZxIvBO02wlrDLgUz7Y9Xi7L6uoRW0n0HpqWQLW 9hVC3JZIHSBY7hNnKP8lpClj7DRjDs/JTpG1ZhIMbqMz/F5gJW9vPEFeU aI2KkcryCkaYWFgAKVC/R3Agj1+F5Nd57EZA0X8bs9abAamvC/d0woJ/G 7kJ9UUJRmJQZrDJGx7KuUvozB9yvcTfkxmEQIjtXoCa//MbNqYz/pKxvH Y7bSeFCL7/nKR3QRbQYIlr0SAepArQVl5Y/pzN24hdlkVLvRpELeAO+sO w==; X-IronPort-AV: E=McAfee;i="6200,9189,10267"; a="232654547" X-IronPort-AV: E=Sophos;i="5.88,391,1635231600"; d="scan'208";a="232654547" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 09:26:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,391,1635231600"; d="scan'208";a="639393063" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 23 Feb 2022 09:26:06 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 23 Feb 2022 09:26:06 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 23 Feb 2022 09:26:06 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 23 Feb 2022 09:26:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e8ERhqsP4q7d8ZcxWU3NUNrc3Qkkhj63U3RXtQxIzd9Mu1NVyQCQJCa+5pj/Q/lYNV2tF9Btq2mE9t7B+OvW1ZnbD8JfG7e7o/98EeneqknKLFKKudx24Tng66l9zJbnzFLCe4Hsj/IVFongoBu7xVkzTWeeTpn2eys61dxaToXdDJIXVAE6sQoMzm+a6/9N35uZdbpTiRJyTX5j/vwzHDQez4vfIPkQRYGJz8M8STziVdi1Ii1yFrgpjP2JOFESGe+f0QomkVxz30FI6nX2QrAhZSl2w+BYYvvjWCpZRuymumZIRM8WYyWEn2U34WJiOP/TVDka1Dkc1iZJtyzQNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5XyI/om7V9vJ2ax/qANI+/Tb98BCJVYXoxT82dM4THo=; b=Of44uVQxOEyd+U0FRDEzk0TpkcjOT1EZuaKhml8Ou9FpUaKbseE6D4exhjzU07J6qtooubl7o/Siu5p98+VsBxmyJttQk6oHCh3ZMtLjaLC7FzRDldJJTqG10Ar7T5osAzAOon+BxKTIVRbfA5XCmI7gyhg1vlYyAHYTEPLxjh5OZzR3pVwF0ZAYZqMYOBdSypWkjbZrIAT2Nt/A4di1zEXSeZkmpNODSaq+rDpsYnLFJxBvTpP7GMqL/rV/2XJdMUB3aPJ3zOjSU+6Z3X0sNnWNh0o605suiP+fSUUBdIXVuGMMDAXUX1tXYCD9YYJ/oDbcsppyzmAEVK8lwyrENA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM5PR11MB1994.namprd11.prod.outlook.com (2603:10b6:3:e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Wed, 23 Feb 2022 17:26:04 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.027; Wed, 23 Feb 2022 17:26:04 +0000 Message-ID: <733b3d43-00f6-d38b-abef-f0c76e82dbc1@intel.com> Date: Wed, 23 Feb 2022 17:25:58 +0000 Content-Language: en-US To: Michal Krawczyk , CC: , , Dawid Gorecki References: <20220222181146.28882-1-mk@semihalf.com> <20220223121944.24156-1-mk@semihalf.com> <20220223121944.24156-10-mk@semihalf.com> From: Ferruh Yigit Subject: Re: [PATCH v3 09/21] net/ena/base: use optimized memcpy version also on Arm X-User: ferruhy In-Reply-To: <20220223121944.24156-10-mk@semihalf.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0234.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::23) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 32aa3717-d7e3-4c54-49eb-08d9f6f191cf X-MS-TrafficTypeDiagnostic: DM5PR11MB1994:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b7GIu6XDLJdMekFOTUzqY/LPtxM+SAuBf59XkuY1/683srmkryoR0oa+1kaTBPAPAhsII/bPPTF1pw8HgmKVBK0nu+DS3bG1tQENbQZFdk0kYnptZPEt9vXxAD/zI/Gm63NIqciZFEBgLnqW9Qw1uoksA2hd0/gWQW80amS+NnISrmDEzaJdxRTj/yA5OM5NzdubXqxsxzXwuDA4u2CK3yKxq1x+vM/5NACweoRR0fm4yfPFKZXzD4n6VMbGXNGHOd1u6qOLw2JBIkRmId7vvwV8gtEFifTPHW2V+Ke/DjxnjElnR/Rrwf4EV4y4rQ1pV2ngz9OdXV2S6Gzpi3gx62ikZC9mYdqpwZ2R4tnG3gdG/Owun5Vp99+s1BYRkIDZIim5+zz30FptK+TPf+QuQvT5zNXWr+IjA5BmjZw6mb9Mfzpjxfq555SkTgI8krCHK5cCq+T+mHDhmMgJiFQ7HZzgwJY4BuQWH49dAxJ2nhOTWCbKp56AZmprw6II2z8CVNcR7l9Cr8zrxpIw/HqXa5j21raQ1k7SdTZ5MO9dzVqp89diVNQo5HMWSZI6vphXLMb7Q3yO/0dqbcxAFj88QCTqwhVOQTO1ffIOSSguLRJBeSLiKByOh7qCWkIKBT0vpqwjr1exuJ05fq2BpN6etxHzxnnM+rComuPLc9j0DKZkGtJqKyGBcvhRFiVsDUZz3BnFwgi+cViDHRWxMP8kzw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(4326008)(36756003)(38100700002)(44832011)(83380400001)(31686004)(5660300002)(2906002)(8936002)(6486002)(66476007)(316002)(186003)(26005)(6512007)(2616005)(66946007)(66556008)(82960400001)(8676002)(53546011)(6506007)(6666004)(508600001)(31696002)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0N2Mkxaa0lrM2FTdkdwZWs4aVlMMWVHQ2U2UTk3RjIvejJrVW1vL1lCZlVo?= =?utf-8?B?RzNOdEtQQnB4MkJUVno3a0JScWtrdkg1ZlFMOFd2MWRXL1RzcWxmZkxxRG9D?= =?utf-8?B?TStzMm1WYUJqUkNncGYwelZ0OXgvWExkVXk5TGhyVjl2M09INEtKTnZqeDQw?= =?utf-8?B?emk5M2E1VFZCeWNTSVdRRVdBOTdTa0JSd2p4VGlyOW0zLytackZXcUh3dWJh?= =?utf-8?B?YkZXQUtwN25sWHpwMTRLelF0MWFxMVFNZEFxVUdJUWVpZ2I1RUtYRXBtVVRM?= =?utf-8?B?elRmaTZmSWdxZDhoLzY0QnhOM3FOYVRab1RvbzJJSHlmTklrOWhKLzRBSmhx?= =?utf-8?B?bms3ZnVoVWdpNnRZUXBjVFRiT2QvNUR5Mm5HWXlYcDhMMzJCVzVJM2YxUFpz?= =?utf-8?B?eXZWbXFzTXJMUUFyRXlxZXpXR2NvdEJSaDg2cjVEQ24wbHFDK2ZvQUEraU4y?= =?utf-8?B?d3pqU1RmcFQzWE12RzNmS0JJLzRiVWVRUkoyNVE4VnRQWHJ0U1ZGMWtPbUhH?= =?utf-8?B?K0VIMXIzOWNKcnQ5a284eEkyRTVXYjFxVGF2OGplK2p0OHF3RTZSV3ZSMG1Q?= =?utf-8?B?NWp1MENjNmZZdEV3bjJmdUdRc3RzRTQ3TGJEdGdwTi8yNmpqWmdENkN3a1VF?= =?utf-8?B?a0pCTTVwL1VPTnExc3djVExzOGtwbnpsMC9rMWl3c1ZlWWR4bDJFR1I4a3Fr?= =?utf-8?B?L1lENFFBd0xkZk95R2w5a0NFazF1aXhhY1F4Vjk3TEtFSktPelQzMUo5b0R5?= =?utf-8?B?dklMcUdxYzgxS0lERklvOW9jcnVQSzJYVy9URFRzeXkwbE9HNTcrOFRYVit3?= =?utf-8?B?YXpzU1lXR0tWVVhnYkxkcTEvQ0RsWW1Gd21yUkdLOUpEWitSbUpEYURBejF3?= =?utf-8?B?MGMxZUw2YVFnTjBuRTE3WWJsSEpPajZ6RGQrV1grNDNTN3JObFQ5Z0orc3lr?= =?utf-8?B?UG4zRkFSNkZsMHIxdjl5a3RTRUtUSlREWXovT0I2UVl0RmtkaVNqS3d3V2xB?= =?utf-8?B?bmkxeHk3b2tzR0xFYnN3SEVkWWJtZzB3VmpqejNaRWk4L0g3U1NOaFM3bVE0?= =?utf-8?B?eXFHNkM5Yzg4M3JOUkdxU21iUWRYK0FCWUg3dXRjUkVnTGRySnJzdy9oNUNY?= =?utf-8?B?Q2pERWJzUVllN2xnR1JTc3hlWXhPSFErV3pwL3ZlMURETGxwNEtxcU1lWFI2?= =?utf-8?B?RUxYQjFnQkN4MnVGOW1nd0ZLQndsRmcrdmpXUU92bnZXcUhCZytmYU9GTUNO?= =?utf-8?B?ckw2Q25tNWhaNXpXNHdSZWJNRE9QcjdEWDNVNWlIcmR3T0NoampnU3RCSkpE?= =?utf-8?B?bThxWFdQR3lJRXhJaDlDMUJ5REtNRjNUZlVqN290ZmxQMXhaVXFsVFk3alN3?= =?utf-8?B?RkYvUFBIeGs2UGNXWnVLeFY0amk4OVJqK1JiMjZGMFBsMmtsSTdmSmlnR1pt?= =?utf-8?B?dngwYXoxV3p3c1lRanRJYkdRbnRmbi9MUXhmRUNZRHNXV1ZqQllPZm1FWnV3?= =?utf-8?B?MzNza1RDWjZNazZicForVUZtMEtBZ1pyeFkvWVpDQ2U2LzJtVDE4L3JSTjBo?= =?utf-8?B?Qkk5cUMxMC9uMFF0eVM2M05uNkZrL0dFcXJJUFlUMFc5VGc3RDZYU0paUzJ6?= =?utf-8?B?U2VSS1FOOFN5aWVqQW9hMHJBKzl1WmNGKzV4VEN3aXVaRWozRnppcmRuZDlS?= =?utf-8?B?WjE2ZUhqbk1wbjFSdmN4Y2lUVG8wL0hoaCswRWgxR3ZxWVdURXNxNkhsRkh0?= =?utf-8?B?c3dXcW5RNGdKZkM1NlY0OFN1czdOV1RIelA4RVNSVG4rY00vSFg4dUVydXRx?= =?utf-8?B?d0hFWXBBSm90MkhWcEE4ZGhkeTlkM21RWjlJelZHelkxOWVIQzlYNU1yR2Nu?= =?utf-8?B?Q24yRWszZEs4anpqaWl1OHpvamNuYTRMSEVmNHNhNE5zRWZab0wvUEZDdER2?= =?utf-8?B?YTBSZ3oybXNZRXRvQjdsWVQzQTZKK3hMZ3RqM3BlZkhES0RPQjBUc3RoNnBK?= =?utf-8?B?bXA1aFlwZURNaHhubHdXYTU0d3pXUDQwOGVrRmVCY2N5NDFDQ2ZReTZPY1ht?= =?utf-8?B?ekdiT0JsbHdHVmF0QTUvdHd4UFRTajkrWWpoWktjWEQxWGVadnBLU3NXUjM3?= =?utf-8?B?ZFMxVURuOXZTRW5aRS92NXlrbW83cXplY1pwNlBjRGZDU0VLckZ6aFpMcWZB?= =?utf-8?Q?GePG81qqmPsHRIZ+uXWNtFs=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 32aa3717-d7e3-4c54-49eb-08d9f6f191cf X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 17:26:04.5854 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E8RjYjn3iBXWCgZ9vOUXpNJaLVP1LWrYiLrAMkNxkto/LoXoVjCEMXCAMq7laPfdYnnyldonn0SdKU+ZkNzM5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1994 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/23/2022 12:19 PM, Michal Krawczyk wrote: > As the default behavior for arm64 is to alias rte_memcpy as memcpy, ENA > cannot redefine memcpy as rte_memcpy as it would cause nested > declaration. > > To make it possible to use optimized memcpy in the ena_com layer on Arm, Out of curiosity, do you have any performance measurements for the optimized memcpy usage? > the driver now redefines memcpy when it is beneficial: > * For arm64 only when the flag RTE_ARCH_ARM64_MEMCPY was defined > * For arm only when the flag RTE_ARCH_ARM_NEON_MEMCPY was defined > > Signed-off-by: Michal Krawczyk > Reviewed-by: Dawid Gorecki > Reviewed-by: Shai Brandes > --- > doc/guides/rel_notes/release_22_03.rst | 1 + > drivers/net/ena/base/ena_plat_dpdk.h | 7 +++++-- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/doc/guides/rel_notes/release_22_03.rst b/doc/guides/rel_notes/release_22_03.rst > index c8e38d4c70..92490afd60 100644 > --- a/doc/guides/rel_notes/release_22_03.rst > +++ b/doc/guides/rel_notes/release_22_03.rst > @@ -112,6 +112,7 @@ New Features > * Added new checksum related xstats: ``l3_csum_bad``, ``l4_csum_bad`` and > ``l4_csum_good``. > * Added support for the link status configuration. > + * Added optimized memcpy support for the ARM platforms. > > * **Updated Cisco enic driver.** > > diff --git a/drivers/net/ena/base/ena_plat_dpdk.h b/drivers/net/ena/base/ena_plat_dpdk.h > index 4e7f52881a..41db883c63 100644 > --- a/drivers/net/ena/base/ena_plat_dpdk.h > +++ b/drivers/net/ena/base/ena_plat_dpdk.h > @@ -66,8 +66,11 @@ typedef uint64_t dma_addr_t; > #define ENA_UDELAY(x) rte_delay_us_block(x) > > #define ENA_TOUCH(x) ((void)(x)) > -/* Avoid nested declaration on arm64, as it may define rte_memcpy as memcpy. */ > -#if defined(RTE_ARCH_X86) > +/* Redefine memcpy with caution: rte_memcpy can be simply aliased to memcpy, so > + * make the redefinition only if it's safe (and beneficial) to do so. > + */ > +#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64_MEMCPY) || \ > + defined(RTE_ARCH_ARM_NEON_MEMCPY) > #undef memcpy > #define memcpy rte_memcpy > #endif I can see there is 'ena_plat_dpdk.h', which seems like an osdep header, it is possible to use 'ena_memcpy' in the code and in the 'ena_plat_dpdk.h' define it as: #define ena_memcpy rte_memcpy This is just for your information if it helps, usage is up to you.