All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "B. Niedermayr" <benedikt.niedermayr@siemens.com>,
	devicetree@vger.kernel.org, linux-omap@vger.kernel.org
Cc: robh+dt@kernel.org, rogerq@kernel.org, tony@atomide.com
Subject: Re: [PATCH 1/2] memory: omap-gpmc: wait pin additions
Date: Wed, 26 Oct 2022 12:47:50 -0400	[thread overview]
Message-ID: <733bebc5-f632-aa53-0c91-b858fa87848a@linaro.org> (raw)
In-Reply-To: <20221021081612.591613-2-benedikt.niedermayr@siemens.com>

On 21/10/2022 04:16, B. Niedermayr wrote:
> From: Benedikt Niedermayr <benedikt.niedermayr@siemens.com>
> 
> This patch introduces support for setting the wait-pin polarity as well
> as using the same wait-pin for different CS regions.
> 
> The waitpin polarity can be configured via the WAITPIN<X>POLARITY bits
> in the GPMC_CONFIG register. This is currently not supported by the
> driver. This patch adds support for setting the required register bits
> with the "ti,wait-pin-polarity" dt-property.
> 
> The wait-pin can also be shared between different CS regions for special
> usecases. Therefore GPMC must keep track of wait-pin allocations, so it
> knows that either GPMC itself or another driver has the ownership.
> 
> Signed-off-by: Benedikt Niedermayr <benedikt.niedermayr@siemens.com>

This is v8, not v1. Please mark your patches appropriately.

Roger,

Any comments from you? You were reviewing previous sets, so does it look
good now?

Best regards,
Krzysztof


  reply	other threads:[~2022-10-26 16:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21  8:16 [PATCH v8 0/2] gpmc wait pin additions B. Niedermayr
2022-10-21  8:16 ` [PATCH 1/2] memory: omap-gpmc: " B. Niedermayr
2022-10-26 16:47   ` Krzysztof Kozlowski [this message]
2022-10-21  8:16 ` [PATCH 2/2] dt-bindings: memory-controllers: gpmc-child: add wait-pin polarity B. Niedermayr
2022-10-21 14:52   ` Rob Herring
2022-10-28 11:56 ` [PATCH v8 0/2] gpmc wait pin additions Roger Quadros
2022-10-28 12:53   ` Krzysztof Kozlowski
2022-10-29 18:25 ` Roger Quadros
2022-10-29 18:26 ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=733bebc5-f632-aa53-0c91-b858fa87848a@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=benedikt.niedermayr@siemens.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.