From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7BADC56201 for ; Thu, 19 Nov 2020 16:47:02 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 439D222227 for ; Thu, 19 Nov 2020 16:47:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="YPCsmYEM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 439D222227 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.31186.61470 (Exim 4.92) (envelope-from ) id 1kfn59-00055l-61; Thu, 19 Nov 2020 16:46:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 31186.61470; Thu, 19 Nov 2020 16:46:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kfn59-00055e-2o; Thu, 19 Nov 2020 16:46:51 +0000 Received: by outflank-mailman (input) for mailman id 31186; Thu, 19 Nov 2020 16:46:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kfn57-00055V-E7 for xen-devel@lists.xenproject.org; Thu, 19 Nov 2020 16:46:49 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 47fb2237-f0d5-4969-93ed-b4ec2bd88bdc; Thu, 19 Nov 2020 16:46:48 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BDFAFAC46; Thu, 19 Nov 2020 16:46:47 +0000 (UTC) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kfn57-00055V-E7 for xen-devel@lists.xenproject.org; Thu, 19 Nov 2020 16:46:49 +0000 X-Inumbo-ID: 47fb2237-f0d5-4969-93ed-b4ec2bd88bdc Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 47fb2237-f0d5-4969-93ed-b4ec2bd88bdc; Thu, 19 Nov 2020 16:46:48 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1605804407; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Lp8pf/Gv50jjKY3pqNKsNI1PVOJp90+DlP/KkJvffo=; b=YPCsmYEMxm+s06Ov2uge0eDlS7015Z8QYKZAkG7NVAG3jFSbdW26XjEQU0lc9j0LNyYMn8 N3onIbcvWiT0zR+sqb8RyGFU4zJUnD4hSCyJ8c63twOUwB/Vz8bDVNoQ1vNurx0I1TzLZU oT9AUS7n/G3LRoEY1vKzglXnA7HdQY4= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BDFAFAC46; Thu, 19 Nov 2020 16:46:47 +0000 (UTC) Subject: Re: [PATCH 03/10] viridian: introduce a per-cpu hypercall_vpmask and accessor functions... To: "Durrant, Paul" , "paul@xen.org" Cc: 'Wei Liu' , 'Andrew Cooper' , =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= , "xen-devel@lists.xenproject.org" References: <20201111200721.30551-1-paul@xen.org> <20201111200721.30551-4-paul@xen.org> <01c7747e-70d0-e32b-45a6-afc1688c1741@suse.com> <00c901d6be8d$6d7a5c10$486f1430$@xen.org> <0ec90042-cb19-320e-1676-409b68b73a51@suse.com> From: Jan Beulich Message-ID: <73501e7c-9363-1fc8-9262-c4b3d9cc6347@suse.com> Date: Thu, 19 Nov 2020 17:46:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 19.11.2020 17:44, Durrant, Paul wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: 19 November 2020 16:41 >> To: paul@xen.org >> Cc: Durrant, Paul ; 'Wei Liu' ; 'Andrew Cooper' >> ; 'Roger Pau Monné' ; xen-devel@lists.xenproject.org >> Subject: RE: [EXTERNAL] [PATCH 03/10] viridian: introduce a per-cpu hypercall_vpmask and accessor >> functions... >> >> CAUTION: This email originated from outside of the organization. Do not click links or open >> attachments unless you can confirm the sender and know the content is safe. >> >> >> >> On 19.11.2020 17:02, Paul Durrant wrote: >>>> From: Jan Beulich >>> Sent: 12 November 2020 08:46 >>>> >>>> On 11.11.2020 21:07, Paul Durrant wrote: >>>>> --- a/xen/arch/x86/hvm/viridian/viridian.c >>>>> +++ b/xen/arch/x86/hvm/viridian/viridian.c >>>>> @@ -507,15 +507,41 @@ void viridian_domain_deinit(struct domain *d) >>>>> XFREE(d->arch.hvm.viridian); >>>>> } >>>>> >>>>> +struct hypercall_vpmask { >>>>> + DECLARE_BITMAP(mask, HVM_MAX_VCPUS); >>>>> +}; >>>>> + >>>>> +static DEFINE_PER_CPU(struct hypercall_vpmask, hypercall_vpmask); >>>>> + >>>>> +static void vpmask_empty(struct hypercall_vpmask *vpmask) >>>> >>>> const? >>> >>> Yes, I suppose that's ook for all these since the outer struct is >>> not changing... It's a bit misleading though. >> >> I'd be curious to learn about that "misleading" aspect. >> > > Because the function is modifying (zero-ing) the bitmap... so implying > the mask is const is measleading. Oh, I was mislead by the name then; should have looked at the return type (which I was implying to be bool, when it's void). Please disregard my request(s) in such case(s). Jan