From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6DCFC433EF for ; Mon, 16 May 2022 23:44:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C93D7841F3; Tue, 17 May 2022 01:44:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="XfBXdG0s"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 79F9E8418D; Tue, 17 May 2022 01:44:22 +0200 (CEST) Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3751584092 for ; Tue, 17 May 2022 01:44:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20220516234414epoutp02b50e297e224a1feb8d361530452fa674~vuoGn6gJT0705907059epoutp02o for ; Mon, 16 May 2022 23:44:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20220516234414epoutp02b50e297e224a1feb8d361530452fa674~vuoGn6gJT0705907059epoutp02o DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1652744654; bh=gdpix4CMzTv/eSCXbIZrDucfL8p9Mhp4tBca9cDkbIk=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=XfBXdG0sRkuRkI93Q6yh05MAWawh/lNBLNGi7Huq2KefrKDlJrVKABamxYctVIuDK wkQHZSf+AyXCAGb/9cwtkwR3SJfKYSi8CzrY2lv2NPVWzxNQBNwvYxtW9bEyoFb1CE txHlYkCZ9h35C1eoNGLjLFlU5I/w7NPIWPO++GSY= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20220516234414epcas1p3e372ecfeaefac3b6cd29ef49911dbf33~vuoGYUq_o0045600456epcas1p3D; Mon, 16 May 2022 23:44:13 +0000 (GMT) Received: from epsmges1p2.samsung.com (unknown [182.195.38.235]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4L2G702KyKz4x9QR; Mon, 16 May 2022 23:44:12 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p2.samsung.com (Symantec Messaging Gateway) with SMTP id F7.7E.09785.AC1E2826; Tue, 17 May 2022 08:44:10 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20220516234410epcas1p3c3a59a85709baad8bb4c9655447fb04d~vuoDEui0Z2602926029epcas1p3O; Mon, 16 May 2022 23:44:10 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20220516234410epsmtrp1091e6ca91644fa6b4796d302d83d3877~vuoDD-1-o1752717527epsmtrp1P; Mon, 16 May 2022 23:44:10 +0000 (GMT) X-AuditID: b6c32a36-c9dff70000002639-f3-6282e1caae05 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 35.8A.11276.AC1E2826; Tue, 17 May 2022 08:44:10 +0900 (KST) Received: from [10.113.113.235] (unknown [10.113.113.235]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20220516234410epsmtip126972817b5924d3fed01798201f785e3~vuoCv25mF2745527455epsmtip1d; Mon, 16 May 2022 23:44:10 +0000 (GMT) Message-ID: <73738c67-0910-0966-4f2f-c28476c42d14@samsung.com> Date: Tue, 17 May 2022 08:44:10 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/2] pmic: pca9450: add DM_I2C dependencies in Kconfig Content-Language: en-US To: Rasmus Villemoes , u-boot@lists.denx.de Cc: Marek Vasut , Fabio Estevam , Peng Fan From: Jaehoon Chung In-Reply-To: <20220503085807.904742-1-rasmus.villemoes@prevas.dk> Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmk+LIzCtJLcpLzFFi42LZdlhTT/fUw6Ykgw+njCzmL1jMZvGmrZHR 4seqL6wWN187WLzd28nuwOoxb9YJFo+zd3Ywemx8t4PJY8bsN4wBLFHZNhmpiSmpRQqpecn5 KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlAe5UUyhJzSoFCAYnFxUr6djZF +aUlqQoZ+cUltkqpBSk5BaYFesWJucWleel6eaklVoYGBkamQIUJ2RmvJk5gLrjEXXHkyEX2 BsbNnF2MnBwSAiYSr6ffZu5i5OIQEtjBKHGmYysrhPOJUaJh0RIWCOcbo8TuL+1MMC3zbl9g gkjsZZS4snEKO4TznlFi172jbCBVvAJ2Eltn3gezWQRUJc6svwgVF5Q4OfMJC4gtKhAhMW3W GbC4sICXxJEjU1hBbGYBcYlbT+aDbRMRcJd4ffgCVDxB4lDvJnYQm01AR2L7t+NgNZwCjhKt 306wQNTIS2x/OwfsIQmBn+wSb878YIU420Xi9NPjbBC2sMSr41vYIWwpiZf9bewQDc2MEkuX HGSFcHoYJf41XIfqMJbYv3Qy0DoOoBWaEut36UOEFSV2/p7LCLGZT+Ld1x5WkBIJAV6JjjYh iBIViUuvXzLB7Lr75D/UPR4Sd89MYZ7AqDgLKVxmIfl/FpJ/ZiEsXsDIsopRLLWgODc9tdiw wAge38n5uZsYwalSy2wH46S3H/QOMTJxMB5ilOBgVhLhNahoSBLiTUmsrEotyo8vKs1JLT7E aAqMnYnMUqLJ+cBknVcSb2hiaWBiZmRsYmFoZqgkzrtq2ulEIYH0xJLU7NTUgtQimD4mDk6p BqaQwB6R36yvQrYwswlkP2WTCH+ju+t7mZmmxYGGBzlbJ0/2lpgfu0O8g0m83GXL0Y9rRM3f fpPM3v+/fh+nUkRTYPjFyN1FGxlfTbwj/r0tX6qyMu8k06SobKOLf3b80vV/+9Fc3Gd5oQb/ d60nLBskcnM/RvQncE7XfzVpdeTtBcXbP1dvXbzuBNcjATWP2c9n8yROdtNYLbPq9fwF+5SM 71270Zp/baapdmeuvKj51Fq32/2fee46bpL038H1QuDuroZDFXJi3FZ30lgCIuNK5n0PyO8z +fnBtOiAhFHRtRDDZXl57zk/q4pfa/lcdXJWfdYa84IdAUqtc6fEveSZ9MFm89WbG9UOLrnC fVuJpTgj0VCLuag4EQDaHrzBHgQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsWy7bCSnO6ph01JBu/uSFrMX7CYzeJNWyOj xY9VX1gtbr52sHi7t5PdgdVj3qwTLB5n7+xg9Nj4bgeTx4zZbxgDWKK4bFJSczLLUov07RK4 Ml5NnMBccIm74siRi+wNjJs5uxg5OSQETCTm3b7A1MXIxSEksJtRYtHpP2wQCSmJz0+nAtkc QLawxOHDxRA1bxklei5dYwWp4RWwk9g68z5YPYuAqsSZ9RfZIOKCEidnPmEBsUUFIiQe7D4L Vi8s4CVx5MgUMJtZQFzi1pP5TCC2iIC7xOvDF6DiCRLPFrUxQiybwihx59BSdpAEm4COxPZv x8EaOAUcJVq/nWABOY5ZQF1i/TwhiF55ie1v5zBPYBSaheSMWUjWzULomIWkYwEjyypGydSC 4tz03GLDAsO81HK94sTc4tK8dL3k/NxNjOCo0NLcwbh91Qe9Q4xMHIyHGCU4mJVEeA0qGpKE eFMSK6tSi/Lji0pzUosPMUpzsCiJ817oOhkvJJCeWJKanZpakFoEk2Xi4JRqYLqqFKmUOzOX I2vNQ4br8xXvqa0L2/2Y58CJP/vWvTh4JaXJf4nLnU2bpzc8upacyX0zbteEL5d9Qy7fkEnm u/jVWfHJp2UVK5bVtebFH9EpvtpbrTkl62t54pEet995n04YcRy9c7SQddry6IvvLqV9NDA6 /vD7M668XcZeniK111sKAqOaF7ypOh9f5zfXeEKNcMbUnL6T1zhKngnHKHqnf2eo2ZQgIZ+w YnrqP2/hTIm7z+3OtFlGzeualLX/W9830d0HKw66vF+9yS+EZxm7v8ayxJvmNcyr7dUetujH yrNOPfY7WJFh8hZL57ACpkn3NRtOfZp3duLvCxbHmz7fMs/xZ7TI+b965pKu+BdKLMUZiYZa zEXFiQDRWUz7+QIAAA== X-CMS-MailID: 20220516234410epcas1p3c3a59a85709baad8bb4c9655447fb04d X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220503085824epcas1p2f63014c42ef5a15cfba9eb8930a5a99c References: <20220503085807.904742-1-rasmus.villemoes@prevas.dk> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 5/3/22 17:58, Rasmus Villemoes wrote: > The pca9450 driver uses dm_i2c_{read,write}, which > are (unsurprisingly) only available with DM_I2C. Make sure one can't > create an unbuildable .config by adding proper dependencies. > > While here, append "in SPL" to the prompt for the SPL_ variant so it > doesn't read the same as the one for the non-SPL_ variant. > > Signed-off-by: Rasmus Villemoes Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/power/pmic/Kconfig | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/power/pmic/Kconfig b/drivers/power/pmic/Kconfig > index 953c92e212..6c534aead7 100644 > --- a/drivers/power/pmic/Kconfig > +++ b/drivers/power/pmic/Kconfig > @@ -158,13 +158,15 @@ config SPL_DM_PMIC_MP5416 > > config DM_PMIC_PCA9450 > bool "Enable Driver Model for PMIC PCA9450" > + depends on DM_I2C > help > This config enables implementation of driver-model pmic uclass features > for PMIC PCA9450. The driver implements read/write operations. > > config SPL_DM_PMIC_PCA9450 > - bool "Enable Driver Model for PMIC PCA9450" > + bool "Enable Driver Model for PMIC PCA9450 in SPL" > depends on SPL_DM_PMIC > + depends on SPL_DM_I2C > help > This config enables implementation of driver-model pmic uclass features > for PMIC PCA9450 in SPL. The driver implements read/write operations.