Re: [PATCH v3 3/4] arm: mvebu: dts: uDPU: fix non-working networking

[Stefan Roese <sr@denx.de>]

On 3/24/22 10:57, Robert Marko wrote:
> uDPU is a bit of a specific device in that it does not have any copper
> ports nor any ethernet PHY-s but 2 SFP ports.
> 
> This is an issue since MVNETA requires a PHY phandle or a fixed-link to
> be defined under its node.
> Since U-boot has no SFP support this is reasonable in order to know how
> to configure the MAC.
> 
> However this also means that networking does not work on uDPU at all
> currently, and fails with:
> 
> uDPU>> dhcp
> Could not get PHY for neta@30000: addr 0
> phy_connect failed
> Could not get PHY for neta@40000: addr 1
> phy_connect failed
> 
> So, to provide working networking using only SFP-s let add the fixed-link
> at 1G which is much more common than 2.5G SFP-s as well as disable the
> TX_DISABLE pins like done on Armada 7040 and 8040 platforms.
> 
> Since uDPU is not using any of the GPIO-s on the SB controller for any
> purpose other than GPIO, a call to the pinctrl must be made in order for
> it to get probed and thus register the SB GPIO bank, otherwise SB GPIO-s
> are not registered at all.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>

Applied to u-boot-marvell/master

Thanks,
Stefan

> ---
> Changes in v2:
> * Drop the custom SFP TX GPIO properties as they are parsed from the SFP
> nodes now
> 
>   arch/arm/dts/armada-3720-uDPU-u-boot.dtsi | 24 +++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
> 
> diff --git a/arch/arm/dts/armada-3720-uDPU-u-boot.dtsi b/arch/arm/dts/armada-3720-uDPU-u-boot.dtsi
> index cf8ae4412b..47d87d4bd8 100644
> --- a/arch/arm/dts/armada-3720-uDPU-u-boot.dtsi
> +++ b/arch/arm/dts/armada-3720-uDPU-u-boot.dtsi
> @@ -31,3 +31,27 @@
>   &sdhci0 {
>   	u-boot,dm-pre-reloc;
>   };
> +
> +&pinctrl_sb {
> +	sfp_pin: sfp-pin {
> +		groups = "pcie1_clkreq";
> +		function = "gpio";
> +	};
> +};
> +
> +&eth0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&sfp_pin>;
> +
> +	fixed-link {
> +		speed = <1000>;
> +		full-duplex;
> +	};
> +};
> +
> +&eth1 {
> +	fixed-link {
> +		speed = <1000>;
> +		full-duplex;
> +	};
> +};

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de