From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54268 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527AbdCHIrN (ORCPT ); Wed, 8 Mar 2017 03:47:13 -0500 Subject: Re: [PATCH v2 2/4] brcmfmac: p2p and normal ap access are not always possible at the same time To: Arend Van Spriel , Franky Lin , Hante Meuleman , Kalle Valo References: <20170227214539.16422-1-hdegoede@redhat.com> <20170227214539.16422-2-hdegoede@redhat.com> <33689f32-1bf8-98f8-df65-278de097e435@broadcom.com> Cc: Takashi Iwai , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com From: Hans de Goede Message-ID: <738d049d-4e90-8a5d-e5c0-d037085a064c@redhat.com> (sfid-20170308_094811_032600_463967F3) Date: Wed, 8 Mar 2017 09:24:05 +0100 MIME-Version: 1.0 In-Reply-To: <33689f32-1bf8-98f8-df65-278de097e435@broadcom.com> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi, On 07-03-17 11:03, Arend Van Spriel wrote: > > > On 27-2-2017 22:45, Hans de Goede wrote: >> The firmware responding with -EBUSY when trying to add an extra virtual-if >> is a normal thing, do not print an error for this. > > This may be something we need to look into. It seems to me the interface > combinations needs to be fixed so we do not try to provision firmware. > Can you explain the scenario here? I'm not doing anything special just connecting to my isp provided accesspoint using NetworkManager. Regards, Hans > > Regards, > Arend > >> Signed-off-by: Hans de Goede >> --- >> .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 14 ++++++++++---- >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 5 ++++- >> 2 files changed, 14 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c >> index 7ffc4ab..c54e8b4 100644 >> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c >> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c >> @@ -688,11 +688,17 @@ static struct wireless_dev *brcmf_cfg80211_add_iface(struct wiphy *wiphy, >> return ERR_PTR(-EINVAL); >> } >> >> - if (IS_ERR(wdev)) >> - brcmf_err("add iface %s type %d failed: err=%d\n", >> - name, type, (int)PTR_ERR(wdev)); >> - else >> + if (IS_ERR(wdev)) { >> + err = PTR_ERR(wdev); >> + if (err != -EBUSY) >> + brcmf_err("add iface %s type %d failed: err=%d\n", >> + name, type, err); >> + else >> + brcmf_dbg(INFO, "add iface %s type %d failed: err=%d\n", >> + name, type, err); >> + } else { >> brcmf_cfg80211_update_proto_addr_mode(wdev); >> + } >> >> return wdev; >> } >> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c >> index de19c7c..b5df0a0 100644 >> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c >> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c >> @@ -2090,7 +2090,10 @@ static struct wireless_dev *brcmf_p2p_create_p2pdev(struct brcmf_p2p_info *p2p, >> /* Initialize P2P Discovery in the firmware */ >> err = brcmf_fil_iovar_int_set(pri_ifp, "p2p_disc", 1); >> if (err < 0) { >> - brcmf_err("set p2p_disc error\n"); >> + if (err != -EBUSY) >> + brcmf_err("set p2p_disc error\n"); >> + else >> + brcmf_dbg(INFO, "set p2p_disc error\n"); >> brcmf_fweh_p2pdev_setup(pri_ifp, false); >> brcmf_cfg80211_arm_vif_event(p2p->cfg, NULL); >> goto fail; >>