All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 1/4] brcmfmac: Do not print the firmware version as an error
@ 2017-02-27 21:45 Hans de Goede
  2017-02-27 21:45 ` [PATCH v2 2/4] brcmfmac: p2p and normal ap access are not always possible at the same time Hans de Goede
                   ` (4 more replies)
  0 siblings, 5 replies; 22+ messages in thread
From: Hans de Goede @ 2017-02-27 21:45 UTC (permalink / raw)
  To: Arend van Spriel, Franky Lin, Hante Meuleman, Kalle Valo
  Cc: Hans de Goede, Takashi Iwai, linux-wireless, brcm80211-dev-list.pdl

Using pr_err for things which are not errors is a bad idea. E.g. it
will cause the plymouth bootsplash screen to drop back to the text
console so that the user can see the error, which is not what we
normally want to happen.

Instead add a new brcmf_info macro and use that.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
Changes in v2:
-Fix brcm_err typo (should be brcmf_err) in CONFIG_BRCM_TRACING case
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 2 +-
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h  | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
index 3e15d64..6d565f1 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
@@ -161,7 +161,7 @@ int brcmf_c_preinit_dcmds(struct brcmf_if *ifp)
 	strsep(&ptr, "\n");
 
 	/* Print fw version info */
-	brcmf_err("Firmware version = %s\n", buf);
+	brcmf_info("Firmware version = %s\n", buf);
 
 	/* locate firmware version number for ethtool */
 	ptr = strrchr(buf, ' ') + 1;
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h
index 6687812..605f260 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h
@@ -59,11 +59,14 @@
 			pr_err("%s: " fmt, __func__, ##__VA_ARGS__);	\
 	} while (0)
 #endif
+#define brcmf_info(fmt, ...)	pr_info("%s: " fmt, __func__, ##__VA_ARGS__)
 #else
 __printf(2, 3)
 void __brcmf_err(const char *func, const char *fmt, ...);
 #define brcmf_err(fmt, ...) \
 	__brcmf_err(__func__, fmt, ##__VA_ARGS__)
+/* For tracing purposes treat info messages as errors */
+#define brcmf_info brcmf_err
 #endif
 
 #if defined(DEBUG) || defined(CONFIG_BRCM_TRACING)
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2017-03-16 11:51 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-27 21:45 [PATCH v2 1/4] brcmfmac: Do not print the firmware version as an error Hans de Goede
2017-02-27 21:45 ` [PATCH v2 2/4] brcmfmac: p2p and normal ap access are not always possible at the same time Hans de Goede
2017-03-07 10:03   ` Arend Van Spriel
2017-03-08  8:24     ` Hans de Goede
2017-03-08  9:26       ` Arend Van Spriel
2017-03-08 10:15         ` Arend Van Spriel
2017-03-08 11:16           ` Hans de Goede
2017-03-10  8:08             ` Hans de Goede
2017-03-10  9:35               ` Arend Van Spriel
2017-03-16 11:51                 ` Hans de Goede
2017-02-27 21:45 ` [PATCH v2 3/4] brcmfmac: Do not complain about country code "00" Hans de Goede
2017-03-07 10:04   ` Arend Van Spriel
2017-02-27 21:45 ` [PATCH v2 4/4] brcmfmac: Handle status == BRCMF_E_STATUS_ABORT in cfg80211_escan_handler Hans de Goede
2017-03-07 10:06   ` Arend Van Spriel
2017-03-07  9:59 ` [PATCH v2 1/4] brcmfmac: Do not print the firmware version as an error Arend Van Spriel
2017-03-08  8:23   ` Hans de Goede
2017-03-08  9:28     ` Arend Van Spriel
2017-03-08  9:57       ` Kalle Valo
2017-03-08 10:08         ` Hans de Goede
2017-03-08 10:13           ` Arend Van Spriel
2017-03-08 10:14           ` Kalle Valo
2017-03-07 14:30 ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.