From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2322C433E0 for ; Tue, 29 Dec 2020 03:18:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CA5A20708 for ; Tue, 29 Dec 2020 03:18:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727369AbgL2DSC (ORCPT ); Mon, 28 Dec 2020 22:18:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726014AbgL2DSB (ORCPT ); Mon, 28 Dec 2020 22:18:01 -0500 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B212CC0613D6; Mon, 28 Dec 2020 19:17:21 -0800 (PST) Received: by mail-pl1-x62d.google.com with SMTP id y8so6575986plp.8; Mon, 28 Dec 2020 19:17:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HpIe+WD+dLX+XhZ/PLItxMChRoXXp5y6JT3dnQCX16I=; b=eZt0aT1suyUKVjn7E9aNZU/+zwAc+fQNVjM15EAAm6otBIr9ge7/7xGvPMotHiuuCX uSgTchOa5XgZInl9Qc27N0dY2cxs2Cf6gDDER9T0pDBajIGazR+rElLtUnS7S65r5xk2 GRZ4kLHlJIfJiFKVxkLzxIWwffgRBditb4Ad9cKUv/6TTo9fNNTlkuunDp0jTELRi+Qz +mPyzopRoMImqGpDlihBucl4PmDjqpsetnjREy0OE4AW6nf37WGHCW+BzuPT978pN8Zj LL0IlGF8XXqqxd54Vwq53ZddMaGU6krlgy/nJ3PzMDK4EtMZu1yMoB/bRXvOV5+qLKIc XhsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HpIe+WD+dLX+XhZ/PLItxMChRoXXp5y6JT3dnQCX16I=; b=O73/RUwf4fCl6IAU582XjxyKxSmsx6m6UM1XgPP8wu7xRsmqgcM3A7eLhXUQ9SwqEg SJCsk8hpkyVtykSSOfw/7hcIWwPdQUyGemESqMLG4MIRjL95rcQyG2P94wTNZGGCPLZ4 Um2RkS8gryN3t58GoRkGBCfnx05GrqRtCGY1W4T6JoraR2u2tMnkaQeFpI0dKQPVUzKh B4Kk24vAzMsQ90FolEXDCosiQDfExN685U2e89lmKVtXc12KA9S3f7o3dPZ0dIb1hddp XPm1Rg/nKTIAT9TCtDYIgrUmVyPuntvGVJfR0rtHpyTretGs5oVtwWBQfaNLr6eINF+Q OJeg== X-Gm-Message-State: AOAM533SW2qNG2XM3hxt1i7SCvnUIsZ0uIInAkfHq/BUq3v7hy7VM5k2 9aD87geIpXz9CoRjbHi2nHdwFwreXF4= X-Google-Smtp-Source: ABdhPJyzf8c691eftcVFlQ7m/GD11ZtJjJhSlp6erG/Lnp+d4loQrwgH0aZprws8tpF58+ejtI5i0w== X-Received: by 2002:a17:90a:cb8d:: with SMTP id a13mr1950080pju.155.1609211840895; Mon, 28 Dec 2020 19:17:20 -0800 (PST) Received: from [10.230.29.27] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id z23sm37105562pfn.202.2020.12.28.19.17.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Dec 2020 19:17:19 -0800 (PST) Subject: Re: [PATCH net-next v2 6/6] bcm63xx_enet: improve rx loop To: Sieng Piaw Liew , Florian Fainelli Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20201224142421.32350-1-liew.s.piaw@gmail.com> <20201224142421.32350-7-liew.s.piaw@gmail.com> From: Florian Fainelli Message-ID: <7393e13a-5735-19a5-71f7-b370bdb9b39b@gmail.com> Date: Mon, 28 Dec 2020 19:17:12 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201224142421.32350-7-liew.s.piaw@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/24/2020 6:24 AM, Sieng Piaw Liew wrote: > Use existing rx processed count to track against budget, thereby making > budget decrement operation redundant. > > rx_desc_count can be calculated outside the rx loop, making the loop a > bit smaller. > > Signed-off-by: Sieng Piaw Liew Acked-by: Florian Fainelli -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77246C433E0 for ; Tue, 29 Dec 2020 03:18:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3333420725 for ; Tue, 29 Dec 2020 03:18:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3333420725 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XGDxHbD/CqpCwIy6VT/DsgrBEYWAis5RluJYIXR8pAo=; b=BBZlWCUeTUWXehKcuNvHVsnbo cPmLH4QWpX7X1XM6fYKtaUwrBtR797dw7W+Osv8ygAVBlCp1FMXmeAwnJV8cKeiowzhqu33pfhG3O w705Me2jaqeT3bpXK8k/kw5wyWrksHKlqKHN26ZgqjvzknzyWQ/k2+vT4EotDKD/WW5f/HJts57MS rQfhzqABcJtF2dYLr7VR3J3WQOxPDNycEFXZ/bu5sESjf1vcX93UnFDOtM2v+ODVs5Skc/Ao2LaWF NijzMUKI0VL737uyeiM34gk2Mpl+2GY2nf+E4ilieK6XtXOEUt1i/EvTZPS8tQ7JH+qxj3AHAHKgE SCBYyU9sA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ku5Vk-0004mi-Mh; Tue, 29 Dec 2020 03:17:24 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ku5Vi-0004lr-Vq for linux-arm-kernel@lists.infradead.org; Tue, 29 Dec 2020 03:17:23 +0000 Received: by mail-pj1-x1032.google.com with SMTP id v1so766206pjr.2 for ; Mon, 28 Dec 2020 19:17:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HpIe+WD+dLX+XhZ/PLItxMChRoXXp5y6JT3dnQCX16I=; b=eZt0aT1suyUKVjn7E9aNZU/+zwAc+fQNVjM15EAAm6otBIr9ge7/7xGvPMotHiuuCX uSgTchOa5XgZInl9Qc27N0dY2cxs2Cf6gDDER9T0pDBajIGazR+rElLtUnS7S65r5xk2 GRZ4kLHlJIfJiFKVxkLzxIWwffgRBditb4Ad9cKUv/6TTo9fNNTlkuunDp0jTELRi+Qz +mPyzopRoMImqGpDlihBucl4PmDjqpsetnjREy0OE4AW6nf37WGHCW+BzuPT978pN8Zj LL0IlGF8XXqqxd54Vwq53ZddMaGU6krlgy/nJ3PzMDK4EtMZu1yMoB/bRXvOV5+qLKIc XhsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HpIe+WD+dLX+XhZ/PLItxMChRoXXp5y6JT3dnQCX16I=; b=RgBYk2rX3e075uRCEptAjoSVKExiKtf0ZNapWYa5/PXeXV06vz+VuEHOvfApjEUBCt pk0VtkumlikE2S99ZIMMor645vuzTjOe6mSTWbq2GmLX/Mt6h9tL4vypKmqN3JI5Rsl5 g+dVgBBmywsSadju/l9RnnzffAfTGlHiKauK7Ng5K5H07WiINZ1N4SfFU7ZZiVSnYSWF 9WQXsWaxWrkYMid6H+ue+hM/VQGwkaB4BoBTdl/GZDFRSqrNbihtgpn11LW6vaqaVPd3 NPPsKetX8eW4MzFOj/klYefgX7joIva8KzP3yeKusbQbKjVzkD8J2Nym9De1F4vNTuAR YVGQ== X-Gm-Message-State: AOAM532d11llapsBm33HqMBNC2b+BoJ0BDalzdqulycXYX54CDPbkjf2 U4DVwTaWBTQuM3txr+Cdk/E= X-Google-Smtp-Source: ABdhPJyzf8c691eftcVFlQ7m/GD11ZtJjJhSlp6erG/Lnp+d4loQrwgH0aZprws8tpF58+ejtI5i0w== X-Received: by 2002:a17:90a:cb8d:: with SMTP id a13mr1950080pju.155.1609211840895; Mon, 28 Dec 2020 19:17:20 -0800 (PST) Received: from [10.230.29.27] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id z23sm37105562pfn.202.2020.12.28.19.17.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Dec 2020 19:17:19 -0800 (PST) Subject: Re: [PATCH net-next v2 6/6] bcm63xx_enet: improve rx loop To: Sieng Piaw Liew , Florian Fainelli References: <20201224142421.32350-1-liew.s.piaw@gmail.com> <20201224142421.32350-7-liew.s.piaw@gmail.com> From: Florian Fainelli Message-ID: <7393e13a-5735-19a5-71f7-b370bdb9b39b@gmail.com> Date: Mon, 28 Dec 2020 19:17:12 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201224142421.32350-7-liew.s.piaw@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201228_221723_045863_7DA405B9 X-CRM114-Status: GOOD ( 10.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/24/2020 6:24 AM, Sieng Piaw Liew wrote: > Use existing rx processed count to track against budget, thereby making > budget decrement operation redundant. > > rx_desc_count can be calculated outside the rx loop, making the loop a > bit smaller. > > Signed-off-by: Sieng Piaw Liew Acked-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel