From mboxrd@z Thu Jan 1 00:00:00 1970 From: Song Liu Subject: Re: [PATCH v3 1/2] md raid0/linear: Mark array as 'broken' and fail BIOs if a member is gone Date: Thu, 22 Aug 2019 21:55:23 +0000 Message-ID: <73C4747E-7A9E-4833-8393-B6A06C935DBE@fb.com> References: <20190822161318.26236-1-gpiccoli@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190822161318.26236-1-gpiccoli@canonical.com> Content-Language: en-US Content-ID: <9EB021AC02A93A41880C260032233E66@namprd15.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: "Guilherme G. Piccoli" Cc: "linux-block@vger.kernel.org" , Song Liu , NeilBrown , linux-raid , "dm-devel@redhat.com" , Jay Vosburgh List-Id: linux-raid.ids > On Aug 22, 2019, at 9:13 AM, Guilherme G. Piccoli wrote: > > Currently md raid0/linear are not provided with any mechanism to validate > if an array member got removed or failed. The driver keeps sending BIOs > regardless of the state of array members, and kernel shows state 'clean' > in the 'array_state' sysfs attribute. This leads to the following > situation: if a raid0/linear array member is removed and the array is > mounted, some user writing to this array won't realize that errors are > happening unless they check dmesg or perform one fsync per written file. > Despite udev signaling the member device is gone, 'mdadm' cannot issue the > STOP_ARRAY ioctl successfully, given the array is mounted. [...] > drivers/md/md-linear.c | 9 +++++++++ > drivers/md/md.c | 22 ++++++++++++++++++---- > drivers/md/md.h | 3 +++ > drivers/md/raid0.c | 10 ++++++++++ > 4 files changed, 40 insertions(+), 4 deletions(-) > > diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c > index 7354466ddc90..0479ccdbdeeb 100644 > --- a/drivers/md/md-linear.c > +++ b/drivers/md/md-linear.c > @@ -258,6 +258,15 @@ static bool linear_make_request(struct mddev *mddev, struct bio *bio) > bio_sector < start_sector)) > goto out_of_bounds; > > + if (unlikely(!(tmp_dev->rdev->bdev->bd_disk->flags & GENHD_FL_UP))) { > + if (!test_bit(MD_BROKEN, &mddev->flags)) > + pr_warn("md: %s: linear array has a missing/failed member\n", > + mdname(mddev)); > + set_bit(MD_BROKEN, &mddev->flags); > + bio_io_error(bio); > + return true; > + } > + Maybe we can somehow put this block in a helper and use it in both raid0 and linear code? Otherwise, looks good to me. Thanks, Song From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84438C3A5A1 for ; Thu, 22 Aug 2019 21:55:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 123D9233FC for ; Thu, 22 Aug 2019 21:55:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=fb.com header.i=@fb.com header.b="BXv3y/LS"; dkim=pass (1024-bit key) header.d=fb.onmicrosoft.com header.i=@fb.onmicrosoft.com header.b="VNY218RJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393634AbfHVVzd (ORCPT ); Thu, 22 Aug 2019 17:55:33 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:31056 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390125AbfHVVzd (ORCPT ); Thu, 22 Aug 2019 17:55:33 -0400 Received: from pps.filterd (m0148461.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7MLrHf3009444; Thu, 22 Aug 2019 14:55:26 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=facebook; bh=H4/KQt0L8iQTmgrdqPLaxrCl2zptw4B5kisKbZcEu28=; b=BXv3y/LSUnKxaFprH5uKa9f553ev7W6qsn+SQ60B9aG05ICFuyavb6tBP8VsQLyhkP71 Xu0r6bCWLtLeUfGTXVGA8xrFCuFtB6BlIDQZ0yxZrEmp3Ta1oVhZv6Vu+9JGxeBFGH9i 6Vxh+Hta2m+H7o1u17CYxlyKcFbsD3kZs+Y= Received: from mail.thefacebook.com (mailout.thefacebook.com [199.201.64.23]) by mx0a-00082601.pphosted.com with ESMTP id 2uhxr2sd5d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 22 Aug 2019 14:55:25 -0700 Received: from prn-hub01.TheFacebook.com (2620:10d:c081:35::125) by prn-hub04.TheFacebook.com (2620:10d:c081:35::128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1713.5; Thu, 22 Aug 2019 14:55:24 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (192.168.54.28) by o365-in.thefacebook.com (192.168.16.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1713.5 via Frontend Transport; Thu, 22 Aug 2019 14:55:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kYGOkSIxmajqyYUY/uQLHj7gacrfhQtKOx11GI3POEvUiBgZlPnlO+ptj4V11Rghh84fvPlvQGL1mjCWHDaqZ3B0Z/fHJV9vmo3AUBGk1OVoSNYth47lVma3HxqFxKM96apu0+VqA7louDZmXsI4MC5RtayRGJ6dKc1PUtax3jNz0wM1P+YPES43TQf85QK9CQIhuT+yaClK9n9BLtQtOVMXbwmx98JRr4eTd0/JkC8NScN2vPS5IvIGsI/1VTzT7VBmYeGfqHn+WlY+bcdPlLgxfRk9cA20Mz8HuniqJiPOYxzzcRmdTqu4w0+IdO0j3mXS0+9L6uFOPcIoH5CVRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H4/KQt0L8iQTmgrdqPLaxrCl2zptw4B5kisKbZcEu28=; b=bl31RhUR14ROLnyMPSrAyKAqwkL6ViIoq7z7QIjsBUbN7JlHSi1Qaoy0GD34g8yVQXPq0vrUzSsS/veTWKphepbD++NY7nlQpxBN3bKqvcfg0zlITvO+OS9Ao6PNoV7evk+Qied1oJ3mghQHzM2WvBoJcNXYV+/9y8yBg6WJpSTHZA53OuEG9rpEu21FDNsSOk6D0z3B4TlV0rP2Nlcsz8hz+1HgYPv9ETqkg4OImV1QNrvEGT+sIkOemJwd4xE7HZmZMmAlPFwuFAVG5nFcxBT9TPuKRQnxC+MoFr71leh0gUrb2m8tCjbIAmzigvwcX6fden3BHcAfTCfRx9VMfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fb.com; dmarc=pass action=none header.from=fb.com; dkim=pass header.d=fb.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector2-fb-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H4/KQt0L8iQTmgrdqPLaxrCl2zptw4B5kisKbZcEu28=; b=VNY218RJs39T5baSOYuCRQGmLVMegUoByEY3VaQFtG/KigKKghldc/FNOByEdmqdgTIUqtN8FzPptWRVOTTfrtXasul7XbcP94shcR0dGVo67E6Jj7sfDpOvG2u/O3s9waXCuhL/MZU4avSDQzTT+0KY8ABgpgpuoJQTMYV/A4M= Received: from MWHPR15MB1165.namprd15.prod.outlook.com (10.175.3.22) by MWHPR15MB1167.namprd15.prod.outlook.com (10.175.3.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.16; Thu, 22 Aug 2019 21:55:24 +0000 Received: from MWHPR15MB1165.namprd15.prod.outlook.com ([fe80::45ee:bc50:acfa:60a5]) by MWHPR15MB1165.namprd15.prod.outlook.com ([fe80::45ee:bc50:acfa:60a5%3]) with mapi id 15.20.2178.020; Thu, 22 Aug 2019 21:55:24 +0000 From: Song Liu To: "Guilherme G. Piccoli" CC: linux-raid , "linux-block@vger.kernel.org" , "dm-devel@redhat.com" , Jay Vosburgh , Song Liu , NeilBrown Subject: Re: [PATCH v3 1/2] md raid0/linear: Mark array as 'broken' and fail BIOs if a member is gone Thread-Topic: [PATCH v3 1/2] md raid0/linear: Mark array as 'broken' and fail BIOs if a member is gone Thread-Index: AQHVWQTWiOO9/lvNXkO6JBhdqUPdfKcHto6A Date: Thu, 22 Aug 2019 21:55:23 +0000 Message-ID: <73C4747E-7A9E-4833-8393-B6A06C935DBE@fb.com> References: <20190822161318.26236-1-gpiccoli@canonical.com> In-Reply-To: <20190822161318.26236-1-gpiccoli@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3445.104.11) x-originating-ip: [2620:10d:c090:180::8436] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 62d764b0-d50b-4d81-25d5-08d7274b6f6c x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600166)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:MWHPR15MB1167; x-ms-traffictypediagnostic: MWHPR15MB1167: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-forefront-prvs: 01371B902F x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(136003)(376002)(366004)(39860400002)(346002)(199004)(189003)(102836004)(305945005)(5660300002)(478600001)(53936002)(57306001)(6916009)(33656002)(6436002)(2906002)(6246003)(6486002)(50226002)(36756003)(6512007)(14454004)(7736002)(64756008)(66476007)(256004)(14444005)(486006)(46003)(446003)(2616005)(11346002)(76176011)(476003)(71190400001)(76116006)(86362001)(66946007)(71200400001)(99286004)(6116002)(4326008)(54906003)(25786009)(316002)(8936002)(81156014)(81166006)(8676002)(53546011)(229853002)(6506007)(186003)(66446008)(66556008);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1167;H:MWHPR15MB1165.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: fb.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: WV4TmJ5iLViMkLNm6M9II8rIFIonhD+pHYiysltBNOC3X5WwOEc79puplVOET2KRoV1qvXldet4CUeVhNmzxngRMZU5JRLtf+h8mm0qHq5d+iNZLW86Jx80peAFIIKRw8ne3QJ/fjN7Ld1KGketkSJ3i4rKpScxNS6rbwQsDBUSREj6yT4LG7ZyJbnlCxXtjhwd4g9IdDBiu7qGvrMjVzuXv2DauCJoqkGOzIQb0EHVJCNW8cLx2/cIEp1G9CSr210HSCfepZMANT0z9oL8X8XjFdpOlypFOy30+S0UIe7cDHJifZZ8bj1q1ElGe79lZEalee8CCXoiv7ZuXrbri63pbtD8PXILmHZORcF0JMq/M8njOcnV+JWA+yqDzzZx+25X22DDCM1Co4vlfiCSH0ZNP6aRIKgSI4NRkgkgFIsI= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: <9EB021AC02A93A41880C260032233E66@namprd15.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 62d764b0-d50b-4d81-25d5-08d7274b6f6c X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Aug 2019 21:55:23.9999 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TR7rR26xmkDlmAQX9x1pUIbGUNcoFXIUpuL5Vx4lU2t72cJBlQXp6DvAGPbAYYvDQSu2JJsJbU9Y+nwzFqssAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1167 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-08-22_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908220192 X-FB-Internal: deliver Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org > On Aug 22, 2019, at 9:13 AM, Guilherme G. Piccoli wrote: >=20 > Currently md raid0/linear are not provided with any mechanism to validate > if an array member got removed or failed. The driver keeps sending BIOs > regardless of the state of array members, and kernel shows state 'clean' > in the 'array_state' sysfs attribute. This leads to the following > situation: if a raid0/linear array member is removed and the array is > mounted, some user writing to this array won't realize that errors are > happening unless they check dmesg or perform one fsync per written file. > Despite udev signaling the member device is gone, 'mdadm' cannot issue th= e > STOP_ARRAY ioctl successfully, given the array is mounted. [...] > drivers/md/md-linear.c | 9 +++++++++ > drivers/md/md.c | 22 ++++++++++++++++++---- > drivers/md/md.h | 3 +++ > drivers/md/raid0.c | 10 ++++++++++ > 4 files changed, 40 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c > index 7354466ddc90..0479ccdbdeeb 100644 > --- a/drivers/md/md-linear.c > +++ b/drivers/md/md-linear.c > @@ -258,6 +258,15 @@ static bool linear_make_request(struct mddev *mddev,= struct bio *bio) > bio_sector < start_sector)) > goto out_of_bounds; >=20 > + if (unlikely(!(tmp_dev->rdev->bdev->bd_disk->flags & GENHD_FL_UP))) { > + if (!test_bit(MD_BROKEN, &mddev->flags)) > + pr_warn("md: %s: linear array has a missing/failed member\n", > + mdname(mddev)); > + set_bit(MD_BROKEN, &mddev->flags); > + bio_io_error(bio); > + return true; > + } > + Maybe we can somehow put this block in a helper and use it in both raid0 and linear code? Otherwise, looks good to me.=20 Thanks, Song