From: Marcel Holtmann <marcel@holtmann.org>
To: Szymon Janc <szymon.janc@codecoup.pl>
Cc: Brian Gix <brian.gix@intel.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
"Stotland, Inga" <inga.stotland@intel.com>
Subject: Re: [PATCH BlueZ v3 00/30] Major rewrite for Multi-Node and DBus
Date: Tue, 18 Dec 2018 14:47:36 +0100 [thread overview]
Message-ID: <73E0C5F2-1162-4857-976A-EDE376D55747@holtmann.org> (raw)
In-Reply-To: <110368016.VWXbCARz0c@ix>
Hi Brian,
>>> This patch-set has been applied upstream.
>>
>> There is something wrong with Makefile.mesh
>>
>> Makefile.am: installing './depcomp'
>> parallel-tests: installing './test-driver'
>> Makefile.mesh:31: warning: variable 'mesh_btmesh_LDADD' is defined but no
>> program or
>> Makefile.mesh:31: library has 'mesh_btmesh' as canonical name (possible
>> typo) Makefile.am:306: 'Makefile.mesh' included from here
>> Makefile.mesh:32: warning: variable 'mesh_btmesh_DEPENDENCIES' is defined
>> but no program or
>> Makefile.mesh:32: library has 'mesh_btmesh' as canonical name (possible
>> typo) Makefile.am:306: 'Makefile.mesh' included from here
>>
>>
>> Enabling commented out code (why is it commented out btw?) in Makefile.mesh
>> stil results in:
>>
>> Makefile.mesh:39: warning: mesh_btmesh_LDADD multiply defined in condition
>> MESH ...
>> Makefile.am:306: 'Makefile.mesh' included from here
>> Makefile.mesh:31: ... 'mesh_btmesh_LDADD' previously defined here
>> Makefile.am:306: 'Makefile.mesh' included from here
>>
>
>
> This seems to fix warnign for me. Was ot on purpose that btmesh wasn't added
> to noinst ?
>
>
> diff --git a/Makefile.mesh b/Makefile.mesh
> index 5344fbb21..1b8adea7e 100644
> --- a/Makefile.mesh
> +++ b/Makefile.mesh
> @@ -31,8 +31,8 @@ mesh_meshd_DEPENDENCIES = $(ell_dependencies)
> mesh_btmesh_LDADD = src/libshared-mainloop.la $(ell_ldadd) -lreadline -ljson-
> c
> mesh_btmesh_DEPENDENCIES = $(ell_dependencies)
>
> -#
> -# noinst_PROGRAMS += mesh/btmesh
> +noinst_PROGRAMS += mesh/btmesh
> +
> #
> # mesh_btmesh_SOURCES = $(mesh_sources) \
> # mesh/btmesh.c
>
so this stuff is _not_ acceptable at all. Please stop treating bluez.git as your playground. It is your responsibility that such patches are not applied.
We have git and so everything can be reversed and history can be restored. Commenting anything out in a Makefile is never needed and a total no-go. Same applies to *.c files. I do not want staging or untested stuff in the main tree. I also do not want any dead files in the tree that are not build. Clone your tree on github or somewhere else if you want to experiment.
I am reverting the whole set of patches and doing a push —force. You need to start over.
Regards
Marcel
next prev parent reply other threads:[~2018-12-18 13:47 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-15 0:25 [PATCH BlueZ v3 00/30] Major rewrite for Multi-Node and DBus Brian Gix
2018-12-15 0:25 ` [PATCH BlueZ v3 01/30] mesh: Staging for Mesh DBus API rewrite Brian Gix
2018-12-15 0:25 ` [PATCH BlueZ v3 02/30] mesh: Delete obsolete files Brian Gix
2018-12-15 0:25 ` [PATCH BlueZ v3 03/30] mesh: Utilities for DBus support Brian Gix
2018-12-15 0:25 ` [PATCH BlueZ v3 04/30] mesh: Internal errors Brian Gix
2018-12-15 0:25 ` [PATCH BlueZ v3 05/30] mesh: Re-write storage for Multiple Nodes Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 06/30] mesh: Rewrite Node handling for multiple nodes Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 07/30] mesh: Rewite Network layer " Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 08/30] mesh: Direction agnostic PB-Adv implimentation Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 09/30] mesh: Acceptor side provisioning implimentation Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 10/30] mesh: Initiator " Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 11/30] mesh: Rewrite Controler interface for full init Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 12/30] mesh: Unchanged variables set to const Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 13/30] mesh: centralize generic utilities Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 14/30] mesh: re-arrange provisioning for DBus API Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 15/30] mesh: Re-architect " Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 16/30] mesh: Make config model handle multiple nodes Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 17/30] mesh: Multi node Config Server model Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 18/30] mesh: restructure I/O for multiple nodes Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 19/30] mesh: Restrusture DB to support " Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 20/30] mesh: restructure model services for " Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 21/30] mesh: DBUS interface for Provisioning Agent Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 22/30] mesh: restructure App Key storage Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 23/30] mesh: Clean-up Comment style Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 24/30] mesh: Update for DBus API and multi-node support Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 25/30] mesh: Add default location for Mesh Node storage Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 26/30] mesh: Add structural changes for mesh Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 27/30] mesh: Sample Provisioning Agent Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 28/30] mesh: Sample On/Off Client and Server Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 29/30] mesh: Sample Mesh Joiner (provision acceptor) Brian Gix
2018-12-15 0:26 ` [PATCH BlueZ v3 30/30] mesh: Enable building Mesh Daemon Brian Gix
2018-12-17 18:42 ` [PATCH BlueZ v3 00/30] Major rewrite for Multi-Node and DBus Gix, Brian
2018-12-18 8:16 ` Szymon Janc
2018-12-18 9:14 ` Szymon Janc
2018-12-18 13:47 ` Marcel Holtmann [this message]
2018-12-18 15:08 ` Gix, Brian
2018-12-18 16:26 ` Marcel Holtmann
2018-12-18 16:50 ` Gix, Brian
2018-12-18 17:12 ` Marcel Holtmann
2018-12-19 13:02 ` Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73E0C5F2-1162-4857-976A-EDE376D55747@holtmann.org \
--to=marcel@holtmann.org \
--cc=brian.gix@intel.com \
--cc=inga.stotland@intel.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=szymon.janc@codecoup.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.