From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16D1FC10F03 for ; Tue, 23 Apr 2019 15:36:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D63A5218B0 for ; Tue, 23 Apr 2019 15:36:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728183AbfDWPgu (ORCPT ); Tue, 23 Apr 2019 11:36:50 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37282 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726421AbfDWPgu (ORCPT ); Tue, 23 Apr 2019 11:36:50 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3NFZ7bB178080 for ; Tue, 23 Apr 2019 11:36:48 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0b-001b2d01.pphosted.com with ESMTP id 2s25da07ag-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 23 Apr 2019 11:36:48 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 23 Apr 2019 16:36:46 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 23 Apr 2019 16:36:35 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x3NFaY6g51773584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Apr 2019 15:36:34 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 310C142041; Tue, 23 Apr 2019 15:36:34 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 96ED342042; Tue, 23 Apr 2019 15:36:31 +0000 (GMT) Received: from [9.145.7.116] (unknown [9.145.7.116]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 23 Apr 2019 15:36:31 +0000 (GMT) Subject: Re: [PATCH v12 04/31] arm64/mm: define ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT To: Jerome Glisse , Mark Rutland Cc: akpm@linux-foundation.org, mhocko@kernel.org, peterz@infradead.org, kirill@shutemov.name, ak@linux.intel.com, dave@stgolabs.net, jack@suse.cz, Matthew Wilcox , aneesh.kumar@linux.ibm.com, benh@kernel.crashing.org, mpe@ellerman.id.au, paulus@samba.org, Thomas Gleixner , Ingo Molnar , hpa@zytor.com, Will Deacon , Sergey Senozhatsky , sergey.senozhatsky.work@gmail.com, Andrea Arcangeli , Alexei Starovoitov , kemi.wang@intel.com, Daniel Jordan , David Rientjes , Ganesh Mahendran , Minchan Kim , Punit Agrawal , vinayak menon , Yang Shi , zhong jiang , Haiyan Song , Balbir Singh , sj38.park@gmail.com, Michel Lespinasse , Mike Rapoport , linux-kernel@vger.kernel.org, linux-mm@kvack.org, haren@linux.vnet.ibm.com, npiggin@gmail.com, paulmck@linux.vnet.ibm.com, Tim Chen , linuxppc-dev@lists.ozlabs.org, x86@kernel.org References: <20190416134522.17540-1-ldufour@linux.ibm.com> <20190416134522.17540-5-ldufour@linux.ibm.com> <20190416142710.GA54515@lakrids.cambridge.arm.com> <4ef9ff4b-2230-0644-2254-c1de22d41e6c@linux.ibm.com> <20190416144156.GB54708@lakrids.cambridge.arm.com> <20190418215113.GD11645@redhat.com> From: Laurent Dufour Date: Tue, 23 Apr 2019 17:36:31 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190418215113.GD11645@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19042315-4275-0000-0000-0000032AEC6A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19042315-4276-0000-0000-0000383A3230 Message-Id: <73a3650d-7e9f-bc9e-6ea1-2cef36411b0c@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-23_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904230105 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 18/04/2019 à 23:51, Jerome Glisse a écrit : > On Tue, Apr 16, 2019 at 03:41:56PM +0100, Mark Rutland wrote: >> On Tue, Apr 16, 2019 at 04:31:27PM +0200, Laurent Dufour wrote: >>> Le 16/04/2019 à 16:27, Mark Rutland a écrit : >>>> On Tue, Apr 16, 2019 at 03:44:55PM +0200, Laurent Dufour wrote: >>>>> From: Mahendran Ganesh >>>>> >>>>> Set ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT for arm64. This >>>>> enables Speculative Page Fault handler. >>>>> >>>>> Signed-off-by: Ganesh Mahendran >>>> >>>> This is missing your S-o-B. >>> >>> You're right, I missed that... >>> >>>> The first patch noted that the ARCH_SUPPORTS_* option was there because >>>> the arch code had to make an explicit call to try to handle the fault >>>> speculatively, but that isn't addeed until patch 30. >>>> >>>> Why is this separate from that code? >>> >>> Andrew was recommended this a long time ago for bisection purpose. This >>> allows to build the code with CONFIG_SPECULATIVE_PAGE_FAULT before the code >>> that trigger the spf handler is added to the per architecture's code. >> >> Ok. I think it would be worth noting that in the commit message, to >> avoid anyone else asking the same question. :) > > Should have read this thread before looking at x86 and ppc :) > > In any case the patch is: > > Reviewed-by: Jérôme Glisse Thanks Mark and Jérôme for reviewing this. Regarding the change in the commit message, I'm wondering if this would be better to place it in the Series's letter head. But I'm fine to put it in each architecture's commit. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFDFBC10F03 for ; Tue, 23 Apr 2019 15:38:27 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A401218B0 for ; Tue, 23 Apr 2019 15:38:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A401218B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44pSJw6fqSzDqMt for ; Wed, 24 Apr 2019 01:38:24 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=ldufour@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44pSH76nXVzDqLc for ; Wed, 24 Apr 2019 01:36:51 +1000 (AEST) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3NFYkMP072962 for ; Tue, 23 Apr 2019 11:36:49 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2s22ed0wy0-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 23 Apr 2019 11:36:48 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 23 Apr 2019 16:36:46 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 23 Apr 2019 16:36:35 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x3NFaY6g51773584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Apr 2019 15:36:34 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 310C142041; Tue, 23 Apr 2019 15:36:34 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 96ED342042; Tue, 23 Apr 2019 15:36:31 +0000 (GMT) Received: from [9.145.7.116] (unknown [9.145.7.116]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 23 Apr 2019 15:36:31 +0000 (GMT) Subject: Re: [PATCH v12 04/31] arm64/mm: define ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT To: Jerome Glisse , Mark Rutland References: <20190416134522.17540-1-ldufour@linux.ibm.com> <20190416134522.17540-5-ldufour@linux.ibm.com> <20190416142710.GA54515@lakrids.cambridge.arm.com> <4ef9ff4b-2230-0644-2254-c1de22d41e6c@linux.ibm.com> <20190416144156.GB54708@lakrids.cambridge.arm.com> <20190418215113.GD11645@redhat.com> From: Laurent Dufour Date: Tue, 23 Apr 2019 17:36:31 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190418215113.GD11645@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19042315-4275-0000-0000-0000032AEC6A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19042315-4276-0000-0000-0000383A3230 Message-Id: <73a3650d-7e9f-bc9e-6ea1-2cef36411b0c@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-23_04:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904230105 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jack@suse.cz, sergey.senozhatsky.work@gmail.com, peterz@infradead.org, Will Deacon , mhocko@kernel.org, linux-mm@kvack.org, paulus@samba.org, Punit Agrawal , hpa@zytor.com, Michel Lespinasse , Alexei Starovoitov , Andrea Arcangeli , ak@linux.intel.com, Minchan Kim , aneesh.kumar@linux.ibm.com, x86@kernel.org, Matthew Wilcox , Daniel Jordan , Ingo Molnar , David Rientjes , paulmck@linux.vnet.ibm.com, Haiyan Song , npiggin@gmail.com, sj38.park@gmail.com, dave@stgolabs.net, kemi.wang@intel.com, kirill@shutemov.name, Thomas Gleixner , zhong jiang , Ganesh Mahendran , Yang Shi , Mike Rapoport , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky , vinayak menon , akpm@linux-foundation.org, Tim Chen , haren@linux.vnet.ibm.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 18/04/2019 à 23:51, Jerome Glisse a écrit : > On Tue, Apr 16, 2019 at 03:41:56PM +0100, Mark Rutland wrote: >> On Tue, Apr 16, 2019 at 04:31:27PM +0200, Laurent Dufour wrote: >>> Le 16/04/2019 à 16:27, Mark Rutland a écrit : >>>> On Tue, Apr 16, 2019 at 03:44:55PM +0200, Laurent Dufour wrote: >>>>> From: Mahendran Ganesh >>>>> >>>>> Set ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT for arm64. This >>>>> enables Speculative Page Fault handler. >>>>> >>>>> Signed-off-by: Ganesh Mahendran >>>> >>>> This is missing your S-o-B. >>> >>> You're right, I missed that... >>> >>>> The first patch noted that the ARCH_SUPPORTS_* option was there because >>>> the arch code had to make an explicit call to try to handle the fault >>>> speculatively, but that isn't addeed until patch 30. >>>> >>>> Why is this separate from that code? >>> >>> Andrew was recommended this a long time ago for bisection purpose. This >>> allows to build the code with CONFIG_SPECULATIVE_PAGE_FAULT before the code >>> that trigger the spf handler is added to the per architecture's code. >> >> Ok. I think it would be worth noting that in the commit message, to >> avoid anyone else asking the same question. :) > > Should have read this thread before looking at x86 and ppc :) > > In any case the patch is: > > Reviewed-by: Jérôme Glisse Thanks Mark and Jérôme for reviewing this. Regarding the change in the commit message, I'm wondering if this would be better to place it in the Series's letter head. But I'm fine to put it in each architecture's commit.