From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E642C47080 for ; Tue, 1 Jun 2021 16:42:13 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 274F66138C for ; Tue, 1 Jun 2021 16:42:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 274F66138C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E315A82E5F; Tue, 1 Jun 2021 18:42:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="iYULA1pO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1E9DC82EA5; Tue, 1 Jun 2021 18:42:09 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 81EDA82CB2 for ; Tue, 1 Jun 2021 18:42:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1622565721; bh=gZBYWvy0QVGaCxr5kVFGIf14WHG8LSRGgkNunDRK8sA=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=iYULA1pO/rOjQp6a9CrfH9ikubWlrE2GhRwdMk/rBvyl2UvmJhDxVR6baIgBmOrrR S08JK6khmTP9UygtEP551EnZFFHcofkiRgT4uDUVaoLyUuDKMXtXajkyYOS8PeqwT0 8+i3M4QEnlzyyl9GBpDbLTEOancp5IQN+ch/D42I= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.35] ([62.143.247.63]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MZkpb-1lr3jL3NsV-00Wpfe; Tue, 01 Jun 2021 18:42:00 +0200 Subject: =?UTF-8?Q?Re=3a_=5bPATCH=5d_cmd=3aUpdate_HELP_text_of_=e2=80=99aske?= =?UTF-8?B?bnbigJk=?= To: opensource.kab@gmail.com Cc: sjg@chromium.org, Maxim Uvarov , Patrice Chotard , Patrick Delaunay , Pedro Aguilar , u-boot@lists.denx.de, Tom Rini References: <20210601070927.5379-1-opensource.kab@gmail.com> From: Heinrich Schuchardt Message-ID: <73c617fa-378d-dd94-3f6b-be0d50f7087b@gmx.de> Date: Tue, 1 Jun 2021 18:41:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210601070927.5379-1-opensource.kab@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:akjGpIsU7nqfmbhK7ZRMjOo+fWPJDBfzYsp9NmJklTx/sEG7Zhk Fcizybtpnns6FwnHANhGy1b8j7Tx92Jr+5Ar80QzBzfgrVPbBt8o/5acD0xlqXnJfbrrqQt SMJTgN+Bb2vDwjVUkKyILy0lMJ+aK1oYn8E43PJtlroSFCtKpdNFLCgg6WkYYmFViyBgRwI VkDSesVMt4C8sy1q+eluw== X-UI-Out-Filterresults: notjunk:1;V03:K0:3lI/sEa6J1c=:bACh7rX0o9G1H9qx1/Q23y 25EbI8BhoLCHAMw+p1CUa0UP3QLxq9o7At3qg7TCss5mBne4CiY/3z+yMeSn+MwxmrmfEwivP 9DfOh6OpGpZLjmVhtFStUrssp8Gfw+nhFDvdK5wzg7s5PnBBzJ48SMrEFjanGr+XMBOoeLYZV gCCx5apB/L06w2u3c64AQGJc3yF01xtolBOkV/LS6XEOzVRqNMEbkdL/54DsXxu+Rq2RXDGzq kcxX66/5r1qcXvo/ncqrzpbuz2FfbGhRs+yGV9It4aXyAXwUdCkSa2ftVAlpbGYwzhyDbfsLm biWnNMIoB/jalHX7JsxwSOApeLFmDSnAuwMpvujTIJkNZpLAOeXgpGLLDRD858AEiJpIDVfA9 Ii7iCDSkP8omjFU5eWNHbWpuryB7895JiWuSBh/bwJ3r2QE1PZZx9KpcgTSPC+E6DAM4zrXlX JmImtD9pFAR/6GfkIQDqPb5cjud3DStfoC5azMZ/Frg2yfmqgpa+zNf8GaAyNiYykGs9XgOgu n/ICwtCJj/6d+dTmb9EJno8ScflXVXkuH+e03x2aOhzrWDf6IZAyX+y/p7TBw29ZWy+AuuwgC hQaCHOoO+Hf9Bwx1KulogAhR/mjqlNQWIBAztf1Ydjzpi9qrLKVCinnpvUMlSCZQx/kdNaFpH vOZ7wEb3QHTmOtoJHJ/O0U5bZmgqc43Wx1OeUUDnJTbgZGswSXCbNgH0m/n4RuhLDdGKnaF8j y872t8NIjVOIgalSVvigSW4AQZ+vhSlSQbBL55dXnpjtMlawqrBYkOCgLnY6bOb3m1CVq+K71 v7f7XRtrUIuYD1CeI/4tPnmrd2/6U2sqvaD9scRUghLcb8l8+ULbqRm1JJdchsFyyzlCcPdIh TXXvnlD7L56rFWxi0JtMSOudBqcv4hXWMDn8FrgezI/mjNfM3MfudayXeXxxFq/Q0R6ZZgo/F ZhYV7k0U8iU28m+idTsR/kfWB5rfG2/8zuumr9jq1hRZZJzKjI8LZY6H8xterd7cp110hAtCb ONx3jxQNUOnly9qT3+WsvFTAttfxlJtyhiakIxcCcoR7pAQmGFMdwS4Vp6gwLxtlQrvpQoXNs 7NJYDXMrAe/BDQ8mOE/tD6d3U4dEfzK0WF9 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On 6/1/21 9:09 AM, opensource.kab@gmail.com wrote: > From: Adarsh Babu Kalepalli > > Help text of =E2=80=98askenv=E2=80=99 cmd is updated > > Signed-off-by: Adarsh Babu Kalepalli > --- > > cmd/nvedit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cmd/nvedit.c b/cmd/nvedit.c > index d14ba10cef..910cf16aaf 100644 > --- a/cmd/nvedit.c > +++ b/cmd/nvedit.c > @@ -1569,7 +1569,7 @@ U_BOOT_CMD( > askenv, CONFIG_SYS_MAXARGS, 1, do_env_ask, > "get environment variables from stdin", > "name [message] [size]\n" > - " - get environment variable 'name' from stdin (max 'size' chars)" > + " - display 'message' and get environment variable 'name' from stdi= n (max 'size' chars)" Hello Ardash, thanks for looking for a better description. This online help does not correctly describe the command syntax yet which is: askenv name [message ...] [size] =3D> askenv foo Please enter 'foo': abcdefgh =3D> echo $foo abcdefgh =3D> =3D> askenv foo 4 Please enter 'foo': abcdefgh =3D> echo $foo abcd =3D> =3D> askenv foo msg1 msg2 msg3 3 msg1 msg2 msg3 abcdefgh =3D> echo $foo abc =3D> =3D> askenv foo msg1 msg2 msg3 msg1 msg2 msg3 abcdefgh =3D> echo $foo abcdefgh =3D> The logic needs some explanation. The last parameter is used as size if it can be converted to a decimal number. In most other commands we expect a hexadecimal number. We started adding man-pages for all commands to doc/usage/. Do you want to give it a try? Best regards Heinrich > ); > #endif > >