From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46672C433E7 for ; Sun, 30 Aug 2020 09:25:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F40220BED for ; Sun, 30 Aug 2020 09:25:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728716AbgH3JZu (ORCPT ); Sun, 30 Aug 2020 05:25:50 -0400 Received: from foss.arm.com ([217.140.110.172]:49362 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725869AbgH3JZt (ORCPT ); Sun, 30 Aug 2020 05:25:49 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A31DD31B; Sun, 30 Aug 2020 02:25:48 -0700 (PDT) Received: from [10.37.8.19] (unknown [10.37.8.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 82AE33F68F; Sun, 30 Aug 2020 02:25:47 -0700 (PDT) Subject: Re: [PATCH] iio: adc: rockchip_saradc: Select IIO_TRIGGERED_BUFFER To: Jonathan Cameron Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, xxm@rock-chips.com References: <20200828174242.338068-1-alexandru.elisei@arm.com> <20200829155703.19bf1c9f@archlinux> From: Alexandru Elisei Message-ID: <73cb7fcd-df73-e287-7733-4ce657e5a758@arm.com> Date: Sun, 30 Aug 2020 10:26:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200829155703.19bf1c9f@archlinux> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jonathan, On 8/29/20 3:57 PM, Jonathan Cameron wrote: > On Fri, 28 Aug 2020 18:42:42 +0100 > Alexandru Elisei wrote: > >> Building the Rockchip saradc driver can trigger the following error if the >> driver is compiled into the kernel, but the IIO triggered buffer is not: >> >> aarch64-linux-gnu-ld: drivers/iio/adc/rockchip_saradc.o: in function `rockchip_saradc_probe': >> /path/to/linux/drivers/iio/adc/rockchip_saradc.c:427: undefined reference to `devm_iio_triggered_buffer_setup' >> >> This is because commit 4e130dc7b413 ("iio: adc: rockchip_saradc: Add >> support iio buffers") added support for industrial I/O triggered buffers, >> but didn't update Kconfig to build the required file. Fix that. >> >> Fixes: 4e130dc7b413 ("iio: adc: rockchip_saradc: Add support iio buffers") >> Signed-off-by: Alexandru Elisei > Sorry, I've had a patch queued to fix this for a while, but had a > vacation just after merge window occurred that delayed me sending it out. > > Will send a pull sometime this weekend. > > Jonathan That's great, thank you! Thanks, Alex