Re: [PATCH] vsock/virtio: set vsock frontend ready in virtio_vsock_probe()

From: Jason Wang <jasowang@redhat.com>
To: Xianting Tian <tianxianting.txt@linux.alibaba.com>,
	stefanha@redhat.com, sgarzare@redhat.com, davem@davemloft.net,
	kuba@kernel.org
Cc: kvm@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Xianting Tian <xianting.tian@linux.alibaba.com>
Subject: Re: [PATCH] vsock/virtio: set vsock frontend ready in virtio_vsock_probe()
Date: Tue, 20 Jul 2021 14:28:24 +0800	[thread overview]
Message-ID: <73d486dd-17d9-a3b3-c1e9-39a1138c0084@redhat.com> (raw)
In-Reply-To: <20210720034255.1408-1-tianxianting.txt@linux.alibaba.com>

在 2021/7/20 上午11:42, Xianting Tian 写道:
> From: Xianting Tian <xianting.tian@linux.alibaba.com>
>
> Add the missed virtio_device_ready() to set vsock frontend ready.
>
> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
> ---
>   net/vmw_vsock/virtio_transport.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
> index e0c2c992a..eb4c607c4 100644
> --- a/net/vmw_vsock/virtio_transport.c
> +++ b/net/vmw_vsock/virtio_transport.c
> @@ -637,6 +637,8 @@ static int virtio_vsock_probe(struct virtio_device *vdev)
>   	vdev->priv = vsock;
>   	rcu_assign_pointer(the_virtio_vsock, vsock);
>   
> +	virtio_device_ready(vdev);
> +
>   	mutex_unlock(&the_virtio_vsock_mutex);

It's better to do this after the mutex_lock().

Thanks

>   
>   	return 0;