From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [Patch net] 8021q: fix a memory leak for VLAN 0 device Date: Wed, 10 Jan 2018 00:53:22 +0200 Message-ID: <73df52fd-0025-5cf3-bcb8-5ed8bd6438d3@cumulusnetworks.com> References: <20180109214041.26842-1-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Linux Kernel Network Developers , Dmitry Vyukov , Vlad Yasevich , Ben Hutchings To: Cong Wang Return-path: Received: from mail-wm0-f47.google.com ([74.125.82.47]:32853 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752178AbeAIWx0 (ORCPT ); Tue, 9 Jan 2018 17:53:26 -0500 Received: by mail-wm0-f47.google.com with SMTP id 123so2868036wme.0 for ; Tue, 09 Jan 2018 14:53:25 -0800 (PST) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 01/10/2018 12:47 AM, Cong Wang wrote: > On Tue, Jan 9, 2018 at 2:30 PM, Nikolay Aleksandrov > wrote: >> >> Just for reference - this is identical to the first part of: >> https://patchwork.ozlabs.org/patch/252891/ >> >> I knew this looked familiar. :-) >> > > Yeah, except bonding is not even involved. Unless I misread, > DaveM rejected it because of bond, which I never touch here. > > The refcnt is paired in vlan_vid_{add,del}, and the calls are > paired in register/unreigster and NETDEV_UP/NETDEV_DOWN > after this patch. > You should read all of my replies to Dave, specifically the last one where I describe exactly a memory leak, and IIRC the rejection was not because of the bonding part but exactly because of this change - the removal of the vlan_id conditional. I'm not arguing about this patch now, I've said what I had to say back then, I just gave it as a reference in case there's still relevant information in there. Thanks, Nik