From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91E0CC4724C for ; Thu, 30 Apr 2020 17:53:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E68720870 for ; Thu, 30 Apr 2020 17:53:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588269230; bh=4Xo8/1e7qaJmuQQltLTfB4vjVZPdGrjTFYT8oEPKWno=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Eb+YOsWnu2UcSH2eZaOTioqbkRRYOz1xtYCT9kgaHebUBoBSr/9rrZdrJ5Rx0M85k obUAR5PROCLQV5yFx50AU43uvPE1DKtZhalqKEaVh59y/FxIJjZ6VXJjsCSWH3Gijt wIVv4+h83jYDCpvumtkj62sCeJvEjBJ8Tw7abr+E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726435AbgD3Rxt (ORCPT ); Thu, 30 Apr 2020 13:53:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:38604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726285AbgD3Rxt (ORCPT ); Thu, 30 Apr 2020 13:53:49 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C9B7F20836; Thu, 30 Apr 2020 17:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588269228; bh=4Xo8/1e7qaJmuQQltLTfB4vjVZPdGrjTFYT8oEPKWno=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TnzHy6V0ZH7paWMDm5JrkAHnp/DaOr3pZvhvI0vYr1381WdBJTPVhmepyRnBUiLba o8thxzN3rCxTBpDBvcLfBQetKd7K7qWM3ZeU1eXq82INA7n961BxRiD4T+u1HNYwcZ dpNJGdEFn0SyLaoq3c7EWRsANA/N5cp3TcBUyYss= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jUDNb-0088YE-6h; Thu, 30 Apr 2020 18:53:47 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 30 Apr 2020 18:53:47 +0100 From: Marc Zyngier To: David Brazdil Cc: Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/15] Split off nVHE hyp code In-Reply-To: <20200430144831.59194-1-dbrazdil@google.com> References: <20200430144831.59194-1-dbrazdil@google.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <73efca41e7b955db4963ff182624107d@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: dbrazdil@google.com, catalin.marinas@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, Thanks for posting this, looks quite interesting! On 2020-04-30 15:48, David Brazdil wrote: > Refactor files in arch/arm64/kvm/hyp to compile all code which runs in > EL2 > under nVHE into separate object files from the rest of KVM. This is > done in > preparation for being able to unmap .hyp.text from EL1 but has other > benefits, > notably: > * safe use of KASAN/UBSAN/GCOV instrumentation on VHE code, > * cleaner HVC API, > * no need for __hyp_text annotations. > > nVHE-specific code is moved to hyp/nvhe and compiled with custom build > rules > similar to those used by EFI stub. Shared source files are compiled > under both > VHE and nVHE build rules. Where a source file contained both VHE and > nVHE code, > it is split into a shared header file and two C source files. This is > done one > file per commit to make review easier. Do you have any figure on how much bigger the final kernel becomes once this is applied? I guess I can find out pretty easily, but this is the kind of thing that would be useful to make part of your cover letter. I'll try to review this shortly. Thanks, M. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 951C5C47247 for ; Thu, 30 Apr 2020 17:53:55 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 1C814208D6 for ; Thu, 30 Apr 2020 17:53:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="TnzHy6V0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C814208D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 84F6A4B3D2; Thu, 30 Apr 2020 13:53:54 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xUNE4x8Kk8x7; Thu, 30 Apr 2020 13:53:52 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3862E4B3CE; Thu, 30 Apr 2020 13:53:52 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4192D4B3B4 for ; Thu, 30 Apr 2020 13:53:51 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lvzLiVRmxAUr for ; Thu, 30 Apr 2020 13:53:50 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 074344B3B0 for ; Thu, 30 Apr 2020 13:53:50 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C9B7F20836; Thu, 30 Apr 2020 17:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588269228; bh=4Xo8/1e7qaJmuQQltLTfB4vjVZPdGrjTFYT8oEPKWno=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TnzHy6V0ZH7paWMDm5JrkAHnp/DaOr3pZvhvI0vYr1381WdBJTPVhmepyRnBUiLba o8thxzN3rCxTBpDBvcLfBQetKd7K7qWM3ZeU1eXq82INA7n961BxRiD4T+u1HNYwcZ dpNJGdEFn0SyLaoq3c7EWRsANA/N5cp3TcBUyYss= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jUDNb-0088YE-6h; Thu, 30 Apr 2020 18:53:47 +0100 MIME-Version: 1.0 Date: Thu, 30 Apr 2020 18:53:47 +0100 From: Marc Zyngier To: David Brazdil Subject: Re: [PATCH 00/15] Split off nVHE hyp code In-Reply-To: <20200430144831.59194-1-dbrazdil@google.com> References: <20200430144831.59194-1-dbrazdil@google.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <73efca41e7b955db4963ff182624107d@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: dbrazdil@google.com, catalin.marinas@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: Catalin Marinas , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will Deacon , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi David, Thanks for posting this, looks quite interesting! On 2020-04-30 15:48, David Brazdil wrote: > Refactor files in arch/arm64/kvm/hyp to compile all code which runs in > EL2 > under nVHE into separate object files from the rest of KVM. This is > done in > preparation for being able to unmap .hyp.text from EL1 but has other > benefits, > notably: > * safe use of KASAN/UBSAN/GCOV instrumentation on VHE code, > * cleaner HVC API, > * no need for __hyp_text annotations. > > nVHE-specific code is moved to hyp/nvhe and compiled with custom build > rules > similar to those used by EFI stub. Shared source files are compiled > under both > VHE and nVHE build rules. Where a source file contained both VHE and > nVHE code, > it is split into a shared header file and two C source files. This is > done one > file per commit to make review easier. Do you have any figure on how much bigger the final kernel becomes once this is applied? I guess I can find out pretty easily, but this is the kind of thing that would be useful to make part of your cover letter. I'll try to review this shortly. Thanks, M. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DCCDC4724C for ; Thu, 30 Apr 2020 17:53:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 029DD20873 for ; Thu, 30 Apr 2020 17:53:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WsLUEJB9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="TnzHy6V0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 029DD20873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eGxSxEEYtw9oyDEL62SCeQdaBZwPsD5xHn1/APZQ5lg=; b=WsLUEJB9kJHBwdMaRZ/tDdOq1 P3XEAFBIVxE5c3c9BYCLjqjxFOcq0L7E0HSr2snqAOo5KxG3Nt5Tjcsrh12ZuKYFsFBzpkZeyVrxE OF4Hrew8KPc3Sb7XVFVtYvHpvnkcVgVgt3MNx2TOIlEQczn5GsZ5C0AqrgFZGOVR3c5wUrb73bAn3 bAjZHWzDGF8U8giXUyZyMMt/hdidT++w1gldHOXbE+xcrLI0WoGoQKUMpBPR2uFRzSc1abmUB/u5U qcw+MF/qRkAcRAOqScBSEqLFLER3Ogb0jqhyBV5tMdFLjpAMG3j6F1OpchPz4EVGWARLQRsxnJlqy 03fkX9FWQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUDNg-0001fR-Iw; Thu, 30 Apr 2020 17:53:52 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUDNd-0001eV-FO for linux-arm-kernel@lists.infradead.org; Thu, 30 Apr 2020 17:53:51 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C9B7F20836; Thu, 30 Apr 2020 17:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588269228; bh=4Xo8/1e7qaJmuQQltLTfB4vjVZPdGrjTFYT8oEPKWno=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TnzHy6V0ZH7paWMDm5JrkAHnp/DaOr3pZvhvI0vYr1381WdBJTPVhmepyRnBUiLba o8thxzN3rCxTBpDBvcLfBQetKd7K7qWM3ZeU1eXq82INA7n961BxRiD4T+u1HNYwcZ dpNJGdEFn0SyLaoq3c7EWRsANA/N5cp3TcBUyYss= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jUDNb-0088YE-6h; Thu, 30 Apr 2020 18:53:47 +0100 MIME-Version: 1.0 Date: Thu, 30 Apr 2020 18:53:47 +0100 From: Marc Zyngier To: David Brazdil Subject: Re: [PATCH 00/15] Split off nVHE hyp code In-Reply-To: <20200430144831.59194-1-dbrazdil@google.com> References: <20200430144831.59194-1-dbrazdil@google.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <73efca41e7b955db4963ff182624107d@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: dbrazdil@google.com, catalin.marinas@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200430_105349_534036_F30DDD29 X-CRM114-Status: GOOD ( 14.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki K Poulose , Catalin Marinas , linux-kernel@vger.kernel.org, James Morse , linux-arm-kernel@lists.infradead.org, Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi David, Thanks for posting this, looks quite interesting! On 2020-04-30 15:48, David Brazdil wrote: > Refactor files in arch/arm64/kvm/hyp to compile all code which runs in > EL2 > under nVHE into separate object files from the rest of KVM. This is > done in > preparation for being able to unmap .hyp.text from EL1 but has other > benefits, > notably: > * safe use of KASAN/UBSAN/GCOV instrumentation on VHE code, > * cleaner HVC API, > * no need for __hyp_text annotations. > > nVHE-specific code is moved to hyp/nvhe and compiled with custom build > rules > similar to those used by EFI stub. Shared source files are compiled > under both > VHE and nVHE build rules. Where a source file contained both VHE and > nVHE code, > it is split into a shared header file and two C source files. This is > done one > file per commit to make review easier. Do you have any figure on how much bigger the final kernel becomes once this is applied? I guess I can find out pretty easily, but this is the kind of thing that would be useful to make part of your cover letter. I'll try to review this shortly. Thanks, M. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel