All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] github: fix config mistake preventing repo lockdown commenting
Date: Tue, 29 Mar 2022 00:05:06 +0200	[thread overview]
Message-ID: <73f067bd-9454-4c9a-e49c-cb3550812843@gmail.com> (raw)
In-Reply-To: <20220323114516.4163532-1-berrange@redhat.com>

On 23/3/22 12:45, Daniel P. Berrangé wrote:
> The config key names were all wrong,

Since commit 2b678923bb@repo-lockdown (22 Aug 2020, 2 years ago...):

   feat: move to GitHub Actions

   BREAKING CHANGE: The deployment method and configuration
   options have changed.

https://github.com/dessant/repo-lockdown/commit/2b678923bbf2df051

> resulting in the repo lockdown
> throwing warnings:
> 
>    Unexpected input(s) 'pull-comment', 'lock-pull', 'close-pull',
>    valid inputs are ['github-token', 'exclude-issue-created-before',
>    'exclude-issue-labels', 'issue-labels', 'issue-comment',
>    'skip-closed-issue-comment', 'close-issue', 'lock-issue',
>    'issue-lock-reason', 'exclude-pr-created-before', 'exclude-pr-labels',
>    'pr-labels', 'pr-comment', 'skip-closed-pr-comment', 'close-pr',
>    'lock-pr', 'pr-lock-reason', 'process-only', 'log-output']
> 
> It still locked down the pull requests, due to its default config,
> but didn't leave the friendly message explaining why.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   .github/workflows/lockdown.yml | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

Preferably with description tweaked:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


      reply	other threads:[~2022-03-28 22:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-23 11:45 [PATCH] github: fix config mistake preventing repo lockdown commenting Daniel P. Berrangé
2022-03-28 22:05 ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73f067bd-9454-4c9a-e49c-cb3550812843@gmail.com \
    --to=philippe.mathieu.daude@gmail.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.