From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Jürgen Groß" <jgross@suse.com>, "Jan Beulich" <jbeulich@suse.com>
Cc: Igor Druzhinin <igor.druzhinin@citrix.com>,
roger.pau@citrix.com, wl@xen.org, xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH v2] x86/AMD: unbreak CPU hotplug on AMD systems without RstrFpErrPtrs
Date: Tue, 10 Dec 2019 12:37:07 +0000 [thread overview]
Message-ID: <74022d78-e4b4-11e2-95bc-7986fe2cb76e@citrix.com> (raw)
In-Reply-To: <df136147-76f4-841c-9f3e-2700fb856405@suse.com>
On 10/12/2019 10:26, Jürgen Groß wrote:
> On 10.12.19 11:10, Jan Beulich wrote:
>> On 04.12.2019 00:56, Igor Druzhinin wrote:
>>> If the feature is not present Xen will try to force X86_BUG_FPU_PTRS
>>> feature at CPU identification time. This is especially noticeable in
>>> PV-shim that usually hotplugs its vCPUs. We either need to restrict
>>> this
>>> action for boot CPU only or allow secondary CPUs to modify
>>> forced CPU capabilities at runtime. Choose the former since modifying
>>> forced capabilities out of boot path leaves the system in potentially
>>> inconsistent state.
>>>
>>> Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
>>
>> I've committed this to unstable, as per the outcome of the
>> community call.
What outcome? Yes technically your R-by is sufficient to get the patch
in, but you know very well there are open objections against this
version of the patch.
Also, you're actually in a position where you are reviewing your own
work, which is not how R-by is intended to work.
Furthermore, you will observe that there is an action item on me from
the call to come up with a less broken alternative which I'm genuinely
attempting to do.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-12-10 12:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 23:56 [Xen-devel] [PATCH v2] x86/AMD: unbreak CPU hotplug on AMD systems without RstrFpErrPtrs Igor Druzhinin
2019-12-04 9:13 ` Jan Beulich
2019-12-10 10:10 ` Jan Beulich
2019-12-10 10:26 ` Jürgen Groß
2019-12-10 12:37 ` Andrew Cooper [this message]
2019-12-10 13:58 ` Jan Beulich
2019-12-10 14:07 ` Igor Druzhinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74022d78-e4b4-11e2-95bc-7986fe2cb76e@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=igor.druzhinin@citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.