From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= <noralf@tronnes.org>
Subject: Re: [PATCH v2] drm/client: Fix double free in error path
Date: Fri, 13 Jul 2018 12:13:20 +0200
Message-ID: <74046c98-6ed3-3d07-18c8-b53b6211abc4@tronnes.org>
References: <20180712150414.46908-1-noralf@tronnes.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from smtp.domeneshop.no (smtp.domeneshop.no
 [IPv6:2a01:5b40:0:3005::1])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 5D9896F1E9
 for <dri-devel@lists.freedesktop.org>; Fri, 13 Jul 2018 10:13:27 +0000 (UTC)
In-Reply-To: <20180712150414.46908-1-noralf@tronnes.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: dri-devel@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: dri-devel@lists.freedesktop.org

CkRlbiAxMi4wNy4yMDE4IDE3LjA0LCBza3JldiBOb3JhbGYgVHLDuG5uZXM6Cj4gVGhpcyBmaXhl
cyBhIHN0YXRpYyBjaGVja2VyIHdhcm5pbmc6Cj4KPiAJZHJpdmVycy9ncHUvZHJtL2RybV9jbGll
bnQuYzoyODkgZHJtX2NsaWVudF9idWZmZXJfY3JlYXRlKCkKPiAJZXJyb3I6IGRvdWJsZSBmcmVl
IG9mICdidWZmZXInCj4KPiBFeHRlbmQgZHJtX2NsaWVudF9idWZmZXJfZGVsZXRlKCkgdG8gaGFu
ZGxlIHRoZSBjYXNlIHdoZW4gdGhlcmUncyBubwo+IGR1bWIgYnVmZmVyIGF0dGFjaGVkIGFuZCBk
cm9wIHRoZSBleHRyYSBrZnJlZS4KPgo+IEZpeGVzOiBjNzZmMGY3Y2I1NDYgKCJkcm06IEJlZ2lu
IGFuIEFQSSBmb3IgaW4ta2VybmVsIGNsaWVudHMiKQo+IFJlcG9ydGVkLWJ5OiBEYW4gQ2FycGVu
dGVyIDxkYW4uY2FycGVudGVyQG9yYWNsZS5jb20+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmll
bC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gU2lnbmVkLW9mZi1ieTogTm9yYWxmIFRyw7hubmVzIDxub3Jh
bGZAdHJvbm5lcy5vcmc+Cj4gUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0
ZXJAZmZ3bGwuY2g+Cj4gLS0tCj4KPiBDaGFuZ2VzIHNpbmNlIHZlcnNpb24gMToKPiAtIExldCBk
cm1fY2xpZW50X2J1ZmZlcl9kZWxldGUoKSBoYW5kbGUgYWxsIGZyZWVpbmcgKERhbmllbCBWZXR0
ZXIpCgpBcHBsaWVkLCB0aGFua3MgZm9yIHJldmlldyBhbmQgYW4gaW1wcm92ZWQgc29sdXRpb24u
CgpOb3JhbGYuCgo+ICAgZHJpdmVycy9ncHUvZHJtL2RybV9jbGllbnQuYyB8IDggKysrKy0tLS0K
PiAgIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4KPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9jbGllbnQuYyBiL2RyaXZlcnMvZ3B1L2Ry
bS9kcm1fY2xpZW50LmMKPiBpbmRleCA5YjE0MmY1OGQ0ODkuLmJhZmY1MGE0YzIzNCAxMDA2NDQK
PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NsaWVudC5jCj4gKysrIGIvZHJpdmVycy9ncHUv
ZHJtL2RybV9jbGllbnQuYwo+IEBAIC0yMTgsNyArMjE4LDkgQEAgc3RhdGljIHZvaWQgZHJtX2Ns
aWVudF9idWZmZXJfZGVsZXRlKHN0cnVjdCBkcm1fY2xpZW50X2J1ZmZlciAqYnVmZmVyKQo+ICAg
CWlmIChidWZmZXItPmdlbSkKPiAgIAkJZHJtX2dlbV9vYmplY3RfcHV0X3VubG9ja2VkKGJ1ZmZl
ci0+Z2VtKTsKPiAgIAo+IC0JZHJtX21vZGVfZGVzdHJveV9kdW1iKGRldiwgYnVmZmVyLT5oYW5k
bGUsIGJ1ZmZlci0+Y2xpZW50LT5maWxlKTsKPiArCWlmIChidWZmZXItPmhhbmRsZSkKPiArCQlk
cm1fbW9kZV9kZXN0cm95X2R1bWIoZGV2LCBidWZmZXItPmhhbmRsZSwgYnVmZmVyLT5jbGllbnQt
PmZpbGUpOwo+ICsKPiAgIAlrZnJlZShidWZmZXIpOwo+ICAgfQo+ICAgCj4gQEAgLTI0Myw3ICsy
NDUsNyBAQCBkcm1fY2xpZW50X2J1ZmZlcl9jcmVhdGUoc3RydWN0IGRybV9jbGllbnRfZGV2ICpj
bGllbnQsIHUzMiB3aWR0aCwgdTMyIGhlaWdodCwgdQo+ICAgCWR1bWJfYXJncy5icHAgPSBkcm1f
Zm9ybWF0X3BsYW5lX2NwcChmb3JtYXQsIDApICogODsKPiAgIAlyZXQgPSBkcm1fbW9kZV9jcmVh
dGVfZHVtYihkZXYsICZkdW1iX2FyZ3MsIGNsaWVudC0+ZmlsZSk7Cj4gICAJaWYgKHJldCkKPiAt
CQlnb3RvIGVycl9mcmVlOwo+ICsJCWdvdG8gZXJyX2RlbGV0ZTsKPiAgIAo+ICAgCWJ1ZmZlci0+
aGFuZGxlID0gZHVtYl9hcmdzLmhhbmRsZTsKPiAgIAlidWZmZXItPnBpdGNoID0gZHVtYl9hcmdz
LnBpdGNoOwo+IEBAIC0yNzYsOCArMjc4LDYgQEAgZHJtX2NsaWVudF9idWZmZXJfY3JlYXRlKHN0
cnVjdCBkcm1fY2xpZW50X2RldiAqY2xpZW50LCB1MzIgd2lkdGgsIHUzMiBoZWlnaHQsIHUKPiAg
IAo+ICAgZXJyX2RlbGV0ZToKPiAgIAlkcm1fY2xpZW50X2J1ZmZlcl9kZWxldGUoYnVmZmVyKTsK
PiAtZXJyX2ZyZWU6Cj4gLQlrZnJlZShidWZmZXIpOwo+ICAgCj4gICAJcmV0dXJuIEVSUl9QVFIo
cmV0KTsKPiAgIH0KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y
ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl
bAo=