From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH v5 for-4.9 3/4] hvm/dmop: Implement copy_{to, from}_guest_buf_offset() helpers Date: Mon, 10 Apr 2017 09:11:13 +0000 Message-ID: <74130a5f06984e2291a43ab80c665c08@AMSPEX02CL03.citrite.net> References: <1491593753-1181-1-git-send-email-andrew.cooper3@citrix.com> <1491593753-1181-3-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1491593753-1181-3-git-send-email-andrew.cooper3@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Xen-devel Cc: Andrew Cooper , Julien Grall , Jan Beulich List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IEFuZHJldyBDb29wZXIgW21haWx0 bzphbmRyZXcuY29vcGVyM0BjaXRyaXguY29tXQo+IFNlbnQ6IDA3IEFwcmlsIDIwMTcgMjA6MzYK PiBUbzogWGVuLWRldmVsIDx4ZW4tZGV2ZWxAbGlzdHMueGVuLm9yZz4KPiBDYzogQW5kcmV3IENv b3BlciA8QW5kcmV3LkNvb3BlcjNAY2l0cml4LmNvbT47IEphbiBCZXVsaWNoCj4gPEpCZXVsaWNo QHN1c2UuY29tPjsgUGF1bCBEdXJyYW50IDxQYXVsLkR1cnJhbnRAY2l0cml4LmNvbT47IEp1bGll biBHcmFsbAo+IDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4KPiBTdWJqZWN0OiBbUEFUQ0ggdjUgZm9y LTQuOSAzLzRdIGh2bS9kbW9wOiBJbXBsZW1lbnQKPiBjb3B5X3t0byxmcm9tfV9ndWVzdF9idWZf b2Zmc2V0KCkgaGVscGVycwo+IAo+IGNvcHlfe3RvLGZyb219X2d1ZXN0X2J1ZigpIGFyZSBub3cg aW1wbGVtZW50ZWQgdXNpbmcgYW4gb2Zmc2V0IG9mIDAuCj4gCj4gU2lnbmVkLW9mZi1ieTogQW5k cmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KPiAtLS0KPiBDQzogSmFuIEJl dWxpY2ggPEpCZXVsaWNoQHN1c2UuY29tPgo+IENDOiBQYXVsIER1cnJhbnQgPHBhdWwuZHVycmFu dEBjaXRyaXguY29tPgo+IENDOiBKdWxpZW4gR3JhbGwgPGp1bGllbi5ncmFsbEBhcm0uY29tPgo+ IC0tLQo+ICB4ZW4vYXJjaC94ODYvaHZtL2RtLmMgfCAzNCArKysrKysrKysrKysrKysrKysrKysr KystLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAxMCBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2h2bS9kbS5jIGIveGVuL2Fy Y2gveDg2L2h2bS9kbS5jCj4gaW5kZXggM2Q4YWU4OS4uZDU4NGFiYSAxMDA2NDQKPiAtLS0gYS94 ZW4vYXJjaC94ODYvaHZtL2RtLmMKPiArKysgYi94ZW4vYXJjaC94ODYvaHZtL2RtLmMKPiBAQCAt MzcsOSArMzcsOSBAQCBzdHJ1Y3QgZG1vcF9idWZzIHsKPiAgI3VuZGVmIE1BWF9OUl9CVUZTCj4g IH07Cj4gCj4gLXN0YXRpYyBib29sIF9yYXdfY29weV9mcm9tX2d1ZXN0X2J1ZigKPiArc3RhdGlj IGJvb2wgX3Jhd19jb3B5X2Zyb21fZ3Vlc3RfYnVmX29mZnNldCgKPiAgICAgIGNvbnN0IHN0cnVj dCBkbW9wX2J1ZnMgKmJ1ZnMsIHVuc2lnbmVkIGludCBpZHgsCj4gLSAgICB2b2lkICpkc3QsIHNp emVfdCBkc3RfYnl0ZXMpCj4gKyAgICBzaXplX3Qgb2Zmc2V0X2J5dGVzLCB2b2lkICpkc3QsIHNp emVfdCBkc3RfYnl0ZXMpCj4gIHsKPiAgICAgIHNpemVfdCBidWZfYnl0ZXM7Cj4gCj4gQEAgLTQ4 LDE3ICs0OCwyMCBAQCBzdGF0aWMgYm9vbCBfcmF3X2NvcHlfZnJvbV9ndWVzdF9idWYoCj4gCj4g ICAgICBidWZfYnl0ZXMgPSBidWZzLT5idWZbaWR4XS5zaXplOwo+IAo+IC0gICAgaWYgKCBkc3Rf Ynl0ZXMgPiBidWZfYnl0ZXMgKQo+ICsgICAgaWYgKCBvZmZzZXRfYnl0ZXMgPj0gZHN0X2J5dGVz IHx8Cj4gKyAgICAgICAgIChvZmZzZXRfYnl0ZXMgKyBkc3RfYnl0ZXMpIDwgb2Zmc2V0X2J5dGVz IHx8Cj4gKyAgICAgICAgIChvZmZzZXRfYnl0ZXMgKyBkc3RfYnl0ZXMpID4gZHN0X2J5dGVzICkK PiAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4gCj4gICAgICBtZW1zZXQoZHN0LCAwLCBkc3RfYnl0 ZXMpOwo+IAo+IC0gICAgcmV0dXJuICFjb3B5X2Zyb21fZ3Vlc3QoZHN0LCBidWZzLT5idWZbaWR4 XS5oLCBkc3RfYnl0ZXMpOwo+ICsgICAgcmV0dXJuICFjb3B5X2Zyb21fZ3Vlc3Rfb2Zmc2V0KGRz dCwgYnVmcy0+YnVmW2lkeF0uaCwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBvZmZzZXRfYnl0ZXMsIGRzdF9ieXRlcyk7CgpOb3Qgc3VyZSB3aGF0J3MgZ29pbmcgb24gaGVy ZS4gJ2J1Zl9ieXRlcycgaXMgYmVpbmcgYXNzaWduZWQgYnV0IG5vIGxvbmdlciBzZWVtcyB0byBi ZSB1c2VkIChzaW5jZSBpdCdzIGRyb3BwZWQgZnJvbSB0aGUgaWYgc3RhdGVtZW50KS4gQWxzbywg SSdtIG5vdCBlbnRpcmVseSBzdXJlIHdoYXQgcmFuZ2UgY2hlY2sgdGhhdCBpZiBzdGF0ZW1lbnQg aXMgdHJ5aW5nIHRvIHBlcmZvcm0uIENhbiB3ZSBhdCBsZWFzdCBoYXZlIGEgY29tbWVudCBpdCBp dCdzIGFjdHVhbGx5IGNvcnJlY3QgKHdoaWNoIEknbSBub3QgYXQgYWxsIGNvbnZpbmNlZCBvZiku CgogIFBhdWwKCj4gIH0KPiAKPiAtc3RhdGljIGJvb2wgX3Jhd19jb3B5X3RvX2d1ZXN0X2J1ZigK PiArc3RhdGljIGJvb2wgX3Jhd19jb3B5X3RvX2d1ZXN0X2J1Zl9vZmZzZXQoCj4gICAgICBzdHJ1 Y3QgZG1vcF9idWZzICpidWZzLCB1bnNpZ25lZCBpbnQgaWR4LAo+IC0gICAgY29uc3Qgdm9pZCAq c3JjLCBzaXplX3Qgc3JjX2J5dGVzKQo+ICsgICAgc2l6ZV90IG9mZnNldF9ieXRlcywgY29uc3Qg dm9pZCAqc3JjLCBzaXplX3Qgc3JjX2J5dGVzKQo+ICB7Cj4gICAgICBzaXplX3QgYnVmX2J5dGVz Owo+IAo+IEBAIC02NywxNyArNzAsMjggQEAgc3RhdGljIGJvb2wgX3Jhd19jb3B5X3RvX2d1ZXN0 X2J1ZigKPiAKPiAgICAgIGJ1Zl9ieXRlcyA9IGJ1ZnMtPmJ1ZltpZHhdLnNpemU7Cj4gCj4gLSAg ICBpZiAoIHNyY19ieXRlcyA+IGJ1Zl9ieXRlcyApCj4gKyAgICBpZiAoIG9mZnNldF9ieXRlcyA+ PSBzcmNfYnl0ZXMgfHwKPiArICAgICAgICAgKG9mZnNldF9ieXRlcyArIHNyY19ieXRlcykgPCBv ZmZzZXRfYnl0ZXMgfHwKPiArICAgICAgICAgKG9mZnNldF9ieXRlcyArIHNyY19ieXRlcykgPiBz cmNfYnl0ZXMgKQo+ICAgICAgICAgIHJldHVybiBmYWxzZTsKPiAKPiAtICAgIHJldHVybiAhY29w eV90b19ndWVzdChidWZzLT5idWZbaWR4XS5oLCBzcmMsIHNyY19ieXRlcyk7Cj4gKyAgICByZXR1 cm4gIWNvcHlfdG9fZ3Vlc3Rfb2Zmc2V0KGJ1ZnMtPmJ1ZltpZHhdLmgsIG9mZnNldF9ieXRlcywK PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3JjLCBzcmNfYnl0ZXMpOwo+ICB9 Cj4gCj4gKyNkZWZpbmUgY29weV9mcm9tX2d1ZXN0X2J1Zl9vZmZzZXQoYnVmcywgYnVmX2lkeCwg b2Zmc2V0X2J5dGVzLCBkc3QpIFwKPiArICAgIF9yYXdfY29weV9mcm9tX2d1ZXN0X2J1Zl9vZmZz ZXQoYnVmcywgYnVmX2lkeCwgb2Zmc2V0X2J5dGVzLCBcCj4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGRzdCwgc2l6ZW9mKCooZHN0KSkpCj4gKwo+ICsjZGVmaW5lIGNvcHlf dG9fZ3Vlc3RfYnVmX29mZnNldChidWZzLCBidWZfaWR4LCBvZmZzZXRfYnl0ZXMsIHNyYykgXAo+ ICsgICAgX3Jhd19jb3B5X3RvX2d1ZXN0X2J1Zl9vZmZzZXQoYnVmcywgYnVmX2lkeCwgb2Zmc2V0 X2J5dGVzLCBcCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzcmMsIHNpemVv ZigqKHNyYykpKQo+ICsKPiAgI2RlZmluZSBjb3B5X2Zyb21fZ3Vlc3RfYnVmKGJ1ZnMsIGJ1Zl9p ZHgsIGRzdCkgXAo+IC0gICAgX3Jhd19jb3B5X2Zyb21fZ3Vlc3RfYnVmKGJ1ZnMsIGJ1Zl9pZHgs IGRzdCwgc2l6ZW9mKCooZHN0KSkpCj4gKyAgICBjb3B5X2Zyb21fZ3Vlc3RfYnVmX29mZnNldChi dWZzLCBidWZfaWR4LCAwLCBkc3QpCj4gCj4gICNkZWZpbmUgY29weV90b19ndWVzdF9idWYoYnVm cywgYnVmX2lkeCwgc3JjKSBcCj4gLSAgICBfcmF3X2NvcHlfdG9fZ3Vlc3RfYnVmKGJ1ZnMsIGJ1 Zl9pZHgsIHNyYywgc2l6ZW9mKCooc3JjKSkpCj4gKyAgICBjb3B5X3RvX2d1ZXN0X2J1Zl9vZmZz ZXQoYnVmcywgYnVmX2lkeCwgMCwgc3JjKQo+IAo+ICBzdGF0aWMgaW50IHRyYWNrX2RpcnR5X3Zy YW0oc3RydWN0IGRvbWFpbiAqZCwgeGVuX3Bmbl90IGZpcnN0X3BmbiwKPiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBuciwgc3RydWN0IHhlbl9kbV9vcF9idWYgKmJ1 ZikKPiAtLQo+IDIuMS40CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpo dHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==