From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D97BC64E7A for ; Thu, 3 Dec 2020 13:16:02 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D0A020758 for ; Thu, 3 Dec 2020 13:16:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D0A020758 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.43458.78109 (Exim 4.92) (envelope-from ) id 1kkoSL-0001Ls-V3; Thu, 03 Dec 2020 13:15:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 43458.78109; Thu, 03 Dec 2020 13:15:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kkoSL-0001Ll-Rm; Thu, 03 Dec 2020 13:15:33 +0000 Received: by outflank-mailman (input) for mailman id 43458; Thu, 03 Dec 2020 13:15:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kkoSL-0001Lg-2d for xen-devel@lists.xenproject.org; Thu, 03 Dec 2020 13:15:33 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 270ee19b-4189-44c3-ad8a-878b09f60b4b; Thu, 03 Dec 2020 13:15:31 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CE182AC65; Thu, 3 Dec 2020 13:15:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 270ee19b-4189-44c3-ad8a-878b09f60b4b X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1607001331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LAnMPRGMjiZ34oYKcSxsgRANcqltXHwXg5c8BdJLG2E=; b=V0WgZ1/hDHoPQEMvAcYm/PAWQ0Mz+y7qlQ2nuQsCH+PdUi9pKV2SyUnZDGrq0mKuAPh1S/ QBUPveDFRYuH/3vj11jcfOfqefmL7X8eCGV8q0jmL3uOR88cIPJjLJ98wgyyCgFbvW0875 eQXknPFD80PDJiGY532dfMV8wz1PwQY= To: Paul Durrant , xen-devel@lists.xenproject.org Cc: Paul Durrant , Andrew Cooper , Anthony PERARD , Christian Lindig , David Scott , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Stefano Stabellini , Volodymyr Babchuk , Wei Liu References: <20201203124159.3688-1-paul@xen.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Subject: Re: [PATCH v5 0/4] Xen ABI feature control Message-ID: <7417f158-2cad-3909-2676-f9d5a90f4202@suse.com> Date: Thu, 3 Dec 2020 14:15:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201203124159.3688-1-paul@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pqkGRCiFSHE5wcRBaS0xucWU9Q3STh3Mh" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pqkGRCiFSHE5wcRBaS0xucWU9Q3STh3Mh Content-Type: multipart/mixed; boundary="bos9UewwtCQ7EMCE42hqcxFdw3FCsqRav"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Paul Durrant , xen-devel@lists.xenproject.org Cc: Paul Durrant , Andrew Cooper , Anthony PERARD , Christian Lindig , David Scott , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Stefano Stabellini , Volodymyr Babchuk , Wei Liu Message-ID: <7417f158-2cad-3909-2676-f9d5a90f4202@suse.com> Subject: Re: [PATCH v5 0/4] Xen ABI feature control References: <20201203124159.3688-1-paul@xen.org> In-Reply-To: <20201203124159.3688-1-paul@xen.org> --bos9UewwtCQ7EMCE42hqcxFdw3FCsqRav Content-Type: multipart/mixed; boundary="------------27780469BC73846B811AE500" Content-Language: en-US This is a multi-part message in MIME format. --------------27780469BC73846B811AE500 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 03.12.20 13:41, Paul Durrant wrote: > From: Paul Durrant >=20 > This series was previously called "evtchn: Introduce a per-guest knob t= o > control FIFO ABI". It is been extensively re-worked and extended to cov= er > another ABI feature. >=20 > Paul Durrant (4): > domctl: introduce a new domain create flag, > XEN_DOMCTL_CDF_evtchn_fifo, ... > domctl: introduce a new domain create flag, > XEN_DOMCTL_CDF_evtchn_upcall, ... > libxl: introduce a 'libxl_xen_abi_features' enumeration... > xl: introduce a 'xen-abi-features' option... >=20 > docs/man/xl.cfg.5.pod.in | 50 +++++++++++++++++++++++++++++++= + > tools/include/libxl.h | 10 +++++++ > tools/libs/light/libxl_arm.c | 22 +++++++++----- > tools/libs/light/libxl_create.c | 31 ++++++++++++++++++++ > tools/libs/light/libxl_types.idl | 7 +++++ > tools/libs/light/libxl_x86.c | 17 ++++++++++- > tools/ocaml/libs/xc/xenctrl.ml | 2 ++ > tools/ocaml/libs/xc/xenctrl.mli | 2 ++ > tools/xl/xl_parse.c | 50 ++++++++++++++++++++++++++++++-= - > xen/arch/arm/domain.c | 3 +- > xen/arch/arm/domain_build.c | 3 +- > xen/arch/arm/setup.c | 3 +- > xen/arch/x86/domain.c | 8 +++++ > xen/arch/x86/hvm/hvm.c | 3 ++ > xen/arch/x86/setup.c | 4 ++- > xen/common/domain.c | 3 +- > xen/common/event_channel.c | 24 +++++++++++++-- > xen/include/public/domctl.h | 6 +++- > 18 files changed, 229 insertions(+), 19 deletions(-) > --- > Cc: Andrew Cooper > Cc: Anthony PERARD > Cc: Christian Lindig > Cc: David Scott > Cc: George Dunlap > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Julien Grall > Cc: "Roger Pau Monn=C3=A9" > Cc: Stefano Stabellini > Cc: Volodymyr Babchuk > Cc: Wei Liu >=20 Do we want to add a create flag for each such feature, or would it be better to set options like those via hypfs? It would be fairly easy to ad dynamic hypfs paths, e.g.: /domain//abi-features/evtchn-fifo /domain//abi-features/evtchn-upcall which would have boolean type and could be set as long as the domain hasn't been started. xl support could even be rather generic, without the need to add coding to xl for each new feature. This is no objection to this series, but just an idea how to avoid extending the use of unstable interfaces. Thoughts? Juergen --------------27780469BC73846B811AE500 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------27780469BC73846B811AE500-- --bos9UewwtCQ7EMCE42hqcxFdw3FCsqRav-- --pqkGRCiFSHE5wcRBaS0xucWU9Q3STh3Mh Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAl/I5PEFAwAAAAAACgkQsN6d1ii/Ey9c 2ggAmYTu2bQb0Knk/XE8yJLLXCd8OtYMj+vA05qhjasJWlTVzMnXQhbexowGgmHeAXnkCUiYyW4o sdhFZo6uMnRKInmjGGpBrnN/+psjpDBEQgi/HMHCS2YcvS+x31c4Lhib9jUkei9mYFHYO7HifhQd n8p1tKZKOrVOT0Eo3lVaHC7NZPg92CMzyoKeVy+56Bsnp8WlEZNVBEji0cIfm0u/bAVTWcbYdEVI v71msPjP+dclC4FB3rhGVqpeEarKVJc2N5pCmCRdXxTjuW0dCWz+si2izbZSjx0a/CLu4MeKppUP 2gsuF2dmLNauHx27yfWuPnFHvLxLyeX3cPI3zIKaXA== =ugaD -----END PGP SIGNATURE----- --pqkGRCiFSHE5wcRBaS0xucWU9Q3STh3Mh--