From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752385AbcGCKxJ (ORCPT ); Sun, 3 Jul 2016 06:53:09 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:57567 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbcGCKxG (ORCPT ); Sun, 3 Jul 2016 06:53:06 -0400 Subject: Re: [PATCH v3 1/4] iio: potentiometer: mcp4531: Add support for MCP454x, MCP456x, MCP464x and MCP466x To: Florian Vaussard , devicetree@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Peter Rosin References: <1467272091-28087-1-git-send-email-florian.vaussard@heig-vd.ch> <1467272091-28087-2-git-send-email-florian.vaussard@heig-vd.ch> Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Slawomir Stepien , Joachim Eastwood , Matt Ranostay , Cristina Moraru , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Florian Vaussard From: Jonathan Cameron Message-ID: <74244eb3-92a8-5240-079e-4e5efb6990a4@kernel.org> Date: Sun, 3 Jul 2016 11:53:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1467272091-28087-2-git-send-email-florian.vaussard@heig-vd.ch> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/06/16 08:34, Florian Vaussard wrote: > This patch adds support for MCP454x, MCP456x, MCP464x and MCP466x parts. > The main difference with currently supported parts (MCP453x and alike) is > the addition of a non-volatile memory in order to recall the wiper setting > at power-on. This feature is currently not supported and only the > volatile memory is used to set the wiper. > > Acked-by: Peter Rosin > Signed-off-by: Florian Vaussard Applied to the togreg branch of iio.git - initially pushed out as testing for all the usual boring reasons (like reviewers aren't perfect ;) Jonathan > --- > drivers/iio/potentiometer/Kconfig | 6 ++-- > drivers/iio/potentiometer/mcp4531.c | 72 +++++++++++++++++++++++++++++++++++++ > 2 files changed, 76 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/potentiometer/Kconfig b/drivers/iio/potentiometer/Kconfig > index 0941c8d4..55c2414 100644 > --- a/drivers/iio/potentiometer/Kconfig > +++ b/drivers/iio/potentiometer/Kconfig > @@ -49,8 +49,10 @@ config MCP4531 > depends on I2C > help > Say yes here to build support for the Microchip > - MCP4531, MCP4532, MCP4551, MCP4552, > - MCP4631, MCP4632, MCP4651, MCP4652 > + MCP4531, MCP4532, MCP4541, MCP4542, > + MCP4551, MCP4552, MCP4561, MCP4562, > + MCP4631, MCP4632, MCP4641, MCP4642, > + MCP4651, MCP4652, MCP4661, MCP4662 > digital potentiomenter chips. > > To compile this driver as a module, choose M here: the > diff --git a/drivers/iio/potentiometer/mcp4531.c b/drivers/iio/potentiometer/mcp4531.c > index 3b72e1a..2251173 100644 > --- a/drivers/iio/potentiometer/mcp4531.c > +++ b/drivers/iio/potentiometer/mcp4531.c > @@ -8,12 +8,20 @@ > * DEVID #Wipers #Positions Resistor Opts (kOhm) i2c address > * mcp4531 1 129 5, 10, 50, 100 010111x > * mcp4532 1 129 5, 10, 50, 100 01011xx > + * mcp4541 1 129 5, 10, 50, 100 010111x > + * mcp4542 1 129 5, 10, 50, 100 01011xx > * mcp4551 1 257 5, 10, 50, 100 010111x > * mcp4552 1 257 5, 10, 50, 100 01011xx > + * mcp4561 1 257 5, 10, 50, 100 010111x > + * mcp4562 1 257 5, 10, 50, 100 01011xx > * mcp4631 2 129 5, 10, 50, 100 0101xxx > * mcp4632 2 129 5, 10, 50, 100 01011xx > + * mcp4641 2 129 5, 10, 50, 100 0101xxx > + * mcp4642 2 129 5, 10, 50, 100 01011xx > * mcp4651 2 257 5, 10, 50, 100 0101xxx > * mcp4652 2 257 5, 10, 50, 100 01011xx > + * mcp4661 2 257 5, 10, 50, 100 0101xxx > + * mcp4662 2 257 5, 10, 50, 100 01011xx > * > * This program is free software; you can redistribute it and/or modify it > * under the terms of the GNU General Public License version 2 as published by > @@ -37,18 +45,34 @@ enum mcp4531_type { > MCP453x_103, > MCP453x_503, > MCP453x_104, > + MCP454x_502, > + MCP454x_103, > + MCP454x_503, > + MCP454x_104, > MCP455x_502, > MCP455x_103, > MCP455x_503, > MCP455x_104, > + MCP456x_502, > + MCP456x_103, > + MCP456x_503, > + MCP456x_104, > MCP463x_502, > MCP463x_103, > MCP463x_503, > MCP463x_104, > + MCP464x_502, > + MCP464x_103, > + MCP464x_503, > + MCP464x_104, > MCP465x_502, > MCP465x_103, > MCP465x_503, > MCP465x_104, > + MCP466x_502, > + MCP466x_103, > + MCP466x_503, > + MCP466x_104, > }; > > static const struct mcp4531_cfg mcp4531_cfg[] = { > @@ -56,18 +80,34 @@ static const struct mcp4531_cfg mcp4531_cfg[] = { > [MCP453x_103] = { .wipers = 1, .max_pos = 128, .kohms = 10, }, > [MCP453x_503] = { .wipers = 1, .max_pos = 128, .kohms = 50, }, > [MCP453x_104] = { .wipers = 1, .max_pos = 128, .kohms = 100, }, > + [MCP454x_502] = { .wipers = 1, .max_pos = 128, .kohms = 5, }, > + [MCP454x_103] = { .wipers = 1, .max_pos = 128, .kohms = 10, }, > + [MCP454x_503] = { .wipers = 1, .max_pos = 128, .kohms = 50, }, > + [MCP454x_104] = { .wipers = 1, .max_pos = 128, .kohms = 100, }, > [MCP455x_502] = { .wipers = 1, .max_pos = 256, .kohms = 5, }, > [MCP455x_103] = { .wipers = 1, .max_pos = 256, .kohms = 10, }, > [MCP455x_503] = { .wipers = 1, .max_pos = 256, .kohms = 50, }, > [MCP455x_104] = { .wipers = 1, .max_pos = 256, .kohms = 100, }, > + [MCP456x_502] = { .wipers = 1, .max_pos = 256, .kohms = 5, }, > + [MCP456x_103] = { .wipers = 1, .max_pos = 256, .kohms = 10, }, > + [MCP456x_503] = { .wipers = 1, .max_pos = 256, .kohms = 50, }, > + [MCP456x_104] = { .wipers = 1, .max_pos = 256, .kohms = 100, }, > [MCP463x_502] = { .wipers = 2, .max_pos = 128, .kohms = 5, }, > [MCP463x_103] = { .wipers = 2, .max_pos = 128, .kohms = 10, }, > [MCP463x_503] = { .wipers = 2, .max_pos = 128, .kohms = 50, }, > [MCP463x_104] = { .wipers = 2, .max_pos = 128, .kohms = 100, }, > + [MCP464x_502] = { .wipers = 2, .max_pos = 128, .kohms = 5, }, > + [MCP464x_103] = { .wipers = 2, .max_pos = 128, .kohms = 10, }, > + [MCP464x_503] = { .wipers = 2, .max_pos = 128, .kohms = 50, }, > + [MCP464x_104] = { .wipers = 2, .max_pos = 128, .kohms = 100, }, > [MCP465x_502] = { .wipers = 2, .max_pos = 256, .kohms = 5, }, > [MCP465x_103] = { .wipers = 2, .max_pos = 256, .kohms = 10, }, > [MCP465x_503] = { .wipers = 2, .max_pos = 256, .kohms = 50, }, > [MCP465x_104] = { .wipers = 2, .max_pos = 256, .kohms = 100, }, > + [MCP466x_502] = { .wipers = 2, .max_pos = 256, .kohms = 5, }, > + [MCP466x_103] = { .wipers = 2, .max_pos = 256, .kohms = 10, }, > + [MCP466x_503] = { .wipers = 2, .max_pos = 256, .kohms = 50, }, > + [MCP466x_104] = { .wipers = 2, .max_pos = 256, .kohms = 100, }, > }; > > #define MCP4531_WRITE (0 << 2) > @@ -187,6 +227,14 @@ static const struct i2c_device_id mcp4531_id[] = { > { "mcp4532-103", MCP453x_103 }, > { "mcp4532-503", MCP453x_503 }, > { "mcp4532-104", MCP453x_104 }, > + { "mcp4541-502", MCP454x_502 }, > + { "mcp4541-103", MCP454x_103 }, > + { "mcp4541-503", MCP454x_503 }, > + { "mcp4541-104", MCP454x_104 }, > + { "mcp4542-502", MCP454x_502 }, > + { "mcp4542-103", MCP454x_103 }, > + { "mcp4542-503", MCP454x_503 }, > + { "mcp4542-104", MCP454x_104 }, > { "mcp4551-502", MCP455x_502 }, > { "mcp4551-103", MCP455x_103 }, > { "mcp4551-503", MCP455x_503 }, > @@ -195,6 +243,14 @@ static const struct i2c_device_id mcp4531_id[] = { > { "mcp4552-103", MCP455x_103 }, > { "mcp4552-503", MCP455x_503 }, > { "mcp4552-104", MCP455x_104 }, > + { "mcp4561-502", MCP456x_502 }, > + { "mcp4561-103", MCP456x_103 }, > + { "mcp4561-503", MCP456x_503 }, > + { "mcp4561-104", MCP456x_104 }, > + { "mcp4562-502", MCP456x_502 }, > + { "mcp4562-103", MCP456x_103 }, > + { "mcp4562-503", MCP456x_503 }, > + { "mcp4562-104", MCP456x_104 }, > { "mcp4631-502", MCP463x_502 }, > { "mcp4631-103", MCP463x_103 }, > { "mcp4631-503", MCP463x_503 }, > @@ -203,6 +259,14 @@ static const struct i2c_device_id mcp4531_id[] = { > { "mcp4632-103", MCP463x_103 }, > { "mcp4632-503", MCP463x_503 }, > { "mcp4632-104", MCP463x_104 }, > + { "mcp4641-502", MCP464x_502 }, > + { "mcp4641-103", MCP464x_103 }, > + { "mcp4641-503", MCP464x_503 }, > + { "mcp4641-104", MCP464x_104 }, > + { "mcp4642-502", MCP464x_502 }, > + { "mcp4642-103", MCP464x_103 }, > + { "mcp4642-503", MCP464x_503 }, > + { "mcp4642-104", MCP464x_104 }, > { "mcp4651-502", MCP465x_502 }, > { "mcp4651-103", MCP465x_103 }, > { "mcp4651-503", MCP465x_503 }, > @@ -211,6 +275,14 @@ static const struct i2c_device_id mcp4531_id[] = { > { "mcp4652-103", MCP465x_103 }, > { "mcp4652-503", MCP465x_503 }, > { "mcp4652-104", MCP465x_104 }, > + { "mcp4661-502", MCP466x_502 }, > + { "mcp4661-103", MCP466x_103 }, > + { "mcp4661-503", MCP466x_503 }, > + { "mcp4661-104", MCP466x_104 }, > + { "mcp4662-502", MCP466x_502 }, > + { "mcp4662-103", MCP466x_103 }, > + { "mcp4662-503", MCP466x_503 }, > + { "mcp4662-104", MCP466x_104 }, > {} > }; > MODULE_DEVICE_TABLE(i2c, mcp4531_id); > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH v3 1/4] iio: potentiometer: mcp4531: Add support for MCP454x, MCP456x, MCP464x and MCP466x Date: Sun, 3 Jul 2016 11:53:02 +0100 Message-ID: <74244eb3-92a8-5240-079e-4e5efb6990a4@kernel.org> References: <1467272091-28087-1-git-send-email-florian.vaussard@heig-vd.ch> <1467272091-28087-2-git-send-email-florian.vaussard@heig-vd.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1467272091-28087-2-git-send-email-florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Florian Vaussard , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Peter Rosin Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Slawomir Stepien , Joachim Eastwood , Matt Ranostay , Cristina Moraru , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Florian Vaussard List-Id: devicetree@vger.kernel.org On 30/06/16 08:34, Florian Vaussard wrote: > This patch adds support for MCP454x, MCP456x, MCP464x and MCP466x parts. > The main difference with currently supported parts (MCP453x and alike) is > the addition of a non-volatile memory in order to recall the wiper setting > at power-on. This feature is currently not supported and only the > volatile memory is used to set the wiper. > > Acked-by: Peter Rosin > Signed-off-by: Florian Vaussard Applied to the togreg branch of iio.git - initially pushed out as testing for all the usual boring reasons (like reviewers aren't perfect ;) Jonathan > --- > drivers/iio/potentiometer/Kconfig | 6 ++-- > drivers/iio/potentiometer/mcp4531.c | 72 +++++++++++++++++++++++++++++++++++++ > 2 files changed, 76 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/potentiometer/Kconfig b/drivers/iio/potentiometer/Kconfig > index 0941c8d4..55c2414 100644 > --- a/drivers/iio/potentiometer/Kconfig > +++ b/drivers/iio/potentiometer/Kconfig > @@ -49,8 +49,10 @@ config MCP4531 > depends on I2C > help > Say yes here to build support for the Microchip > - MCP4531, MCP4532, MCP4551, MCP4552, > - MCP4631, MCP4632, MCP4651, MCP4652 > + MCP4531, MCP4532, MCP4541, MCP4542, > + MCP4551, MCP4552, MCP4561, MCP4562, > + MCP4631, MCP4632, MCP4641, MCP4642, > + MCP4651, MCP4652, MCP4661, MCP4662 > digital potentiomenter chips. > > To compile this driver as a module, choose M here: the > diff --git a/drivers/iio/potentiometer/mcp4531.c b/drivers/iio/potentiometer/mcp4531.c > index 3b72e1a..2251173 100644 > --- a/drivers/iio/potentiometer/mcp4531.c > +++ b/drivers/iio/potentiometer/mcp4531.c > @@ -8,12 +8,20 @@ > * DEVID #Wipers #Positions Resistor Opts (kOhm) i2c address > * mcp4531 1 129 5, 10, 50, 100 010111x > * mcp4532 1 129 5, 10, 50, 100 01011xx > + * mcp4541 1 129 5, 10, 50, 100 010111x > + * mcp4542 1 129 5, 10, 50, 100 01011xx > * mcp4551 1 257 5, 10, 50, 100 010111x > * mcp4552 1 257 5, 10, 50, 100 01011xx > + * mcp4561 1 257 5, 10, 50, 100 010111x > + * mcp4562 1 257 5, 10, 50, 100 01011xx > * mcp4631 2 129 5, 10, 50, 100 0101xxx > * mcp4632 2 129 5, 10, 50, 100 01011xx > + * mcp4641 2 129 5, 10, 50, 100 0101xxx > + * mcp4642 2 129 5, 10, 50, 100 01011xx > * mcp4651 2 257 5, 10, 50, 100 0101xxx > * mcp4652 2 257 5, 10, 50, 100 01011xx > + * mcp4661 2 257 5, 10, 50, 100 0101xxx > + * mcp4662 2 257 5, 10, 50, 100 01011xx > * > * This program is free software; you can redistribute it and/or modify it > * under the terms of the GNU General Public License version 2 as published by > @@ -37,18 +45,34 @@ enum mcp4531_type { > MCP453x_103, > MCP453x_503, > MCP453x_104, > + MCP454x_502, > + MCP454x_103, > + MCP454x_503, > + MCP454x_104, > MCP455x_502, > MCP455x_103, > MCP455x_503, > MCP455x_104, > + MCP456x_502, > + MCP456x_103, > + MCP456x_503, > + MCP456x_104, > MCP463x_502, > MCP463x_103, > MCP463x_503, > MCP463x_104, > + MCP464x_502, > + MCP464x_103, > + MCP464x_503, > + MCP464x_104, > MCP465x_502, > MCP465x_103, > MCP465x_503, > MCP465x_104, > + MCP466x_502, > + MCP466x_103, > + MCP466x_503, > + MCP466x_104, > }; > > static const struct mcp4531_cfg mcp4531_cfg[] = { > @@ -56,18 +80,34 @@ static const struct mcp4531_cfg mcp4531_cfg[] = { > [MCP453x_103] = { .wipers = 1, .max_pos = 128, .kohms = 10, }, > [MCP453x_503] = { .wipers = 1, .max_pos = 128, .kohms = 50, }, > [MCP453x_104] = { .wipers = 1, .max_pos = 128, .kohms = 100, }, > + [MCP454x_502] = { .wipers = 1, .max_pos = 128, .kohms = 5, }, > + [MCP454x_103] = { .wipers = 1, .max_pos = 128, .kohms = 10, }, > + [MCP454x_503] = { .wipers = 1, .max_pos = 128, .kohms = 50, }, > + [MCP454x_104] = { .wipers = 1, .max_pos = 128, .kohms = 100, }, > [MCP455x_502] = { .wipers = 1, .max_pos = 256, .kohms = 5, }, > [MCP455x_103] = { .wipers = 1, .max_pos = 256, .kohms = 10, }, > [MCP455x_503] = { .wipers = 1, .max_pos = 256, .kohms = 50, }, > [MCP455x_104] = { .wipers = 1, .max_pos = 256, .kohms = 100, }, > + [MCP456x_502] = { .wipers = 1, .max_pos = 256, .kohms = 5, }, > + [MCP456x_103] = { .wipers = 1, .max_pos = 256, .kohms = 10, }, > + [MCP456x_503] = { .wipers = 1, .max_pos = 256, .kohms = 50, }, > + [MCP456x_104] = { .wipers = 1, .max_pos = 256, .kohms = 100, }, > [MCP463x_502] = { .wipers = 2, .max_pos = 128, .kohms = 5, }, > [MCP463x_103] = { .wipers = 2, .max_pos = 128, .kohms = 10, }, > [MCP463x_503] = { .wipers = 2, .max_pos = 128, .kohms = 50, }, > [MCP463x_104] = { .wipers = 2, .max_pos = 128, .kohms = 100, }, > + [MCP464x_502] = { .wipers = 2, .max_pos = 128, .kohms = 5, }, > + [MCP464x_103] = { .wipers = 2, .max_pos = 128, .kohms = 10, }, > + [MCP464x_503] = { .wipers = 2, .max_pos = 128, .kohms = 50, }, > + [MCP464x_104] = { .wipers = 2, .max_pos = 128, .kohms = 100, }, > [MCP465x_502] = { .wipers = 2, .max_pos = 256, .kohms = 5, }, > [MCP465x_103] = { .wipers = 2, .max_pos = 256, .kohms = 10, }, > [MCP465x_503] = { .wipers = 2, .max_pos = 256, .kohms = 50, }, > [MCP465x_104] = { .wipers = 2, .max_pos = 256, .kohms = 100, }, > + [MCP466x_502] = { .wipers = 2, .max_pos = 256, .kohms = 5, }, > + [MCP466x_103] = { .wipers = 2, .max_pos = 256, .kohms = 10, }, > + [MCP466x_503] = { .wipers = 2, .max_pos = 256, .kohms = 50, }, > + [MCP466x_104] = { .wipers = 2, .max_pos = 256, .kohms = 100, }, > }; > > #define MCP4531_WRITE (0 << 2) > @@ -187,6 +227,14 @@ static const struct i2c_device_id mcp4531_id[] = { > { "mcp4532-103", MCP453x_103 }, > { "mcp4532-503", MCP453x_503 }, > { "mcp4532-104", MCP453x_104 }, > + { "mcp4541-502", MCP454x_502 }, > + { "mcp4541-103", MCP454x_103 }, > + { "mcp4541-503", MCP454x_503 }, > + { "mcp4541-104", MCP454x_104 }, > + { "mcp4542-502", MCP454x_502 }, > + { "mcp4542-103", MCP454x_103 }, > + { "mcp4542-503", MCP454x_503 }, > + { "mcp4542-104", MCP454x_104 }, > { "mcp4551-502", MCP455x_502 }, > { "mcp4551-103", MCP455x_103 }, > { "mcp4551-503", MCP455x_503 }, > @@ -195,6 +243,14 @@ static const struct i2c_device_id mcp4531_id[] = { > { "mcp4552-103", MCP455x_103 }, > { "mcp4552-503", MCP455x_503 }, > { "mcp4552-104", MCP455x_104 }, > + { "mcp4561-502", MCP456x_502 }, > + { "mcp4561-103", MCP456x_103 }, > + { "mcp4561-503", MCP456x_503 }, > + { "mcp4561-104", MCP456x_104 }, > + { "mcp4562-502", MCP456x_502 }, > + { "mcp4562-103", MCP456x_103 }, > + { "mcp4562-503", MCP456x_503 }, > + { "mcp4562-104", MCP456x_104 }, > { "mcp4631-502", MCP463x_502 }, > { "mcp4631-103", MCP463x_103 }, > { "mcp4631-503", MCP463x_503 }, > @@ -203,6 +259,14 @@ static const struct i2c_device_id mcp4531_id[] = { > { "mcp4632-103", MCP463x_103 }, > { "mcp4632-503", MCP463x_503 }, > { "mcp4632-104", MCP463x_104 }, > + { "mcp4641-502", MCP464x_502 }, > + { "mcp4641-103", MCP464x_103 }, > + { "mcp4641-503", MCP464x_503 }, > + { "mcp4641-104", MCP464x_104 }, > + { "mcp4642-502", MCP464x_502 }, > + { "mcp4642-103", MCP464x_103 }, > + { "mcp4642-503", MCP464x_503 }, > + { "mcp4642-104", MCP464x_104 }, > { "mcp4651-502", MCP465x_502 }, > { "mcp4651-103", MCP465x_103 }, > { "mcp4651-503", MCP465x_503 }, > @@ -211,6 +275,14 @@ static const struct i2c_device_id mcp4531_id[] = { > { "mcp4652-103", MCP465x_103 }, > { "mcp4652-503", MCP465x_503 }, > { "mcp4652-104", MCP465x_104 }, > + { "mcp4661-502", MCP466x_502 }, > + { "mcp4661-103", MCP466x_103 }, > + { "mcp4661-503", MCP466x_503 }, > + { "mcp4661-104", MCP466x_104 }, > + { "mcp4662-502", MCP466x_502 }, > + { "mcp4662-103", MCP466x_103 }, > + { "mcp4662-503", MCP466x_503 }, > + { "mcp4662-104", MCP466x_104 }, > {} > }; > MODULE_DEVICE_TABLE(i2c, mcp4531_id); >