From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay-us1.mymailcheap.com (relay-us1.mymailcheap.com [51.81.35.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67DD317D3 for ; Mon, 2 May 2022 11:23:48 +0000 (UTC) Received: from relay5.mymailcheap.com (relay5.mymailcheap.com [159.100.241.64]) by relay-us1.mymailcheap.com (Postfix) with ESMTPS id 392E62021D for ; Mon, 2 May 2022 11:15:32 +0000 (UTC) Received: from relay4.mymailcheap.com (relay4.mymailcheap.com [137.74.80.154]) by relay5.mymailcheap.com (Postfix) with ESMTPS id 60A7F206D3 for ; Mon, 2 May 2022 11:15:23 +0000 (UTC) Received: from filter1.mymailcheap.com (filter1.mymailcheap.com [149.56.130.247]) by relay4.mymailcheap.com (Postfix) with ESMTPS id A953F20017; Mon, 2 May 2022 11:15:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by filter1.mymailcheap.com (Postfix) with ESMTP id 032542A2AE; Mon, 2 May 2022 11:15:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at filter1.mymailcheap.com Received: from filter1.mymailcheap.com ([127.0.0.1]) by localhost (filter1.mymailcheap.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7omtSMs1A6sZ; Mon, 2 May 2022 11:15:13 +0000 (UTC) Received: from mail20.mymailcheap.com (mail20.mymailcheap.com [51.83.111.147]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by filter1.mymailcheap.com (Postfix) with ESMTPS; Mon, 2 May 2022 11:15:13 +0000 (UTC) Received: from [127.0.0.1] (unknown [64.225.114.122]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail20.mymailcheap.com (Postfix) with ESMTPSA id 22815405D8; Mon, 2 May 2022 11:15:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=aosc.io; s=default; t=1651490112; bh=rUT7KoKRnXsktcX5dLdRErqPLZQBY5ISASFS45PYPuA=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=lVYp40sOuy3Tl/aX6MU6s+mzMFA9W2Tmea013ogW60hxMjcRcxsOgbiQEVZemFUtj iVulfzPiiJypRDVvvFEABrViGJodFpr2srOgzhCzKQ7+OWZzpCXY3t4ddxz2uSwv5p 88PHW6rI7Osufk7244uzAH31BVbtHTdG8DnEKDoY= Date: Mon, 02 May 2022 19:15:01 +0800 From: Icenowy Zheng To: Maxime Ripard , Ruslan Zalata CC: Guenter Roeck , Jean Delvare , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2=5D_hwmon=3A_=28sun4i-lradc=29_Add_dri?= =?US-ASCII?Q?ver_for_LRADC_found_on_Allwinner_A13/A20_SoC?= User-Agent: K-9 Mail for Android In-Reply-To: <20220502110010.q7vvdkdpaiz5acjl@houat> References: <20220428210906.29527-1-rz@fabmicro.ru> <20220502110010.q7vvdkdpaiz5acjl@houat> Message-ID: <7433B295-D896-4BF8-87DF-87EB89D7A550@aosc.io> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable =E4=BA=8E 2022=E5=B9=B45=E6=9C=882=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=887:= 00:10, Maxime Ripard =E5=86=99=E5=88=B0: >Hi, > >On Thu, Apr 28, 2022 at 09:09:03PM +0000, Ruslan Zalata wrote: >> Some Allwinner SoCs like A13, A20 or T2 are equipped with two-channel >> low rate (6 bit) ADC that is often used for extra keys=2E There's a dri= ver >> for that already implementing standard input device, but it has these >> limitations: 1) it cannot be used for general ADC data equisition, and >> 2) it uses only one LRADC channel of two available=2E >>=20 >> This driver provides basic hwmon interface to both channels of LRADC on >> such Allwinner SoCs=2E >>=20 >> Signed-off-by: Ruslan Zalata >> --- >> MAINTAINERS | 6 + >> drivers/hwmon/Kconfig | 13 ++ >> drivers/hwmon/Makefile | 1 + >> drivers/hwmon/sun4i-lradc-hwmon=2Ec | 280 ++++++++++++++++++++++++++++= ++ >> 4 files changed, 300 insertions(+) >> create mode 100644 drivers/hwmon/sun4i-lradc-hwmon=2Ec >>=20 >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 5e8c2f61176=2E=2Ed9c71e94133 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -18861,6 +18861,12 @@ S: Maintained >> F: Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-k= eys=2Eyaml >> F: drivers/input/keyboard/sun4i-lradc-keys=2Ec >> =20 >> +SUN4I LOW RES ADC HWMON DRIVER >> +M: Ruslan Zalata >> +L: linux-hwmon@vger=2Ekernel=2Eorg >> +S: Maintained >> +F: drivers/hwmon/sun4i-lradc-hwmon=2Ec >> + >> SUNDANCE NETWORK DRIVER >> M: Denis Kirjanov >> L: netdev@vger=2Ekernel=2Eorg >> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig >> index 68a8a27ab3b=2E=2E86776488a81 100644 >> --- a/drivers/hwmon/Kconfig >> +++ b/drivers/hwmon/Kconfig >> @@ -1691,6 +1691,19 @@ config SENSORS_SIS5595 >> This driver can also be built as a module=2E If so, the module >> will be called sis5595=2E >> =20 >> +config SENSORS_SUN4I_LRADC >> + tristate "Allwinner A13/A20 LRADC hwmon" >> + depends on ARCH_SUNXI && !KEYBOARD_SUN4I_LRADC >> + help >> + Say y here to support the LRADC found in Allwinner A13/A20 SoCs=2E >> + Both channels are supported=2E >> + >> + This driver can also be built as module=2E If so, the module >> + will be called sun4i-lradc-hwmon=2E >> + >> + This option is not compatible with KEYBOARD_SUN4I_LRADC, one >> + of these must be used at a time=2E > >How do you plan on enforcing that? > >I guess a better path forward would be to either register an hwmon >device in the original driver, or convert that driver to iio and use >iio-hwmon=2E I think this driver should be use IIO, and then try to probe an IIO input if possible=2E > >Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 692BBC433F5 for ; Mon, 2 May 2022 11:24:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:References: In-Reply-To:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XJGQelr93eUGoeuxZ725rXFZBXizWWOdh93JyN5sZIA=; b=LwPlbxSCiXiiZu R5Mj170a/JMlWPsrULTnTGF1OB8LC1GaxgNxzMJ9le+TxiKGa3z6raq1qRpu/V2KJbLGFPRIvyH7S PCPlbqVvcu7rtCf5CrWfDcwLHENdnZ/CZIyQLDmDv7ls0k4ibk9src8g6qXGEzd+0+ZkioJ0gbM/q 9o1aJVeYeaYSMVvM5MyQKRP+48xTMcUkC2NLYkI9vUXGAOLo/4HhGM8IIx1cNxcLoX/3+y1nIymx+ F3ig4ZcLSd6UHovVuLL5YqD/i8ce1IsO9sN416F9me4lh3xa32H7y+txjvWl9edwlYnqxbA8EMXPP RV0mXEuKX1oRsQ7kH1xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlU9g-000x7k-Ev; Mon, 02 May 2022 11:23:52 +0000 Received: from relay-us1.mymailcheap.com ([51.81.35.219]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlU9c-000x5J-Bk for linux-arm-kernel@lists.infradead.org; Mon, 02 May 2022 11:23:50 +0000 Received: from relay5.mymailcheap.com (relay5.mymailcheap.com [159.100.248.207]) by relay-us1.mymailcheap.com (Postfix) with ESMTPS id E53B02021F for ; Mon, 2 May 2022 11:15:50 +0000 (UTC) Received: from relay4.mymailcheap.com (relay4.mymailcheap.com [137.74.80.154]) by relay5.mymailcheap.com (Postfix) with ESMTPS id 4186A267CE for ; Mon, 2 May 2022 11:15:36 +0000 (UTC) Received: from filter1.mymailcheap.com (filter1.mymailcheap.com [149.56.130.247]) by relay4.mymailcheap.com (Postfix) with ESMTPS id A953F20017; Mon, 2 May 2022 11:15:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by filter1.mymailcheap.com (Postfix) with ESMTP id 032542A2AE; Mon, 2 May 2022 11:15:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at filter1.mymailcheap.com Received: from filter1.mymailcheap.com ([127.0.0.1]) by localhost (filter1.mymailcheap.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7omtSMs1A6sZ; Mon, 2 May 2022 11:15:13 +0000 (UTC) Received: from mail20.mymailcheap.com (mail20.mymailcheap.com [51.83.111.147]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by filter1.mymailcheap.com (Postfix) with ESMTPS; Mon, 2 May 2022 11:15:13 +0000 (UTC) Received: from [127.0.0.1] (unknown [64.225.114.122]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail20.mymailcheap.com (Postfix) with ESMTPSA id 22815405D8; Mon, 2 May 2022 11:15:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=aosc.io; s=default; t=1651490112; bh=rUT7KoKRnXsktcX5dLdRErqPLZQBY5ISASFS45PYPuA=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=lVYp40sOuy3Tl/aX6MU6s+mzMFA9W2Tmea013ogW60hxMjcRcxsOgbiQEVZemFUtj iVulfzPiiJypRDVvvFEABrViGJodFpr2srOgzhCzKQ7+OWZzpCXY3t4ddxz2uSwv5p 88PHW6rI7Osufk7244uzAH31BVbtHTdG8DnEKDoY= Date: Mon, 02 May 2022 19:15:01 +0800 From: Icenowy Zheng To: Maxime Ripard , Ruslan Zalata CC: Guenter Roeck , Jean Delvare , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2=5D_hwmon=3A_=28sun4i-lradc=29_Add_dri?= =?US-ASCII?Q?ver_for_LRADC_found_on_Allwinner_A13/A20_SoC?= User-Agent: K-9 Mail for Android In-Reply-To: <20220502110010.q7vvdkdpaiz5acjl@houat> References: <20220428210906.29527-1-rz@fabmicro.ru> <20220502110010.q7vvdkdpaiz5acjl@houat> Message-ID: <7433B295-D896-4BF8-87DF-87EB89D7A550@aosc.io> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220502_042348_582609_473C30CD X-CRM114-Status: GOOD ( 20.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Cgrkuo4gMjAyMuW5tDXmnIgy5pelIEdNVCswODowMCDkuIvljYg3OjAwOjEwLCBNYXhpbWUgUmlw YXJkIDxtYXhpbWVAY2Vybm8udGVjaD4g5YaZ5YiwOgo+SGksCj4KPk9uIFRodSwgQXByIDI4LCAy MDIyIGF0IDA5OjA5OjAzUE0gKzAwMDAsIFJ1c2xhbiBaYWxhdGEgd3JvdGU6Cj4+IFNvbWUgQWxs d2lubmVyIFNvQ3MgbGlrZSBBMTMsIEEyMCBvciBUMiBhcmUgZXF1aXBwZWQgd2l0aCB0d28tY2hh bm5lbAo+PiBsb3cgcmF0ZSAoNiBiaXQpIEFEQyB0aGF0IGlzIG9mdGVuIHVzZWQgZm9yIGV4dHJh IGtleXMuIFRoZXJlJ3MgYSBkcml2ZXIKPj4gZm9yIHRoYXQgYWxyZWFkeSBpbXBsZW1lbnRpbmcg c3RhbmRhcmQgaW5wdXQgZGV2aWNlLCBidXQgaXQgaGFzIHRoZXNlCj4+IGxpbWl0YXRpb25zOiAx KSBpdCBjYW5ub3QgYmUgdXNlZCBmb3IgZ2VuZXJhbCBBREMgZGF0YSBlcXVpc2l0aW9uLCBhbmQK Pj4gMikgaXQgdXNlcyBvbmx5IG9uZSBMUkFEQyBjaGFubmVsIG9mIHR3byBhdmFpbGFibGUuCj4+ IAo+PiBUaGlzIGRyaXZlciBwcm92aWRlcyBiYXNpYyBod21vbiBpbnRlcmZhY2UgdG8gYm90aCBj aGFubmVscyBvZiBMUkFEQyBvbgo+PiBzdWNoIEFsbHdpbm5lciBTb0NzLgo+PiAKPj4gU2lnbmVk LW9mZi1ieTogUnVzbGFuIFphbGF0YSA8cnpAZmFibWljcm8ucnU+Cj4+IC0tLQo+PiAgTUFJTlRB SU5FUlMgICAgICAgICAgICAgICAgICAgICAgIHwgICA2ICsKPj4gIGRyaXZlcnMvaHdtb24vS2Nv bmZpZyAgICAgICAgICAgICB8ICAxMyArKwo+PiAgZHJpdmVycy9od21vbi9NYWtlZmlsZSAgICAg ICAgICAgIHwgICAxICsKPj4gIGRyaXZlcnMvaHdtb24vc3VuNGktbHJhZGMtaHdtb24uYyB8IDI4 MCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPj4gIDQgZmlsZXMgY2hhbmdlZCwgMzAw IGluc2VydGlvbnMoKykKPj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2h3bW9uL3N1bjRp LWxyYWRjLWh3bW9uLmMKPj4gCj4+IGRpZmYgLS1naXQgYS9NQUlOVEFJTkVSUyBiL01BSU5UQUlO RVJTCj4+IGluZGV4IDVlOGMyZjYxMTc2Li5kOWM3MWU5NDEzMyAxMDA2NDQKPj4gLS0tIGEvTUFJ TlRBSU5FUlMKPj4gKysrIGIvTUFJTlRBSU5FUlMKPj4gQEAgLTE4ODYxLDYgKzE4ODYxLDEyIEBA IFM6CU1haW50YWluZWQKPj4gIEY6CURvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9p bnB1dC9hbGx3aW5uZXIsc3VuNGktYTEwLWxyYWRjLWtleXMueWFtbAo+PiAgRjoJZHJpdmVycy9p bnB1dC9rZXlib2FyZC9zdW40aS1scmFkYy1rZXlzLmMKPj4gIAo+PiArU1VONEkgTE9XIFJFUyBB REMgSFdNT04gRFJJVkVSCj4+ICtNOglSdXNsYW4gWmFsYXRhIDxyekBmYWJtaWNyby5ydT4KPj4g K0w6CWxpbnV4LWh3bW9uQHZnZXIua2VybmVsLm9yZwo+PiArUzoJTWFpbnRhaW5lZAo+PiArRjoJ ZHJpdmVycy9od21vbi9zdW40aS1scmFkYy1od21vbi5jCj4+ICsKPj4gIFNVTkRBTkNFIE5FVFdP UksgRFJJVkVSCj4+ICBNOglEZW5pcyBLaXJqYW5vdiA8a2RhQGxpbnV4LXBvd2VycGMub3JnPgo+ PiAgTDoJbmV0ZGV2QHZnZXIua2VybmVsLm9yZwo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9od21v bi9LY29uZmlnIGIvZHJpdmVycy9od21vbi9LY29uZmlnCj4+IGluZGV4IDY4YThhMjdhYjNiLi44 Njc3NjQ4OGE4MSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9od21vbi9LY29uZmlnCj4+ICsrKyBi L2RyaXZlcnMvaHdtb24vS2NvbmZpZwo+PiBAQCAtMTY5MSw2ICsxNjkxLDE5IEBAIGNvbmZpZyBT RU5TT1JTX1NJUzU1OTUKPj4gIAkgIFRoaXMgZHJpdmVyIGNhbiBhbHNvIGJlIGJ1aWx0IGFzIGEg bW9kdWxlLiBJZiBzbywgdGhlIG1vZHVsZQo+PiAgCSAgd2lsbCBiZSBjYWxsZWQgc2lzNTU5NS4K Pj4gIAo+PiArY29uZmlnIFNFTlNPUlNfU1VONElfTFJBREMKPj4gKwl0cmlzdGF0ZSAiQWxsd2lu bmVyIEExMy9BMjAgTFJBREMgaHdtb24iCj4+ICsJZGVwZW5kcyBvbiBBUkNIX1NVTlhJICYmICFL RVlCT0FSRF9TVU40SV9MUkFEQwo+PiArCWhlbHAKPj4gKwkgIFNheSB5IGhlcmUgdG8gc3VwcG9y dCB0aGUgTFJBREMgZm91bmQgaW4gQWxsd2lubmVyIEExMy9BMjAgU29Dcy4KPj4gKwkgIEJvdGgg Y2hhbm5lbHMgYXJlIHN1cHBvcnRlZC4KPj4gKwo+PiArCSAgVGhpcyBkcml2ZXIgY2FuIGFsc28g YmUgYnVpbHQgYXMgbW9kdWxlLiBJZiBzbywgdGhlIG1vZHVsZQo+PiArCSAgd2lsbCBiZSBjYWxs ZWQgc3VuNGktbHJhZGMtaHdtb24uCj4+ICsKPj4gKwkgIFRoaXMgb3B0aW9uIGlzIG5vdCBjb21w YXRpYmxlIHdpdGggS0VZQk9BUkRfU1VONElfTFJBREMsIG9uZQo+PiArCSAgb2YgdGhlc2UgbXVz dCBiZSB1c2VkIGF0IGEgdGltZS4KPgo+SG93IGRvIHlvdSBwbGFuIG9uIGVuZm9yY2luZyB0aGF0 Pwo+Cj5JIGd1ZXNzIGEgYmV0dGVyIHBhdGggZm9yd2FyZCB3b3VsZCBiZSB0byBlaXRoZXIgcmVn aXN0ZXIgYW4gaHdtb24KPmRldmljZSBpbiB0aGUgb3JpZ2luYWwgZHJpdmVyLCBvciBjb252ZXJ0 IHRoYXQgZHJpdmVyIHRvIGlpbyBhbmQgdXNlCj5paW8taHdtb24uCgpJIHRoaW5rIHRoaXMgZHJp dmVyIHNob3VsZCBiZSB1c2UgSUlPLCBhbmQgdGhlbiB0cnkgdG8gcHJvYmUgYW4gSUlPIGlucHV0 CmlmIHBvc3NpYmxlLgoKPgo+TWF4aW1lCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==