From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [alsa-devel] [PATCH 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver Date: Fri, 24 Jan 2020 04:28:26 +0300 Message-ID: <743d6d7d-f29c-191a-853b-414250ca38df@gmail.com> References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-8-git-send-email-spujar@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1579530198-13431-8-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sameer Pujar , perex-/Fr2/VpizcU@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org 20.01.2020 17:23, Sameer Pujar пишет: [snip] > +static bool tegra_admaif_wr_reg(struct device *dev, unsigned int reg) > +{ > + struct tegra_admaif *admaif = dev_get_drvdata(dev); > + unsigned int ch_stride = TEGRA_ADMAIF_CHANNEL_REG_STRIDE; > + unsigned int num_ch = admaif->soc_data->num_ch; > + unsigned int rx_base = admaif->soc_data->rx_base; > + unsigned int tx_base = admaif->soc_data->tx_base; > + unsigned int global_base = admaif->soc_data->global_base; > + unsigned int reg_max = admaif->soc_data->regmap_conf->max_register; > + unsigned int rx_max = rx_base + (num_ch * ch_stride); > + unsigned int tx_max = tx_base + (num_ch * ch_stride); > + > + if ((reg >= rx_base) && (reg < rx_max)) { The braces are not needed around the comparisons because they precede the AND. Same for all other similar occurrences in the code. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85F76C35240 for ; Fri, 24 Jan 2020 01:28:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44953207FF for ; Fri, 24 Jan 2020 01:28:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IWhyOeQU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730055AbgAXB2c (ORCPT ); Thu, 23 Jan 2020 20:28:32 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:45879 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728799AbgAXB2b (ORCPT ); Thu, 23 Jan 2020 20:28:31 -0500 Received: by mail-lj1-f195.google.com with SMTP id j26so526308ljc.12; Thu, 23 Jan 2020 17:28:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WI+Ptr4jWGvf9sG0CsP+d/rPdqVcRiXjBDng4X6qfAo=; b=IWhyOeQUSmo3xu9H4u2oZLkCl+B28KSQ//kzmtueEdrjJiCkgUjc7xObfFUYgg/3Jt WN6L5BVjS+aylpgwq+HKPF6cSQGg2SpcNPPqkpyNtIijZZWdxhJceRTrR0bGrlLxcPDk ZQcuU4cVj9OwzCr0XvpZUQSIasa3gbZUYiBewpoDd+cDqe6z0Dl8/isN64cRDYqFaZX2 1I50PCGlrYq8sBgAMOJKGS+QhZPiC4lyjXWNtp+pw3giQ027CEr6U1bMUTkndSUP7cuK bE4SsWAHFJ90iDLnniZGCZ3IfhKuWbiQQIwshPTNGUrrTjYFhFk7kSkAZm7ErxlcB6Mv Hlqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WI+Ptr4jWGvf9sG0CsP+d/rPdqVcRiXjBDng4X6qfAo=; b=JmGaLPmBw0NTs9Qi4ZpLV8BNQSbayEM4XauM3Dm6L75IyExcbByPkSemAmFwLC7rao IuCbekaI616cxTWaRtLMi9w6bB2FRlgCo6Y5zGNHd8iK3oq5P0axUAfWqWuu4myCsD/h A0WpmupPylFJO04lCyJnmZHE46oXv2g5Q4LthtI4IXAMCLJXhX/hZh/nSX8Q0Yeyg5Sb 5GJjd7z058I+eg1N+3Q+p8oou+zLhr8CjuGqVyC264Vm8K7d4QR0aip43rce9n9nuRTV bZfyDp6ioNTPhya7G0BtV2p5juq88zXxkTdBo/x4OCGMbSNjqN52LdivMIW5srUbG68E XD6g== X-Gm-Message-State: APjAAAXuLtpRr1IdTLC2sMq6Q7Alld/NSICuTKz4zyBd4iJ5OantKuGN WkC0e2sm4XZanUuXItpx7J4= X-Google-Smtp-Source: APXvYqwGOnXwDuyIxTBQaJTSzHJLm33JXg0GYndn6ydyGv3O+5zNh+qRhrfYF9Q5iyLM8WQFQtOLfQ== X-Received: by 2002:a2e:9592:: with SMTP id w18mr711637ljh.98.1579829309536; Thu, 23 Jan 2020 17:28:29 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id l28sm1886927lfk.21.2020.01.23.17.28.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2020 17:28:28 -0800 (PST) Subject: Re: [alsa-devel] [PATCH 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver To: Sameer Pujar , perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, atalambedu@nvidia.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, jonathanh@nvidia.com, viswanathl@nvidia.com, sharadg@nvidia.com, broonie@kernel.org, thierry.reding@gmail.com, linux-tegra@vger.kernel.org, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-8-git-send-email-spujar@nvidia.com> From: Dmitry Osipenko Message-ID: <743d6d7d-f29c-191a-853b-414250ca38df@gmail.com> Date: Fri, 24 Jan 2020 04:28:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <1579530198-13431-8-git-send-email-spujar@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 20.01.2020 17:23, Sameer Pujar пишет: [snip] > +static bool tegra_admaif_wr_reg(struct device *dev, unsigned int reg) > +{ > + struct tegra_admaif *admaif = dev_get_drvdata(dev); > + unsigned int ch_stride = TEGRA_ADMAIF_CHANNEL_REG_STRIDE; > + unsigned int num_ch = admaif->soc_data->num_ch; > + unsigned int rx_base = admaif->soc_data->rx_base; > + unsigned int tx_base = admaif->soc_data->tx_base; > + unsigned int global_base = admaif->soc_data->global_base; > + unsigned int reg_max = admaif->soc_data->regmap_conf->max_register; > + unsigned int rx_max = rx_base + (num_ch * ch_stride); > + unsigned int tx_max = tx_base + (num_ch * ch_stride); > + > + if ((reg >= rx_base) && (reg < rx_max)) { The braces are not needed around the comparisons because they precede the AND. Same for all other similar occurrences in the code. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3625FC35240 for ; Fri, 24 Jan 2020 01:29:29 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B56F12071E for ; Fri, 24 Jan 2020 01:29:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="NKpLMEUG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IWhyOeQU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B56F12071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 17C38166B; Fri, 24 Jan 2020 02:28:37 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 17C38166B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579829367; bh=0uyl4OkZSBhc/arLXJnU4cEQyO5Q1wKQEO71g6/sdNs=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NKpLMEUGi3+8+lfH3zmnczbyZCU7vFuq1HdU9QJRSRchQ3cF2mSHHoWJ3aSTvyvdA UzQqvZ/VpC6gNIw5Zc+65/Bj4sKneGvK/JChg4uIArYF0qnDdijeNCDlURucSN9UKb HWhqgxG17GoIssoul1ZNW6T+Dbws8tf1AM8RDzh8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 900F8F8015B; Fri, 24 Jan 2020 02:28:36 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 00093F801D9; Fri, 24 Jan 2020 02:28:33 +0100 (CET) Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 04C6BF80112 for ; Fri, 24 Jan 2020 02:28:30 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 04C6BF80112 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IWhyOeQU" Received: by mail-lj1-x243.google.com with SMTP id y6so606797lji.0 for ; Thu, 23 Jan 2020 17:28:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WI+Ptr4jWGvf9sG0CsP+d/rPdqVcRiXjBDng4X6qfAo=; b=IWhyOeQUSmo3xu9H4u2oZLkCl+B28KSQ//kzmtueEdrjJiCkgUjc7xObfFUYgg/3Jt WN6L5BVjS+aylpgwq+HKPF6cSQGg2SpcNPPqkpyNtIijZZWdxhJceRTrR0bGrlLxcPDk ZQcuU4cVj9OwzCr0XvpZUQSIasa3gbZUYiBewpoDd+cDqe6z0Dl8/isN64cRDYqFaZX2 1I50PCGlrYq8sBgAMOJKGS+QhZPiC4lyjXWNtp+pw3giQ027CEr6U1bMUTkndSUP7cuK bE4SsWAHFJ90iDLnniZGCZ3IfhKuWbiQQIwshPTNGUrrTjYFhFk7kSkAZm7ErxlcB6Mv Hlqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WI+Ptr4jWGvf9sG0CsP+d/rPdqVcRiXjBDng4X6qfAo=; b=nrafs5a/vm4j52NOwnfGk7bI1Kte22KEoRiboiTyZbzCQulHNfksLBJiC/rvTiU1kD 3JSSq6s/BKsUeqvACBongJyzKIjnEyEBb8Fn/cZGh8Os1mlOz86NJ9B0NI9Qkp5/KHt6 FrtlYBi5Ef6JOggqqoa7OvbS99o3S+1uco9BI8UJ3FiVKAHJqJ2QhQTrlN7imo0Kq8gG rUNpgOUd/CCsIe2ZU60l47us+B6Q1zXwKA/yETLWlutVbQIDsWZlpzhuE9ryWKL4nbEE CZR1cnfl+ZbWX+79QRUTKBZHhHfDAzGgZfjV3+elyEoQJ1i5lDDSo78Z82vQFKtQf5Bx D3UA== X-Gm-Message-State: APjAAAUopc+1YuWa6T6RQKGDNFahH8Gd541KHTRsUURUBWoZ3gYHDrL0 K3t5BXGykO69L5yxJr4rkKU= X-Google-Smtp-Source: APXvYqwGOnXwDuyIxTBQaJTSzHJLm33JXg0GYndn6ydyGv3O+5zNh+qRhrfYF9Q5iyLM8WQFQtOLfQ== X-Received: by 2002:a2e:9592:: with SMTP id w18mr711637ljh.98.1579829309536; Thu, 23 Jan 2020 17:28:29 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id l28sm1886927lfk.21.2020.01.23.17.28.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2020 17:28:28 -0800 (PST) To: Sameer Pujar , perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-8-git-send-email-spujar@nvidia.com> From: Dmitry Osipenko Message-ID: <743d6d7d-f29c-191a-853b-414250ca38df@gmail.com> Date: Fri, 24 Jan 2020 04:28:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <1579530198-13431-8-git-send-email-spujar@nvidia.com> Content-Language: en-US Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, jonathanh@nvidia.com, viswanathl@nvidia.com, linux-tegra@vger.kernel.org, broonie@kernel.org, atalambedu@nvidia.com, sharadg@nvidia.com, thierry.reding@gmail.com, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com Subject: Re: [alsa-devel] [PATCH 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" MjAuMDEuMjAyMCAxNzoyMywgU2FtZWVyIFB1amFyINC/0LjRiNC10YI6CltzbmlwXQo+ICtzdGF0 aWMgYm9vbCB0ZWdyYV9hZG1haWZfd3JfcmVnKHN0cnVjdCBkZXZpY2UgKmRldiwgdW5zaWduZWQg aW50IHJlZykKPiArewo+ICsJc3RydWN0IHRlZ3JhX2FkbWFpZiAqYWRtYWlmID0gZGV2X2dldF9k cnZkYXRhKGRldik7Cj4gKwl1bnNpZ25lZCBpbnQgY2hfc3RyaWRlID0gVEVHUkFfQURNQUlGX0NI QU5ORUxfUkVHX1NUUklERTsKPiArCXVuc2lnbmVkIGludCBudW1fY2ggPSBhZG1haWYtPnNvY19k YXRhLT5udW1fY2g7Cj4gKwl1bnNpZ25lZCBpbnQgcnhfYmFzZSA9IGFkbWFpZi0+c29jX2RhdGEt PnJ4X2Jhc2U7Cj4gKwl1bnNpZ25lZCBpbnQgdHhfYmFzZSA9IGFkbWFpZi0+c29jX2RhdGEtPnR4 X2Jhc2U7Cj4gKwl1bnNpZ25lZCBpbnQgZ2xvYmFsX2Jhc2UgPSBhZG1haWYtPnNvY19kYXRhLT5n bG9iYWxfYmFzZTsKPiArCXVuc2lnbmVkIGludCByZWdfbWF4ID0gYWRtYWlmLT5zb2NfZGF0YS0+ cmVnbWFwX2NvbmYtPm1heF9yZWdpc3RlcjsKPiArCXVuc2lnbmVkIGludCByeF9tYXggPSByeF9i YXNlICsgKG51bV9jaCAqIGNoX3N0cmlkZSk7Cj4gKwl1bnNpZ25lZCBpbnQgdHhfbWF4ID0gdHhf YmFzZSArIChudW1fY2ggKiBjaF9zdHJpZGUpOwo+ICsKPiArCWlmICgocmVnID49IHJ4X2Jhc2Up ICYmIChyZWcgPCByeF9tYXgpKSB7CgpUaGUgYnJhY2VzIGFyZSBub3QgbmVlZGVkIGFyb3VuZCB0 aGUgY29tcGFyaXNvbnMgYmVjYXVzZSB0aGV5IHByZWNlZGUKdGhlIEFORC4gU2FtZSBmb3IgYWxs IG90aGVyIHNpbWlsYXIgb2NjdXJyZW5jZXMgaW4gdGhlIGNvZGUuCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFs c2EtZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRwczovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK