From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD0AC433E0 for ; Thu, 30 Jul 2020 22:45:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5374D20672 for ; Thu, 30 Jul 2020 22:45:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730562AbgG3Wpf (ORCPT ); Thu, 30 Jul 2020 18:45:35 -0400 Received: from www62.your-server.de ([213.133.104.62]:35206 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730416AbgG3Wpe (ORCPT ); Thu, 30 Jul 2020 18:45:34 -0400 Received: from sslproxy03.your-server.de ([88.198.220.132]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1k1HIo-0008Dp-IE; Fri, 31 Jul 2020 00:45:30 +0200 Received: from [178.196.57.75] (helo=pc-9.home) by sslproxy03.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k1HIo-0003Zs-7C; Fri, 31 Jul 2020 00:45:30 +0200 Subject: Re: [PATCH bpf-next 1/1] arm64: bpf: Add BPF exception tables To: Jean-Philippe Brucker Cc: Qian Cai , linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org, songliubraving@fb.com, andriin@fb.com, catalin.marinas@arm.com, john.fastabend@gmail.com, ast@kernel.org, zlim.lnx@gmail.com, kpsingh@chromium.org, yhs@fb.com, will@kernel.org, kafai@fb.com, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200728152122.1292756-1-jean-philippe@linaro.org> <20200728152122.1292756-2-jean-philippe@linaro.org> <20200730122855.GA3773@lca.pw> <20200730142213.GB1529030@myrica> <20200730211453.GA79372@lophozonia> From: Daniel Borkmann Message-ID: <74433d9e-012d-a20f-129f-ce934e8090aa@iogearbox.net> Date: Fri, 31 Jul 2020 00:45:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20200730211453.GA79372@lophozonia> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.3/25889/Thu Jul 30 17:03:53 2020) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/30/20 11:14 PM, Jean-Philippe Brucker wrote: > On Thu, Jul 30, 2020 at 09:47:39PM +0200, Daniel Borkmann wrote: >> On 7/30/20 4:22 PM, Jean-Philippe Brucker wrote: >>> On Thu, Jul 30, 2020 at 08:28:56AM -0400, Qian Cai wrote: >>>> On Tue, Jul 28, 2020 at 05:21:26PM +0200, Jean-Philippe Brucker wrote: >>>>> When a tracing BPF program attempts to read memory without using the >>>>> bpf_probe_read() helper, the verifier marks the load instruction with >>>>> the BPF_PROBE_MEM flag. Since the arm64 JIT does not currently recognize >>>>> this flag it falls back to the interpreter. >>>>> >>>>> Add support for BPF_PROBE_MEM, by appending an exception table to the >>>>> BPF program. If the load instruction causes a data abort, the fixup >>>>> infrastructure finds the exception table and fixes up the fault, by >>>>> clearing the destination register and jumping over the faulting >>>>> instruction. >>>>> >>>>> To keep the compact exception table entry format, inspect the pc in >>>>> fixup_exception(). A more generic solution would add a "handler" field >>>>> to the table entry, like on x86 and s390. >>>>> >>>>> Signed-off-by: Jean-Philippe Brucker >>>> >>>> This will fail to compile on arm64, >>>> >>>> https://gitlab.com/cailca/linux-mm/-/blob/master/arm64.config >>>> >>>> arch/arm64/mm/extable.o: In function `fixup_exception': >>>> arch/arm64/mm/extable.c:19: undefined reference to `arm64_bpf_fixup_exception' >>> >>> Thanks for the report, I attached a fix. Daniel, can I squash it and >>> resend as v2 or is it too late? >> >> If you want I can squash your attached snippet into the original patch of >> yours. If you want to send a v2 that is fine as well of course. Let me know. > > Yes please squash it into the original patch, sorry for the mess Done, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 554ACC433E0 for ; Thu, 30 Jul 2020 22:47:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C4C720838 for ; Thu, 30 Jul 2020 22:47:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Qg9R5wLY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C4C720838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=iogearbox.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=p41M4yUuIkPm2tp4qH3H2E4dUMJOwMSOxfUUlvTMw18=; b=Qg9R5wLYuTFXh24fNUo6qDr96 aNseqVGBXHhq9ZXk97YyPWfmISm5qx95MpVkte7zLoKGhhjoR851P6OxPS5Og8IJsIM1/4y/jAiwI bPj6MgpSNGtMPANp5QIhPNULHcpZOPCMG7ZwNkG9esXJvvPOec2llod9KAs4AT51ncMxNMaK1LGnR G1iABy3JL6CdtjYvpX1r9lM7esb+rF3qt0XZqSMi3VYEAVddnTMV9iEGSVOzIrmwF4AfoOVkpUcBs bA1UymIvSgnz3CMvDYs7lyYHkmOD3CWypG+Z3PmxKI7PoKMBsmXDa85bCb0VEDcaUT091JneLkdGW EDFsnUfBA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1HIv-00075v-Gi; Thu, 30 Jul 2020 22:45:37 +0000 Received: from www62.your-server.de ([213.133.104.62]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1HIs-000756-48 for linux-arm-kernel@lists.infradead.org; Thu, 30 Jul 2020 22:45:35 +0000 Received: from sslproxy03.your-server.de ([88.198.220.132]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1k1HIo-0008Dp-IE; Fri, 31 Jul 2020 00:45:30 +0200 Received: from [178.196.57.75] (helo=pc-9.home) by sslproxy03.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k1HIo-0003Zs-7C; Fri, 31 Jul 2020 00:45:30 +0200 Subject: Re: [PATCH bpf-next 1/1] arm64: bpf: Add BPF exception tables To: Jean-Philippe Brucker References: <20200728152122.1292756-1-jean-philippe@linaro.org> <20200728152122.1292756-2-jean-philippe@linaro.org> <20200730122855.GA3773@lca.pw> <20200730142213.GB1529030@myrica> <20200730211453.GA79372@lophozonia> From: Daniel Borkmann Message-ID: <74433d9e-012d-a20f-129f-ce934e8090aa@iogearbox.net> Date: Fri, 31 Jul 2020 00:45:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20200730211453.GA79372@lophozonia> Content-Language: en-US X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.3/25889/Thu Jul 30 17:03:53 2020) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200730_184534_235626_37C0A095 X-CRM114-Status: GOOD ( 16.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sfr@canb.auug.org.au, songliubraving@fb.com, will@kernel.org, catalin.marinas@arm.com, john.fastabend@gmail.com, ast@kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, Qian Cai , zlim.lnx@gmail.com, kpsingh@chromium.org, yhs@fb.com, bpf@vger.kernel.org, andriin@fb.com, kafai@fb.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/30/20 11:14 PM, Jean-Philippe Brucker wrote: > On Thu, Jul 30, 2020 at 09:47:39PM +0200, Daniel Borkmann wrote: >> On 7/30/20 4:22 PM, Jean-Philippe Brucker wrote: >>> On Thu, Jul 30, 2020 at 08:28:56AM -0400, Qian Cai wrote: >>>> On Tue, Jul 28, 2020 at 05:21:26PM +0200, Jean-Philippe Brucker wrote: >>>>> When a tracing BPF program attempts to read memory without using the >>>>> bpf_probe_read() helper, the verifier marks the load instruction with >>>>> the BPF_PROBE_MEM flag. Since the arm64 JIT does not currently recognize >>>>> this flag it falls back to the interpreter. >>>>> >>>>> Add support for BPF_PROBE_MEM, by appending an exception table to the >>>>> BPF program. If the load instruction causes a data abort, the fixup >>>>> infrastructure finds the exception table and fixes up the fault, by >>>>> clearing the destination register and jumping over the faulting >>>>> instruction. >>>>> >>>>> To keep the compact exception table entry format, inspect the pc in >>>>> fixup_exception(). A more generic solution would add a "handler" field >>>>> to the table entry, like on x86 and s390. >>>>> >>>>> Signed-off-by: Jean-Philippe Brucker >>>> >>>> This will fail to compile on arm64, >>>> >>>> https://gitlab.com/cailca/linux-mm/-/blob/master/arm64.config >>>> >>>> arch/arm64/mm/extable.o: In function `fixup_exception': >>>> arch/arm64/mm/extable.c:19: undefined reference to `arm64_bpf_fixup_exception' >>> >>> Thanks for the report, I attached a fix. Daniel, can I squash it and >>> resend as v2 or is it too late? >> >> If you want I can squash your attached snippet into the original patch of >> yours. If you want to send a v2 that is fine as well of course. Let me know. > > Yes please squash it into the original patch, sorry for the mess Done, thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel