From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95C2BC433EF for ; Wed, 16 Mar 2022 07:54:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354355AbiCPHzM (ORCPT ); Wed, 16 Mar 2022 03:55:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350753AbiCPHzL (ORCPT ); Wed, 16 Mar 2022 03:55:11 -0400 Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [81.169.146.167]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2B8C36E13 for ; Wed, 16 Mar 2022 00:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1647417235; s=strato-dkim-0002; d=hartkopp.net; h=In-Reply-To:From:References:Cc:To:Subject:Date:Message-ID:Cc:Date: From:Subject:Sender; bh=ZKeYXg7iZtoAI5R8gmapQORusApVRuYXng9ASoCvUbc=; b=ShCoJPfNw47hPwHe5r9Pc4X+Xrcy66zlX1hjNHREDbAk/ZynyeKnRQwKtDENsSAzZe 3Pn0CGOmcv4EnYiLTLaQPiInVI9osk+tkXp+Bi11Dv4NRQ8Ea5bK5AkYj9DdvCotDX34 XZz3dCJX4xnOj1QUu8H/kLKP3GSYf7ZBv/0vuJQMmZBuymUopPDMxy6ruATcdZmWX/q+ skzCqSgbbywYm4uKJoB6zsR/M6XK8BIzPRIl8J2vwHuQ+XKX4xMfnxt7FbNE8upsoxBE AjMQ2lyY/sq5p0aC/2avEYdZAwVGjuCMhVwmLskfTmF0hqBxH+HCLGV2OpwN8dJPX4Ky QFhQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2MHfkW8eP4Mre39l357AZT/I7AY/7nT2yrDxb8mjG14FZxedJy6qgO1qCHSa1GLptZHusx3hdd0DIgVuBOfXW6v7w==" X-RZG-CLASS-ID: mo00 Received: from [IPV6:2a00:6020:1cfa:f900::b82] by smtp.strato.de (RZmta 47.41.0 AUTH) with ESMTPSA id a046a1y2G7rs1kI (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Wed, 16 Mar 2022 08:53:54 +0100 (CET) Message-ID: <7445f2f1-4d89-116e-0cf7-fc7338c2901f@hartkopp.net> Date: Wed, 16 Mar 2022 08:53:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [net-next] can: isotp: sanitize CAN ID checks in isotp_bind() Content-Language: en-US To: Marc Kleine-Budde Cc: Jakub Kicinski , netdev@vger.kernel.org, syzbot+2339c27f5c66c652843e@syzkaller.appspotmail.com References: <20220315203748.1892-1-socketcan@hartkopp.net> <20220315185134.687fe506@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <3922032f-c829-b609-e408-6dec83a0041a@hartkopp.net> <20220316074802.b3xazftb7axziue3@pengutronix.de> From: Oliver Hartkopp In-Reply-To: <20220316074802.b3xazftb7axziue3@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 16.03.22 08:48, Marc Kleine-Budde wrote: > On 16.03.2022 08:35:58, Oliver Hartkopp wrote: >> >> >> On 16.03.22 02:51, Jakub Kicinski wrote: >>> On Tue, 15 Mar 2022 21:37:48 +0100 Oliver Hartkopp wrote: >>>> Syzbot created an environment that lead to a state machine status that >>>> can not be reached with a compliant CAN ID address configuration. >>>> The provided address information consisted of CAN ID 0x6000001 and 0xC28001 >>>> which both boil down to 11 bit CAN IDs 0x001 in sending and receiving. >>>> >>>> Sanitize the SFF/EFF CAN ID values before performing the address checks. >>>> >>>> Fixes: e057dd3fc20f ("can: add ISO 15765-2:2016 transport protocol") >>>> Reported-by: syzbot+2339c27f5c66c652843e@syzkaller.appspotmail.com >>>> Signed-off-by: Oliver Hartkopp >>> >>> CC Marc, please make sure you CC maintainers. >> >> Oh, that would have been better! I'm maintaining the CAN network layer stuff >> together with Marc and there was no relevant stuff in can-next to be pulled >> in the next days. So I sent it directly to hit the merge window and had all >> of us in the reply to the syzbot report. >> >> Will CC Marc next time when posting to netdev only! >> >> Maybe I treated this patch more urgent than it needed to be handled >> ¯\_(ツ)_/¯ > > Should this go into net/master with stable on Cc or to net-next? This patch is for net-next as it won't apply to net/master nor the stable trees due to the recent changes in net-next. As it contains a Fixes: tag I would send the patch for the stable trees when the patch hits Linus' tree and likely Greg would show up asking for it. I hope that's the most elegant process here?!? Best regards, Oliver