From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "rdunlap@infradead.org" <rdunlap@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"lee.jones@linaro.org" <lee.jones@linaro.org>
Subject: Re: [PATCH] regulator: bd71815: add select to fix build
Date: Mon, 24 May 2021 05:30:56 +0000 [thread overview]
Message-ID: <744ae90afc192e0b527ddfc4c54ab9fccfa9343c.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <20210523001427.13500-1-rdunlap@infradead.org>
On Sat, 2021-05-22 at 17:14 -0700, Randy Dunlap wrote:
> Mend the Kconfig for REGULATOR_BD71815 to prevent build errors:
>
> riscv32-linux-ld: drivers/regulator/bd71815-regulator.o: in function
> `.L0 ':
> regulator.c:289: undefined reference to
> `rohm_regulator_set_dvs_levels'
> riscv32-linux-ld: drivers/regulator/bd71815-regulator.c:370:
> undefined reference to `rohm_regulator_set_dvs_levels'
>
> Fixes: 1aad39001e85 ("regulator: Support ROHM BD71815 regulators")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> ---
Reviewed-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Thank you (again) for fixing this Randy.
I am quite sure this is not the first time I see this patch. As far as
I remember few fixes were sent during last development cycle by Randy
and Arnd - but I think they were not merged because commits they fixed
were not yet in regulator tree.
I could go through those and resend them if they are missing - but is
there a way to do that while giving the credit to original authors?
> drivers/regulator/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210521.orig/drivers/regulator/Kconfig
> +++ linux-next-20210521/drivers/regulator/Kconfig
> @@ -207,6 +207,7 @@ config REGULATOR_BD70528
> config REGULATOR_BD71815
> tristate "ROHM BD71815 Power Regulator"
> depends on MFD_ROHM_BD71828
> + select REGULATOR_ROHM
> help
> This driver supports voltage regulators on ROHM BD71815 PMIC.
> This will enable support for the software controllable buck
next prev parent reply other threads:[~2021-05-24 5:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-23 0:14 [PATCH] regulator: bd71815: add select to fix build Randy Dunlap
2021-05-24 5:30 ` Vaittinen, Matti [this message]
2021-05-24 11:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=744ae90afc192e0b527ddfc4c54ab9fccfa9343c.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.