All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mats Karrman <mats.dev.list@gmail.com>
To: meta-freescale@yoctoproject.org, fabio.berton@ossystems.com.br
Subject: [PATCH] fsl-kernel-localversion: Add preconfigure dependency on do_unpack
Date: Thu, 13 Apr 2017 17:33:24 +0200	[thread overview]
Message-ID: <744dfea1-8cb1-3444-afbd-facbcb5a58eb@gmail.com> (raw)

From: Mats Karrman <mats@southpole.se>
Date: Thu, 13 Apr 2017 17:11:58 +0200
Subject: [PATCH] fsl-kernel-localversion: Add preconfigure dependency on 
do_unpack

Even if 'externalsrc' is used, SRC_URI may specify a 'defconfig'.
However as the use of 'externalsrc' will do away with the do_patch
task, do_preconfigure is in risk of being run before the defconfig
is copied to the build directory. This patch adds a second dependency
on 'do_unpack' that makes sure this does not happen.
---
  classes/fsl-kernel-localversion.bbclass | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Typical error message:
ERROR: linux-rabbit-4.10-r0 do_preconfigure: Function failed: 
do_preconfigure (log file is located at 
/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/temp/log.do_preconfigure.10215)
ERROR: Logfile of failure stored in: 
/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/temp/log.do_preconfigure.10215
Log data follows:
| DEBUG: Executing shell function do_preconfigure
| 
/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/temp/run.do_preconfigure.10215: 
line 116: 
/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/defconfig: 
No such file or directory
| WARNING: 
/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/temp/run.do_preconfigure.10215:1 
exit 1 from 'sed -e "${CONF_SED_SCRIPT}" < 
'/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/defconfig' 
 >> 
'/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/linux-rabbit-4.10//.config''
| ERROR: Function failed: do_preconfigure (log file is located at 
/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/temp/log.do_preconfigure.10215)
ERROR: Task 49 
(/home/mats/projects/cubox/oe/meta-local/recipes-kernel/linux/linux-rabbit_4.10.bb, 
do_preconfigure) failed with exit code '1'

The fix is tested on krogoth but should apply equally to master as 
nothing has
changed here as far as I can tell.

---

diff --git a/classes/fsl-kernel-localversion.bbclass 
b/classes/fsl-kernel-localversion.bbclass
index 48e5403..c0306a0 100644
--- a/classes/fsl-kernel-localversion.bbclass
+++ b/classes/fsl-kernel-localversion.bbclass
@@ -38,4 +38,4 @@ do_preconfigure() {
          printf "%s%s" +g $head > ${S}/.scmversion
      fi
  }
-addtask preconfigure before do_configure after do_patch
+addtask preconfigure before do_configure after do_unpack do_patch
-- 
2.1.4



             reply	other threads:[~2017-04-13 15:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-13 15:33 Mats Karrman [this message]
2017-04-25 13:51 ` [PATCH] fsl-kernel-localversion: Add preconfigure dependency on do_unpack Otavio Salvador
2017-04-25 20:28   ` Mats Karrman
2017-04-25 20:35     ` Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=744dfea1-8cb1-3444-afbd-facbcb5a58eb@gmail.com \
    --to=mats.dev.list@gmail.com \
    --cc=fabio.berton@ossystems.com.br \
    --cc=meta-freescale@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.