From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A625C43144 for ; Fri, 29 Jun 2018 16:03:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1875B27446 for ; Fri, 29 Jun 2018 16:03:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1875B27446 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966831AbeF2QDT (ORCPT ); Fri, 29 Jun 2018 12:03:19 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:49824 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934781AbeF2QDO (ORCPT ); Fri, 29 Jun 2018 12:03:14 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 486527A7E5; Fri, 29 Jun 2018 16:03:13 +0000 (UTC) Received: from [10.36.116.133] (ovpn-116-133.ams2.redhat.com [10.36.116.133]) by smtp.corp.redhat.com (Postfix) with ESMTP id 057442026D68; Fri, 29 Jun 2018 16:03:09 +0000 (UTC) Subject: Re: [PATCH v34 0/4] Virtio-balloon: support free page reporting To: "Wang, Wei W" , "virtio-dev@lists.oasis-open.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "kvm@vger.kernel.org" , "linux-mm@kvack.org" , "mst@redhat.com" , "mhocko@kernel.org" , "akpm@linux-foundation.org" Cc: "torvalds@linux-foundation.org" , "pbonzini@redhat.com" , "liliang.opensource@gmail.com" , "yang.zhang.wz@gmail.com" , "quan.xu0@gmail.com" , "nilal@redhat.com" , "riel@redhat.com" , "peterx@redhat.com" , Andrea Arcangeli , Luiz Capitulino References: <1529928312-30500-1-git-send-email-wei.w.wang@intel.com> <5B35ACD5.4090800@intel.com> <4840cbb7-dd3f-7540-6a7c-13427de2f0d1@redhat.com> <5B36189E.5050204@intel.com> <34bb25eb-97f3-8a9f-8a13-401dfcf39a2c@redhat.com> <286AC319A985734F985F78AFA26841F7396C254C@shsmsx102.ccr.corp.intel.com> From: David Hildenbrand Openpgp: preference=signencrypt Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwX4EEwECACgFAljj9eoCGwMFCQlmAYAGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEE3eEPcA/4Na5IIP/3T/FIQMxIfNzZshIq687qgG 8UbspuE/YSUDdv7r5szYTK6KPTlqN8NAcSfheywbuYD9A4ZeSBWD3/NAVUdrCaRP2IvFyELj xoMvfJccbq45BxzgEspg/bVahNbyuBpLBVjVWwRtFCUEXkyazksSv8pdTMAs9IucChvFmmq3 jJ2vlaz9lYt/lxN246fIVceckPMiUveimngvXZw21VOAhfQ+/sofXF8JCFv2mFcBDoa7eYob s0FLpmqFaeNRHAlzMWgSsP80qx5nWWEvRLdKWi533N2vC/EyunN3HcBwVrXH4hxRBMco3jvM m8VKLKao9wKj82qSivUnkPIwsAGNPdFoPbgghCQiBjBe6A75Z2xHFrzo7t1jg7nQfIyNC7ez MZBJ59sqA9EDMEJPlLNIeJmqslXPjmMFnE7Mby/+335WJYDulsRybN+W5rLT5aMvhC6x6POK z55fMNKrMASCzBJum2Fwjf/VnuGRYkhKCqqZ8gJ3OvmR50tInDV2jZ1DQgc3i550T5JDpToh dPBxZocIhzg+MBSRDXcJmHOx/7nQm3iQ6iLuwmXsRC6f5FbFefk9EjuTKcLMvBsEx+2DEx0E UnmJ4hVg7u1PQ+2Oy+Lh/opK/BDiqlQ8Pz2jiXv5xkECvr/3Sv59hlOCZMOaiLTTjtOIU7Tq 7ut6OL64oAq+zsFNBFXLn5EBEADn1959INH2cwYJv0tsxf5MUCghCj/CA/lc/LMthqQ773ga uB9mN+F1rE9cyyXb6jyOGn+GUjMbnq1o121Vm0+neKHUCBtHyseBfDXHA6m4B3mUTWo13nid 0e4AM71r0DS8+KYh6zvweLX/LL5kQS9GQeT+QNroXcC1NzWbitts6TZ+IrPOwT1hfB4WNC+X 2n4AzDqp3+ILiVST2DT4VBc11Gz6jijpC/KI5Al8ZDhRwG47LUiuQmt3yqrmN63V9wzaPhC+ xbwIsNZlLUvuRnmBPkTJwwrFRZvwu5GPHNndBjVpAfaSTOfppyKBTccu2AXJXWAE1Xjh6GOC 8mlFjZwLxWFqdPHR1n2aPVgoiTLk34LR/bXO+e0GpzFXT7enwyvFFFyAS0Nk1q/7EChPcbRb hJqEBpRNZemxmg55zC3GLvgLKd5A09MOM2BrMea+l0FUR+PuTenh2YmnmLRTro6eZ/qYwWkC u8FFIw4pT0OUDMyLgi+GI1aMpVogTZJ70FgV0pUAlpmrzk/bLbRkF3TwgucpyPtcpmQtTkWS gDS50QG9DR/1As3LLLcNkwJBZzBG6PWbvcOyrwMQUF1nl4SSPV0LLH63+BrrHasfJzxKXzqg rW28CTAE2x8qi7e/6M/+XXhrsMYG+uaViM7n2je3qKe7ofum3s4vq7oFCPsOgwARAQABwsFl BBgBAgAPBQJVy5+RAhsMBQkJZgGAAAoJEE3eEPcA/4NagOsP/jPoIBb/iXVbM+fmSHOjEshl KMwEl/m5iLj3iHnHPVLBUWrXPdS7iQijJA/VLxjnFknhaS60hkUNWexDMxVVP/6lbOrs4bDZ NEWDMktAeqJaFtxackPszlcpRVkAs6Msn9tu8hlvB517pyUgvuD7ZS9gGOMmYwFQDyytpepo YApVV00P0u3AaE0Cj/o71STqGJKZxcVhPaZ+LR+UCBZOyKfEyq+ZN311VpOJZ1IvTExf+S/5 lqnciDtbO3I4Wq0ArLX1gs1q1XlXLaVaA3yVqeC8E7kOchDNinD3hJS4OX0e1gdsx/e6COvy qNg5aL5n0Kl4fcVqM0LdIhsubVs4eiNCa5XMSYpXmVi3HAuFyg9dN+x8thSwI836FoMASwOl C7tHsTjnSGufB+D7F7ZBT61BffNBBIm1KdMxcxqLUVXpBQHHlGkbwI+3Ye+nE6HmZH7IwLwV W+Ajl7oYF+jeKaH4DZFtgLYGLtZ1LDwKPjX7VAsa4Yx7S5+EBAaZGxK510MjIx6SGrZWBrrV TEvdV00F2MnQoeXKzD7O4WFbL55hhyGgfWTHwZ457iN9SgYi1JLPqWkZB0JRXIEtjd4JEQcx +8Umfre0Xt4713VxMygW0PnQt5aSQdMD58jHFxTk092mU+yIHj5LeYgvwSgZN4airXk5yRXl SE+xAvmumFBY Organization: Red Hat GmbH Message-ID: <745eb950-eb52-e32a-b006-5612a026c2dc@redhat.com> Date: Fri, 29 Jun 2018 18:03:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <286AC319A985734F985F78AFA26841F7396C254C@shsmsx102.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 29 Jun 2018 16:03:13 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 29 Jun 2018 16:03:13 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'david@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Why would your suggestion still be applicable? >> >> Your point for now is "I might not want to have page hinting enabled due to >> the overhead, but still a live migration speedup". If that overhead actually >> exists (we'll have to see) or there might be another reason to disable page >> hinting, then we have to decide if that specific setup is worth it merging your >> changes. > > All the above "if we have", "assume we have" don't sound like a valid argument to me. Argument? *confused* And that hinders you from answering the question "Why would your suggestion still be applicable?" ? Well, okay. So I will answer it by myself: Because somebody would want to disable page hinting. Maybe there are some people out there. > >> I am not (and don't want to be) in the position to make any decisions here :) I >> just want to understand if two interfaces for free pages actually make sense. > > I responded to Nitesh about the differences, you may want to check with him about this. > I would suggest you to send out your patches to LKML to get a discussion with the mm folks. Indeed, Nitesh is trying to solve the problems we found in the RFC, so this can take some time. > > Best, > Wei > -- Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Subject: Re: [PATCH v34 0/4] Virtio-balloon: support free page reporting Date: Fri, 29 Jun 2018 18:03:09 +0200 Message-ID: <745eb950-eb52-e32a-b006-5612a026c2dc@redhat.com> References: <1529928312-30500-1-git-send-email-wei.w.wang@intel.com> <5B35ACD5.4090800@intel.com> <4840cbb7-dd3f-7540-6a7c-13427de2f0d1@redhat.com> <5B36189E.5050204@intel.com> <34bb25eb-97f3-8a9f-8a13-401dfcf39a2c@redhat.com> <286AC319A985734F985F78AFA26841F7396C254C@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "yang.zhang.wz@gmail.com" , Andrea Arcangeli , "riel@redhat.com" , "quan.xu0@gmail.com" , "liliang.opensource@gmail.com" , Luiz Capitulino , "pbonzini@redhat.com" , "nilal@redhat.com" , "torvalds@linux-foundation.org" To: "Wang, Wei W" , "virtio-dev@lists.oasis-open.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "kvm@vger.kernel.org" , "linux-mm@kvack.org" , "mst@redhat.com" , "mhocko@kernel.org" , "akpm@linux-foundation.org" Return-path: In-Reply-To: <286AC319A985734F985F78AFA26841F7396C254C@shsmsx102.ccr.corp.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: kvm.vger.kernel.org >> Why would your suggestion still be applicable? >> >> Your point for now is "I might not want to have page hinting enabled due to >> the overhead, but still a live migration speedup". If that overhead actually >> exists (we'll have to see) or there might be another reason to disable page >> hinting, then we have to decide if that specific setup is worth it merging your >> changes. > > All the above "if we have", "assume we have" don't sound like a valid argument to me. Argument? *confused* And that hinders you from answering the question "Why would your suggestion still be applicable?" ? Well, okay. So I will answer it by myself: Because somebody would want to disable page hinting. Maybe there are some people out there. > >> I am not (and don't want to be) in the position to make any decisions here :) I >> just want to understand if two interfaces for free pages actually make sense. > > I responded to Nitesh about the differences, you may want to check with him about this. > I would suggest you to send out your patches to LKML to get a discussion with the mm folks. Indeed, Nitesh is trying to solve the problems we found in the RFC, so this can take some time. > > Best, > Wei > -- Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f198.google.com (mail-qk0-f198.google.com [209.85.220.198]) by kanga.kvack.org (Postfix) with ESMTP id E068C6B0270 for ; Fri, 29 Jun 2018 12:03:14 -0400 (EDT) Received: by mail-qk0-f198.google.com with SMTP id d64-v6so9674230qkb.23 for ; Fri, 29 Jun 2018 09:03:14 -0700 (PDT) Received: from mx1.redhat.com (mx3-rdu2.redhat.com. [66.187.233.73]) by mx.google.com with ESMTPS id t15-v6si9774268qta.327.2018.06.29.09.03.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Jun 2018 09:03:13 -0700 (PDT) Subject: Re: [PATCH v34 0/4] Virtio-balloon: support free page reporting References: <1529928312-30500-1-git-send-email-wei.w.wang@intel.com> <5B35ACD5.4090800@intel.com> <4840cbb7-dd3f-7540-6a7c-13427de2f0d1@redhat.com> <5B36189E.5050204@intel.com> <34bb25eb-97f3-8a9f-8a13-401dfcf39a2c@redhat.com> <286AC319A985734F985F78AFA26841F7396C254C@shsmsx102.ccr.corp.intel.com> From: David Hildenbrand Message-ID: <745eb950-eb52-e32a-b006-5612a026c2dc@redhat.com> Date: Fri, 29 Jun 2018 18:03:09 +0200 MIME-Version: 1.0 In-Reply-To: <286AC319A985734F985F78AFA26841F7396C254C@shsmsx102.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Wang, Wei W" , "virtio-dev@lists.oasis-open.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "kvm@vger.kernel.org" , "linux-mm@kvack.org" , "mst@redhat.com" , "mhocko@kernel.org" , "akpm@linux-foundation.org" Cc: "torvalds@linux-foundation.org" , "pbonzini@redhat.com" , "liliang.opensource@gmail.com" , "yang.zhang.wz@gmail.com" , "quan.xu0@gmail.com" , "nilal@redhat.com" , "riel@redhat.com" , "peterx@redhat.com" , Andrea Arcangeli , Luiz Capitulino >> Why would your suggestion still be applicable? >> >> Your point for now is "I might not want to have page hinting enabled due to >> the overhead, but still a live migration speedup". If that overhead actually >> exists (we'll have to see) or there might be another reason to disable page >> hinting, then we have to decide if that specific setup is worth it merging your >> changes. > > All the above "if we have", "assume we have" don't sound like a valid argument to me. Argument? *confused* And that hinders you from answering the question "Why would your suggestion still be applicable?" ? Well, okay. So I will answer it by myself: Because somebody would want to disable page hinting. Maybe there are some people out there. > >> I am not (and don't want to be) in the position to make any decisions here :) I >> just want to understand if two interfaces for free pages actually make sense. > > I responded to Nitesh about the differences, you may want to check with him about this. > I would suggest you to send out your patches to LKML to get a discussion with the mm folks. Indeed, Nitesh is trying to solve the problems we found in the RFC, so this can take some time. > > Best, > Wei > -- Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-4611-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id 0D31758191AB for ; Fri, 29 Jun 2018 09:03:23 -0700 (PDT) References: <1529928312-30500-1-git-send-email-wei.w.wang@intel.com> <5B35ACD5.4090800@intel.com> <4840cbb7-dd3f-7540-6a7c-13427de2f0d1@redhat.com> <5B36189E.5050204@intel.com> <34bb25eb-97f3-8a9f-8a13-401dfcf39a2c@redhat.com> <286AC319A985734F985F78AFA26841F7396C254C@shsmsx102.ccr.corp.intel.com> From: David Hildenbrand Message-ID: <745eb950-eb52-e32a-b006-5612a026c2dc@redhat.com> Date: Fri, 29 Jun 2018 18:03:09 +0200 MIME-Version: 1.0 In-Reply-To: <286AC319A985734F985F78AFA26841F7396C254C@shsmsx102.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: [virtio-dev] Re: [PATCH v34 0/4] Virtio-balloon: support free page reporting To: "Wang, Wei W" , "virtio-dev@lists.oasis-open.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "kvm@vger.kernel.org" , "linux-mm@kvack.org" , "mst@redhat.com" , "mhocko@kernel.org" , "akpm@linux-foundation.org" Cc: "torvalds@linux-foundation.org" , "pbonzini@redhat.com" , "liliang.opensource@gmail.com" , "yang.zhang.wz@gmail.com" , "quan.xu0@gmail.com" , "nilal@redhat.com" , "riel@redhat.com" , "peterx@redhat.com" , Andrea Arcangeli , Luiz Capitulino List-ID: >> Why would your suggestion still be applicable? >> >> Your point for now is "I might not want to have page hinting enabled due to >> the overhead, but still a live migration speedup". If that overhead actually >> exists (we'll have to see) or there might be another reason to disable page >> hinting, then we have to decide if that specific setup is worth it merging your >> changes. > > All the above "if we have", "assume we have" don't sound like a valid argument to me. Argument? *confused* And that hinders you from answering the question "Why would your suggestion still be applicable?" ? Well, okay. So I will answer it by myself: Because somebody would want to disable page hinting. Maybe there are some people out there. > >> I am not (and don't want to be) in the position to make any decisions here :) I >> just want to understand if two interfaces for free pages actually make sense. > > I responded to Nitesh about the differences, you may want to check with him about this. > I would suggest you to send out your patches to LKML to get a discussion with the mm folks. Indeed, Nitesh is trying to solve the problems we found in the RFC, so this can take some time. > > Best, > Wei > -- Thanks, David / dhildenb --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org