From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E78BC072B1 for ; Tue, 28 May 2019 15:49:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35AE221530 for ; Tue, 28 May 2019 15:49:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726858AbfE1PtC (ORCPT ); Tue, 28 May 2019 11:49:02 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:59632 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726452AbfE1PtC (ORCPT ); Tue, 28 May 2019 11:49:02 -0400 Received: from 79.184.255.225.ipv4.supernova.orange.pl (79.184.255.225) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.213) id f088da01f68d15dd; Tue, 28 May 2019 17:48:59 +0200 From: "Rafael J. Wysocki" To: Michael Ellerman Cc: Mathieu Malaterre , Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , Pavel Machek , Len Brown , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2] powerpc/power: Expose pfn_is_nosave prototype Date: Tue, 28 May 2019 17:48:58 +0200 Message-ID: <7467366.tOSDWnDKPa@kreacher> In-Reply-To: <875zpvqsy9.fsf@concordia.ellerman.id.au> References: <20190523114736.30268-1-malat@debian.org> <1929721.iDiXxTFbjN@kreacher> <875zpvqsy9.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, May 28, 2019 3:16:30 AM CEST Michael Ellerman wrote: > "Rafael J. Wysocki" writes: > > On Friday, May 24, 2019 12:44:18 PM CEST Mathieu Malaterre wrote: > >> The declaration for pfn_is_nosave is only available in > >> kernel/power/power.h. Since this function can be override in arch, > >> expose it globally. Having a prototype will make sure to avoid warning > >> (sometime treated as error with W=1) such as: > >> > >> arch/powerpc/kernel/suspend.c:18:5: error: no previous prototype for 'pfn_is_nosave' [-Werror=missing-prototypes] > >> > >> This moves the declaration into a globally visible header file and add > >> missing include to avoid a warning on powerpc. Also remove the > >> duplicated prototypes since not required anymore. > >> > >> Cc: Christophe Leroy > >> Signed-off-by: Mathieu Malaterre > >> --- > >> v2: As suggestion by christophe remove duplicates prototypes > >> > >> arch/powerpc/kernel/suspend.c | 1 + > >> arch/s390/kernel/entry.h | 1 - > >> include/linux/suspend.h | 1 + > >> kernel/power/power.h | 2 -- > >> 4 files changed, 2 insertions(+), 3 deletions(-) > >> > >> diff --git a/kernel/power/power.h b/kernel/power/power.h > >> index 9e58bdc8a562..44bee462ff57 100644 > >> --- a/kernel/power/power.h > >> +++ b/kernel/power/power.h > >> @@ -75,8 +75,6 @@ static inline void hibernate_reserved_size_init(void) {} > >> static inline void hibernate_image_size_init(void) {} > >> #endif /* !CONFIG_HIBERNATION */ > >> > >> -extern int pfn_is_nosave(unsigned long); > >> - > >> #define power_attr(_name) \ > >> static struct kobj_attribute _name##_attr = { \ > >> .attr = { \ > >> > > > > With an ACK from the powerpc maintainers, I could apply this one. > > Sent. Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E661AC04AB6 for ; Tue, 28 May 2019 15:50:26 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D96A2166E for ; Tue, 28 May 2019 15:50:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D96A2166E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45Cywb6lQ7zDqQ9 for ; Wed, 29 May 2019 01:50:23 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=rjwysocki.net (client-ip=79.96.170.134; helo=cloudserver094114.home.pl; envelope-from=rjw@rjwysocki.net; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net Received: from cloudserver094114.home.pl (cloudserver094114.home.pl [79.96.170.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45Cyv55dvRzDqKD for ; Wed, 29 May 2019 01:49:04 +1000 (AEST) Received: from 79.184.255.225.ipv4.supernova.orange.pl (79.184.255.225) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.213) id f088da01f68d15dd; Tue, 28 May 2019 17:48:59 +0200 From: "Rafael J. Wysocki" To: Michael Ellerman Subject: Re: [PATCH v2] powerpc/power: Expose pfn_is_nosave prototype Date: Tue, 28 May 2019 17:48:58 +0200 Message-ID: <7467366.tOSDWnDKPa@kreacher> In-Reply-To: <875zpvqsy9.fsf@concordia.ellerman.id.au> References: <20190523114736.30268-1-malat@debian.org> <1929721.iDiXxTFbjN@kreacher> <875zpvqsy9.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Len Brown , linux-s390@vger.kernel.org, Mathieu Malaterre , linux-pm@vger.kernel.org, Heiko Carstens , linux-kernel@vger.kernel.org, Paul Mackerras , Pavel Machek , Martin Schwidefsky , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tuesday, May 28, 2019 3:16:30 AM CEST Michael Ellerman wrote: > "Rafael J. Wysocki" writes: > > On Friday, May 24, 2019 12:44:18 PM CEST Mathieu Malaterre wrote: > >> The declaration for pfn_is_nosave is only available in > >> kernel/power/power.h. Since this function can be override in arch, > >> expose it globally. Having a prototype will make sure to avoid warning > >> (sometime treated as error with W=1) such as: > >> > >> arch/powerpc/kernel/suspend.c:18:5: error: no previous prototype for 'pfn_is_nosave' [-Werror=missing-prototypes] > >> > >> This moves the declaration into a globally visible header file and add > >> missing include to avoid a warning on powerpc. Also remove the > >> duplicated prototypes since not required anymore. > >> > >> Cc: Christophe Leroy > >> Signed-off-by: Mathieu Malaterre > >> --- > >> v2: As suggestion by christophe remove duplicates prototypes > >> > >> arch/powerpc/kernel/suspend.c | 1 + > >> arch/s390/kernel/entry.h | 1 - > >> include/linux/suspend.h | 1 + > >> kernel/power/power.h | 2 -- > >> 4 files changed, 2 insertions(+), 3 deletions(-) > >> > >> diff --git a/kernel/power/power.h b/kernel/power/power.h > >> index 9e58bdc8a562..44bee462ff57 100644 > >> --- a/kernel/power/power.h > >> +++ b/kernel/power/power.h > >> @@ -75,8 +75,6 @@ static inline void hibernate_reserved_size_init(void) {} > >> static inline void hibernate_image_size_init(void) {} > >> #endif /* !CONFIG_HIBERNATION */ > >> > >> -extern int pfn_is_nosave(unsigned long); > >> - > >> #define power_attr(_name) \ > >> static struct kobj_attribute _name##_attr = { \ > >> .attr = { \ > >> > > > > With an ACK from the powerpc maintainers, I could apply this one. > > Sent. Thanks!